code review fixes

- change so all forward slashes have space around them
- fix so min window height doesn't cut off buttons
- for multi gameobject convert, show filename as "automatic"

Author: vkovec

Assets/FbxExporters/Editor/ConvertToModel.cs

@@ -4,6 +4,7 @@
 using UnityEngine.SceneManagement;
 using UnityEditor;
 using Unity.FbxSdk;
+using System.Linq;
 
 namespace FbxExporters
 {
@@ -76,8 +77,7 @@ public static GameObject[] CreateInstantiatedModelPrefab (
                 GameObject [] unityGameObjectsToConvert)
             {
                 var toExport = ModelExporter.RemoveRedundantObjects (unityGameObjectsToConvert);
-                var wasExported = new GameObject[toExport.Count];
-                toExport.CopyTo (wasExported);
+                var wasExported = Enumerable.ToArray (toExport);
                 ConvertToPrefabEditorWindow.Init (wasExported);
                 return wasExported;
             }

Assets/FbxExporters/Editor/ConvertToPrefabEditorWindow.cs

@@ -4,6 +4,7 @@
 using UnityEditor;
 using FbxExporters.EditorTools;
 using UnityEditor.Presets;
+using System.Linq;
 
 namespace FbxExporters
 {
@@ -12,6 +13,7 @@ namespace Editor
         public class ConvertToPrefabEditorWindow : ExportOptionsEditorWindow
         {
             protected override GUIContent m_windowTitle { get { return new GUIContent ("Convert Options"); }}
+            protected override float MinWindowHeight { get { return 280; } }
             private GameObject[] m_toConvert;
             private string m_prefabFileName = "";
 
@@ -24,22 +26,19 @@ public static void Init (IEnumerable<GameObject> toConvert)
             }
 
             protected void SetGameObjectsToConvert(IEnumerable<GameObject> toConvert){
-                var tempList = new List<GameObject> ();
-                foreach (var go in toConvert) {
-                    tempList.Add (go);
-                }
-                m_toConvert = tempList.ToArray ();
+                m_toConvert = Enumerable.ToArray (toConvert);
 
-                if (m_toConvert.Length >= 1) {
+                if (m_toConvert.Length == 1) {
                     m_prefabFileName = m_toConvert [0].name;
-                    this.SetFilename (m_prefabFileName);
+                } else if (m_toConvert.Length > 1) {
+                    m_prefabFileName = "(automatic)";
                 }
+                this.SetFilename (m_prefabFileName);
             }
 
             protected override void OnEnable ()
             {
                 base.OnEnable ();
-
                 if (!m_innerEditor) {
                     var ms = ExportSettings.instance.convertToPrefabSettings;
                     if (!ms) {

Assets/FbxExporters/Editor/ExportModelEditorWindow.cs

@@ -19,6 +19,7 @@ public abstract class ExportOptionsEditorWindow : EditorWindow
             protected const float TextFieldAlignOffset = 3;
             protected const float ExportButtonWidth = 100;
             protected const float FbxExtOffset = -7;
+            protected virtual float MinWindowHeight { get { return 250; } }
 
             protected virtual GUIContent m_windowTitle { get { return new GUIContent (DefaultWindowTitle); } }
 
@@ -41,7 +42,7 @@ public abstract class ExportOptionsEditorWindow : EditorWindow
             protected virtual void OnEnable(){
                 InitializeReceiver ();
                 m_showOptions = true;
-                this.minSize = new Vector2 (SelectableLabelMinWidth + LabelWidth + BrowseButtonWidth, 220);
+                this.minSize = new Vector2 (SelectableLabelMinWidth + LabelWidth + BrowseButtonWidth, MinWindowHeight);
 
                 m_nameTextFieldStyle = new GUIStyle(GUIStyle.none);
                 m_nameTextFieldStyle.alignment = TextAnchor.LowerCenter;

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -958,9 +958,9 @@ public static string[] GetRelativeSavePaths(List<string> exportSavePaths){
             string[] relSavePaths = new string[exportSavePaths.Count];
             // use special forward slash unicode char as "/" is a special character
             // that affects the dropdown layout.
-            string forwardslash = "\u2044";
+            string forwardslash = " \u2044 ";
             for (int i = 0; i < relSavePaths.Length; i++) {
-                relSavePaths [i] = string.Format("Assets {0} {1}", forwardslash, exportSavePaths[i] == "."? "" : NormalizePath(exportSavePaths [i], isRelative: true).Replace("/", forwardslash));
+                relSavePaths [i] = string.Format("Assets{0}{1}", forwardslash, exportSavePaths[i] == "."? "" : NormalizePath(exportSavePaths [i], isRelative: true).Replace("/", forwardslash));
             }
             return relSavePaths;
         }