PR add unit test for each method

Author: inwoods

Assets/com.unity.formats.fbx.tests/CustomExtensionsTest.cs

@@ -8,6 +8,7 @@
 using System.Collections.Generic;
 using System.Collections;
 using FbxExporters.CustomExtensions;
+using Unity.FbxSdk;
 
 namespace FbxExporters.UnitTests
 {
@@ -24,15 +25,89 @@ public override void Term ()
         }
 
         [Test]
-        public void MetricDistanceTest()
+        public void Vector3ExtensionTest()
+        {
+            var v3 = new Vector3(1f,2f,3f);
+            Assert.That(v3.RightHanded(), Is.EqualTo(new Vector3(-1f,2f,3f)));
+            Assert.That(v3.FbxVector4(), Is.EqualTo(new FbxVector4(1f,2f,3f)));
+        }
+
+        [Test]
+        public void AnimationCurveExtensionTest()
+        {
+            var ac = new AnimationCurve();
+            ac.Dump();
+            ac.Dump("hello world");
+            ac.Dump(keyTimesExpected:new float[]{});
+            ac.Dump(keyValuesExpected:new float[]{});
+            ac.Dump(keyTimesExpected:new float[]{}, keyValuesExpected:new float[]{});
+        }
+
+        [Test]
+        public void FloatExtensionTest()
         {
             Assert.That(Value1.Meters().ToCentimeters(), Is.EqualTo(100f));
-                
+
             Assert.That(1f.Meters(), Is.EqualTo(100f.Centimeters()));
             Assert.That(10f.Millimeters().ToMeters(), Is.EqualTo(1f.Centimeters().ToMeters()).Within(0.00001f));
             Assert.That(1f.Centimeters().ToMeters(), Is.EqualTo(10f.Millimeters().ToMeters()).Within(0.00001f));
             Assert.That(0.0254f.Meters(), Is.EqualTo(1f.Inches().ToMetric()));
             Assert.That(1f.Meters().ToImperial(), Is.EqualTo(39.3701f.Inches()));
         }
+
+        [Test]
+        public void ImperialDistanceTest()
+        {
+            var one_inch = new ImperialDistance(1f); // 1 inch
+            var one_foot = new ImperialDistance(12f); // 12 inches
+
+            Assert.That(ImperialDistance.Inch, Is.Not.EqualTo(new MetricDistance(1f)));
+            Assert.That(ImperialDistance.Inch, Is.EqualTo(new ImperialDistance(1f)));
+            Assert.That(ImperialDistance.Foot, Is.EqualTo(new ImperialDistance(12f)));
+
+            Assert.That(one_inch, Is.EqualTo(ImperialDistance.Inch));
+            Assert.That(one_inch.ToInches(), Is.EqualTo(ImperialDistance.Inch.ToInches()));
+            Assert.That(one_inch.ToMetric().ToMeters(), Is.EqualTo(0.0254f));
+            Assert.That(one_inch.ToMeters(), Is.EqualTo(0.0254f));
+            Assert.That(one_inch.ToInches(), Is.EqualTo(1f));
+            Assert.That(one_inch.GetHashCode(), Is.GreaterThan(0));
+            Assert.That(one_inch ==  ImperialDistance.Inch, Is.True);
+            Assert.That(one_inch ==  ImperialDistance.Inch, Is.True);
+
+            Assert.That(one_foot, Is.EqualTo(ImperialDistance.Foot));
+            Assert.That(one_foot!=one_inch, Is.True);
+
+            Assert.That(one_inch+one_inch, Is.EqualTo(new ImperialDistance(2f)));
+            Assert.That(one_inch-one_inch, Is.EqualTo(new ImperialDistance(0f)));
+            Assert.That(new ImperialDistance(2f)*new ImperialDistance(6f), Is.EqualTo(ImperialDistance.Foot));
+            Assert.That(ImperialDistance.Foot / ImperialDistance.Inch, Is.EqualTo(ImperialDistance.Foot));
+        }
+
+        [Test]
+        public void MetricDistanceTest()
+        {
+            var one_cm = new MetricDistance(0.01f); // 1 cm
+            var one_m = new MetricDistance(1f); // 100 cm
+
+            Assert.That(MetricDistance.Millimeter, Is.EqualTo(new MetricDistance(0.001f)));
+            Assert.That(MetricDistance.Centimeter, Is.EqualTo(new MetricDistance(0.01f)));
+            Assert.That(MetricDistance.Meter, Is.EqualTo(new MetricDistance(1f)));
+
+            Assert.That(one_m, Is.EqualTo(MetricDistance.Meter));
+            Assert.That(one_m.ToMeters(), Is.EqualTo(MetricDistance.Meter.ToMeters()));
+            Assert.That(one_m.ToImperial().ToInches(), Is.EqualTo(39.3701f));
+            Assert.That(one_m.ToMeters(), Is.EqualTo(1f));
+            Assert.That(one_m.GetHashCode(), Is.GreaterThan(0));
+            Assert.That(one_m ==  MetricDistance.Meter, Is.True);
+            Assert.That(one_cm ==  MetricDistance.Centimeter, Is.True);
+
+            Assert.That(one_m, Is.EqualTo(MetricDistance.Meter));
+            Assert.That(one_m!=one_cm, Is.True);
+
+            Assert.That(one_m+one_cm, Is.EqualTo(new MetricDistance(1.01f)));
+            Assert.That(one_m-one_cm, Is.EqualTo(new MetricDistance(0.99f)));
+            Assert.That(MetricDistance.Centimeter*MetricDistance.Meter, Is.EqualTo(new MetricDistance(0.01f)));
+            Assert.That(MetricDistance.Meter / MetricDistance.Centimeter, Is.EqualTo(new MetricDistance(100f)));
+        }
     }
 }

Packages/com.unity.formats.fbx/Editor/Scripts/CustomExtensions.cs

@@ -91,6 +91,7 @@ public override bool Equals(object obj) {
         public class ImperialDistance {
 
             public static readonly ImperialDistance Inch = new ImperialDistance(1.0f);
+            public static readonly ImperialDistance Foot = new ImperialDistance(12.0f);
 
             private float _inches;
 
@@ -174,6 +175,9 @@ public static MetricDistance Centimeters(this float that) {
             public static ImperialDistance Inches(this float that) {
                 return new ImperialDistance(that);
             }
+            public static ImperialDistance Feet(this float that) {
+                return new ImperialDistance(ImperialDistance.Foot.ToInches() * that);
+            }
         }
 
         //Extension methods must be defined in a static class
@@ -203,11 +207,11 @@ public static class AnimationCurveExtension
             // This is an extension method for the AnimationCurve class
             // The first parameter takes the "this" modifier
             // and specifies the type for which the method is defined.
-            public static void Dump (this AnimationCurve animCurve, string message, float[] keyTimesExpected = null, float[] keyValuesExpected = null)
+            public static void Dump (this AnimationCurve animCurve, string message="", float[] keyTimesExpected = null, float[] keyValuesExpected = null)
             {
                 int idx = 0;
                 foreach (var key in animCurve.keys) {
-                    if (keyTimesExpected != null && keyValuesExpected != null) {
+                    if (keyTimesExpected != null && keyValuesExpected != null && keyTimesExpected.Length==keyValuesExpected.Length) {
                         Debug.Log (string.Format ("{5} keys[{0}] {1}({3}) {2} ({4})",
                             idx, key.time, key.value,
                             keyTimesExpected [idx], keyValuesExpected [idx],