Merge pull request #123 from Unity-Technologies/UNI-24628-remove-embed-tex-option

UNI-24628 remove embed textures option

Author: benoithudson

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -28,7 +28,7 @@ public override void OnInspectorGUI() {
             }
 
             exportSettings.weldVertices = EditorGUILayout.Toggle ("Weld Vertices:", exportSettings.weldVertices);
-            exportSettings.embedTextures = EditorGUILayout.Toggle ("Embed Textures:", exportSettings.embedTextures);
+
             exportSettings.mayaCompatibleNames = EditorGUILayout.Toggle (
                 new GUIContent ("Convert to Maya Compatible Naming:",
                     "In Maya some symbols such as spaces and accents get replaced when importing an FBX " +
@@ -122,7 +122,6 @@ public class ExportSettings : ScriptableSingleton<ExportSettings>
 
         // Note: default values are set in LoadDefaults().
         public bool weldVertices;
-        public bool embedTextures;
         public bool mayaCompatibleNames;
         public bool centerObjects;
 
@@ -145,7 +144,6 @@ public class ExportSettings : ScriptableSingleton<ExportSettings>
         protected override void LoadDefaults()
         {
             weldVertices = true;
-            embedTextures = false;
             mayaCompatibleNames = true;
             centerObjects = true;
             convertToModelSavePath = kDefaultSavePath;

Assets/FbxExporters/Editor/FbxExporter.cs

@@ -925,18 +925,12 @@ public int ExportAll (IEnumerable<UnityEngine.Object> unityExportSet)
                         // Configure fbx IO settings.
                         fbxManager.SetIOSettings (FbxIOSettings.Create (fbxManager, Globals.IOSROOT));
 
-                        // Export texture as embedded
-                        if(EditorTools.ExportSettings.instance.embedTextures){
-                            fbxManager.GetIOSettings ().SetBoolProp (Globals.EXP_FBX_EMBEDDED, true);
-                        }
-
                         // Create the exporter
                         var fbxExporter = FbxExporter.Create (fbxManager, "Exporter");
 
                         // Initialize the exporter.
                         // fileFormat must be binary if we are embedding textures
-                        int fileFormat = EditorTools.ExportSettings.instance.embedTextures? -1 :
-                            fbxManager.GetIOPluginRegistry ().FindWriterIDByDescription ("FBX ascii (*.fbx)");
+                        int fileFormat = fbxManager.GetIOPluginRegistry ().FindWriterIDByDescription ("FBX ascii (*.fbx)");
 
                         status = fbxExporter.Initialize (m_tempFilePath, fileFormat, fbxManager.GetIOSettings ());
                         // Check that initialization of the fbxExporter was successful