use properties instead of functions

Author: vkovec

Assets/FbxExporters/Editor/ConvertToPrefabEditorWindow.cs

@@ -61,6 +61,9 @@ protected void SetGameObjectsToConvert(IEnumerable<GameObject> toConvert){
                 } else if (m_toConvert.Length > 1) {
                     m_prefabFileName = "(automatic)";
                 }
+
+                DisableTransferAnim = DisableNameSelection = m_toConvert.Length > 1;
+
                 this.SetFilename (m_prefabFileName);
             }
 
@@ -105,11 +108,6 @@ protected override void Export ()
                 }
             }
 
-            protected override bool DisableNameSelection ()
-            {
-                return m_toConvert.Length > 1;
-            }
-
             protected override void ShowPresetReceiver ()
             {
                 ShowPresetReceiver (ExportSettings.instance.convertToPrefabSettings);
@@ -122,7 +120,7 @@ protected override void CreateCustomUI ()
                     "Prefab Name:",
                     "Filename to save prefab to."),GUILayout.Width(LabelWidth-TextFieldAlignOffset));
 
-                EditorGUI.BeginDisabledGroup (DisableNameSelection());
+                EditorGUI.BeginDisabledGroup (DisableNameSelection);
                 // Show the export name with an uneditable ".prefab" at the end
                 //-------------------------------------
                 EditorGUILayout.BeginVertical ();

Assets/FbxExporters/Editor/ExportModelEditorWindow.cs

@@ -28,6 +28,12 @@ public abstract class ExportOptionsEditorWindow : EditorWindow
 
             protected string m_exportFileName = "";
 
+            private bool m_disableTransferAnim = false;
+            protected bool DisableTransferAnim { get { return m_disableTransferAnim; } set { m_disableTransferAnim = value; } }
+
+            private bool m_disableNameSelection = false;
+            protected bool DisableNameSelection { get { return m_disableNameSelection; } set { m_disableNameSelection = value; } }
+
             protected UnityEditor.Editor m_innerEditor;
             protected FbxExportPresetSelectorReceiver m_receiver;
 
@@ -105,10 +111,6 @@ public void OnPresetSelectionChanged()
             /// </summary>
             protected virtual void CreateCustomUI(){}
 
-            protected virtual bool DisableNameSelection(){
-                return false;
-            }
-
             protected abstract void ShowPresetReceiver ();
 
             protected void ShowPresetReceiver(UnityEngine.Object target){
@@ -141,7 +143,7 @@ protected void OnGUI ()
                     "Export Name:",
                     "Filename to save model to."),GUILayout.Width(LabelWidth-TextFieldAlignOffset));
 
-                EditorGUI.BeginDisabledGroup (DisableNameSelection());
+                EditorGUI.BeginDisabledGroup (DisableNameSelection);
                 // Show the export name with an uneditable ".fbx" at the end
                 //-------------------------------------
                 EditorGUILayout.BeginVertical ();
@@ -202,15 +204,18 @@ protected void OnGUI ()
                 CreateCustomUI();
 
                 EditorGUILayout.Space ();
+
+                EditorGUI.BeginDisabledGroup (DisableTransferAnim);
                 EditorGUI.indentLevel--;
                 GUILayout.BeginHorizontal();
                 EditorGUILayout.LabelField(new GUIContent("Transfer Animation", "Select bone to transfer root motion animation to."), GUILayout.Width(LabelWidth - FieldOffset));
                 GUILayout.EndHorizontal();
                 EditorGUI.indentLevel++;
                 TransferAnimationSource = EditorGUILayout.ObjectField ("Source", TransferAnimationSource, typeof(Transform), allowSceneObjects: true) as Transform;
                 TransferAnimationDest = EditorGUILayout.ObjectField ("Destination", TransferAnimationDest, typeof(Transform), allowSceneObjects: true) as Transform;
-
                 EditorGUILayout.Space ();
+                EditorGUI.EndDisabledGroup ();
+
                 EditorGUI.indentLevel--;
                 m_showOptions = EditorGUILayout.Foldout (m_showOptions, "Options");
                 EditorGUI.indentLevel++;
@@ -266,14 +271,55 @@ public class ExportModelEditorWindow : ExportOptionsEditorWindow
             private UnityEngine.Object[] m_toExport;
 
             private bool m_isTimelineAnim = false;
+            protected bool IsTimelineAnim {
+                get { return m_isTimelineAnim; }
+                set{
+                    m_isTimelineAnim = value;
+                    if (m_isTimelineAnim) {
+                        ExportSettings.instance.exportModelSettings.info.SetModelAnimIncludeOption(ExportSettings.Include.Anim);
+                    }
+                    if (m_innerEditor) {
+                        var exportModelSettingsEditor = m_innerEditor as ExportModelSettingsEditor;
+                        if (exportModelSettingsEditor) {
+                            exportModelSettingsEditor.DisableIncludeDropdown(m_isTimelineAnim);
+                        }
+                    }
+                }
+            }
+
             private bool m_singleHierarchyExport = true;
+            protected bool SingleHierarchyExport {
+                get { return m_singleHierarchyExport; }
+                set {
+                    m_singleHierarchyExport = value;
+
+                    if (m_innerEditor) {
+                        var exportModelSettingsEditor = m_innerEditor as ExportModelSettingsEditor;
+                        if (exportModelSettingsEditor) {
+                            exportModelSettingsEditor.SetIsSingleHierarchy (m_singleHierarchyExport);
+                        }
+                    }
+                }
+            }
+
             private bool m_isPlayableDirector = false;
+            protected bool IsPlayableDirector { 
+                get { return m_isPlayableDirector; } 
+                set {
+                    m_isPlayableDirector = value;
+                    DisableNameSelection = m_isPlayableDirector;
+                }
+            }
 
             protected override Transform TransferAnimationSource {
                 get {
                     return ExportSettings.instance.exportModelSettings.info.AnimationSource;
                 }
                 set {
+                    // source must be ancestor to dest
+
+                    // must be in same hierarchy as selected GO
+
                     ExportSettings.instance.exportModelSettings.info.SetAnimationSource (value);
                 }
             }
@@ -295,9 +341,9 @@ public static void Init (IEnumerable<UnityEngine.Object> toExport, string filena
                     filename = window.GetFilenameFromObjects ();
                 }
                 window.InitializeWindow (filename);
-                window.SetAnimationExportType (isTimelineAnim);
-                window.SetSingleHierarchyExport (numObjects == 1);
-                window.SetIsPlayableDirector (isPlayableDirector);
+                window.IsTimelineAnim = isTimelineAnim;
+                window.SingleHierarchyExport = (numObjects == 1);
+                window.IsPlayableDirector = isPlayableDirector;
                 window.Show ();
             }
 
@@ -311,39 +357,12 @@ protected int SetGameObjectsToExport(IEnumerable<UnityEngine.Object> toExport){
                         TransferAnimationSource = go.transform;
                         TransferAnimationDest = go.transform;
                     }
-                }
+                } 
+                DisableTransferAnim = m_toExport.Length > 1;
 
                 return m_toExport.Length;
             }
 
-            private void SetAnimationExportType(bool isTimelineAnim){
-                m_isTimelineAnim = isTimelineAnim;
-                if (m_isTimelineAnim) {
-                    ExportSettings.instance.exportModelSettings.info.SetModelAnimIncludeOption(ExportSettings.Include.Anim);
-                }
-                if (m_innerEditor) {
-                    var exportModelSettingsEditor = m_innerEditor as ExportModelSettingsEditor;
-                    if (exportModelSettingsEditor) {
-                        exportModelSettingsEditor.DisableIncludeDropdown(m_isTimelineAnim);
-                    }
-                }
-            }
-
-            private void SetSingleHierarchyExport(bool singleHierarchy){
-                m_singleHierarchyExport = singleHierarchy;
-
-                if (m_innerEditor) {
-                    var exportModelSettingsEditor = m_innerEditor as ExportModelSettingsEditor;
-                    if (exportModelSettingsEditor) {
-                        exportModelSettingsEditor.SetIsSingleHierarchy (m_singleHierarchyExport);
-                    }
-                }
-            }
-
-            private void SetIsPlayableDirector(bool isPlayableDirector){
-                m_isPlayableDirector = isPlayableDirector;
-            }
-
             /// <summary>
             /// Gets the filename from objects to export.
             /// </summary>
@@ -364,16 +383,11 @@ protected override void OnEnable ()
                 base.OnEnable ();
                 if (!m_innerEditor) {
                     m_innerEditor = UnityEditor.Editor.CreateEditor (ExportSettings.instance.exportModelSettings);
-                    this.SetSingleHierarchyExport (m_singleHierarchyExport);
-                    this.SetAnimationExportType (m_isTimelineAnim);
+                    this.SingleHierarchyExport = m_singleHierarchyExport;
+                    this.IsTimelineAnim = m_isTimelineAnim;
                 }
             }
 
-            protected override bool DisableNameSelection ()
-            {
-                return m_isPlayableDirector;
-            }
-
             protected override void Export(){
                 var folderPath = ExportSettings.GetFbxAbsoluteSavePath ();
                 var filePath = System.IO.Path.Combine (folderPath, m_exportFileName + ".fbx");
@@ -382,7 +396,7 @@ protected override void Export(){
                     return;
                 }
 
-                if (m_isPlayableDirector) {
+                if (IsPlayableDirector) {
                     foreach (var obj in m_toExport) {
                         var go = ModelExporter.GetGameObject (obj);
                         if (!go) {