code review fixes

Author: vkovec

com.unity.formats.fbx/Editor/FbxPropertyChannelPair.cs

@@ -92,8 +92,8 @@ public PropertyChannelMap(Dictionary<string,string> propertyMap, Dictionary<stri
                 { "field of view", "FieldOfView" },
                 { "m_Weight", "Weight" },
                 { "m_FocalLength", "FocalLength" },
-                {"m_LensShift.x", "FilmOffsetX" },
-                {"m_LensShift.y", "FilmOffsetY" }
+                { "m_LensShift.x", "FilmOffsetX" },
+                { "m_LensShift.y", "FilmOffsetY" }
             };
 
         /// <summary>

com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorder.cs

@@ -16,7 +16,7 @@ protected override void RecordFrame(RecordingSession ctx)
 
         protected override void EndRecording(RecordingSession session)
         {
-            var ars = (FbxRecorderSettings)session.settings;
+            var settings = (FbxRecorderSettings)session.settings;
 
             foreach (var input in m_Inputs)
             {
@@ -28,14 +28,13 @@ protected override void EndRecording(RecordingSession session)
 
                 var clip = new AnimationClip();
 
-                ars.FileNameGenerator.CreateDirectory(session);
+                settings.FileNameGenerator.CreateDirectory(session);
 
-                var absolutePath = FileNameGenerator.SanitizePath(ars.FileNameGenerator.BuildAbsolutePath(session));
+                var absolutePath = FileNameGenerator.SanitizePath(settings.FileNameGenerator.BuildAbsolutePath(session));
                 var clipName = absolutePath.Replace(FileNameGenerator.SanitizePath(Application.dataPath), "Assets");
 
-                //AssetDatabase.CreateAsset(clip, clipName);
 #if UNITY_2018_3_OR_NEWER
-                aInput.GameObjectRecorder.SaveToClip(clip, ars.FrameRate);
+                aInput.GameObjectRecorder.SaveToClip(clip, settings.FrameRate);
 #else
                 aInput.gameObjectRecorder.SaveToClip(clip);
 #endif
@@ -59,7 +58,7 @@ protected override void EndRecording(RecordingSession session)
                 AnimationUtility.SetAnimationClips(animator, new AnimationClip[] { clip });
                 var exportSettings = new ExportModelSettingsSerialize();
                 var toInclude = ExportSettings.Include.ModelAndAnim;
-                if (!ars.ExportGeometry)
+                if (!settings.ExportGeometry)
                 {
                     toInclude = ExportSettings.Include.Anim;
                 } 

com.unity.formats.fbx/package.json

@@ -3,9 +3,9 @@
   "displayName": "FBX Exporter",
   "version": "2.0.3-preview.3",
   "dependencies": {
+    "com.unity.recorder": "2.1.0-preview.1",
     "com.unity.timeline": "1.0.0",
-    "com.autodesk.fbx": "2.0.1-preview.1",
-    "com.unity.recorder": "2.1.0-preview.1"
+    "com.autodesk.fbx": "2.0.1-preview.1"
   },
   "unity": "2018.3",
   "unityRelease": "4f1",