Skip to content

Commit ce9d0ab

Browse files
authored
Merge pull request #516 from Unity-Technologies/UT-3401-fix-failing-blendshape-unit-tests
UT-3401 fix failing blendshape unit tests
2 parents b5b9e2b + 200f05c commit ce9d0ab

File tree

4 files changed

+23
-9
lines changed

4 files changed

+23
-9
lines changed

com.unity.formats.fbx/Tests/FbxTests/ModelExporterTest.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -561,10 +561,18 @@ private string ExportSkinnedMesh(string fileToExport, out SkinnedMeshRenderer or
561561
importer.meshCompression = ModelImporterMeshCompression.Off;
562562
// If either blendshape normals are imported or weldVertices is turned off (or both),
563563
// the vertex count between the original and exported meshes does not match.
564+
// TODO (UT-3410): investigate why the original and exported blendshape normals split the vertices differently.
564565
importer.importBlendShapeNormals = ModelImporterNormals.None;
565566
importer.weldVertices = true;
566567
#else
568+
importer.importBlendShapes = true;
567569
importer.optimizeMesh = false;
570+
importer.meshCompression = ModelImporterMeshCompression.Off;
571+
// If either blendshape normals are imported or weldVertices is turned off (or both),
572+
// the vertex count between the original and exported meshes does not match.
573+
// TODO (UT-3410): investigate why the original and exported blendshape normals split the vertices differently.
574+
importer.importBlendShapeNormals = ModelImporterNormals.None;
575+
importer.weldVertices = true;
568576
#endif // UNITY_2019_1_OR_NEWER
569577
importer.SaveAndReimport();
570578

com.unity.formats.fbx/Tests/Models/blendshape.fbx.meta

Lines changed: 7 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

com.unity.formats.fbx/Tests/Models/blendshape_with_skinning.fbx.meta

Lines changed: 7 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

com.unity.formats.fbx/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "com.unity.formats.fbx",
33
"displayName": "FBX Exporter",
4-
"version": "3.1.0-preview.1",
4+
"version": "3.2.0-preview.1",
55
"dependencies": {
66
"com.unity.recorder": "2.1.0-preview.1",
77
"com.unity.timeline": "1.0.0",

0 commit comments

Comments
 (0)