[CHANGED] added continues in a few places for efficiency

[CHANGED] made it so that we only start up Maya to check the version once per version, for efficiency
[CHANGED] the script will now catch failures of parses from Maya versions without numbers (which is to say LT won't be compared to other versions)
[ADDED] a FindMaxVersion() function so that comparisons wouldn't clutter up other functions (also checks to see if the version could not be parsed)
[UPDATED] IsEarlierThanMax2017() function to use my new FindMaxVersion() function
[FIXED] function summary of FindMostRecentProgram() to correct format

Author: MSI\Austin

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -313,52 +313,56 @@ private static string GetUniqueName(string name){
             return uniqueName;
         }
 
-        // <summary>
-        //
-        // Find the latest program available and make that the default choice.
-        // Will always take any Maya version over any 3ds Max version.
-        //
-        // Returns the position of the most recent program in the list of dccOptionPaths
-        //
-        // </summary>
+        /// <summary>
+        ///
+        /// Find the latest program available and make that the default choice.
+        /// Will always take any Maya version over any 3ds Max version.
+        ///
+        /// Returns the position of the most recent program in the list of dccOptionPaths
+        ///
+        /// </summary>
         public int FindMostRecentProgram()
         {
             int newestMayaVersion = -1;
+            int savedMayaVersionNumber = 0;
             int newestMaxVersion = -1;
 
             for (int i = 0; i < instance.dccOptionPaths.Count; i++)
             {
                 if (instance.dccOptionPaths[i].ToLower().Contains("maya"))
                 {
                     if (newestMayaVersion == -1)
+                    {
                         newestMayaVersion = 0;
+                        savedMayaVersionNumber = int.Parse(AskMayaVersion(instance.dccOptionPaths[i]));
+                        continue;
+                    }
 
                     //Check if the path we are considering is newer than the previously saved one
-                    if (int.Parse(AskMayaVersion(instance.dccOptionPaths[i])) > int.Parse(AskMayaVersion(instance.dccOptionPaths[newestMayaVersion])))
+                    int versionToCheck;
+                    if (int.TryParse(AskMayaVersion(instance.dccOptionPaths[i]), out versionToCheck))
                     {
-                        newestMayaVersion = i;
+                        if (versionToCheck > savedMayaVersionNumber)
+                        {
+                            newestMayaVersion = i;
+                            savedMayaVersionNumber = versionToCheck;
+                        }
                     }
                 }
-                else if (instance.dccOptionPaths[i].ToLower().Contains("max"))
+                else if (instance.dccOptionPaths[i].ToLower().Contains("max") && newestMayaVersion == -1)
                 {
                     if (newestMaxVersion == -1)
+                    {
                         newestMaxVersion = 0;
-
-                    //Isolate the number out of the path we are currently checking
-                    var nameCurrent = Path.GetFileName(Path.GetDirectoryName(instance.dccOptionPaths[i])).ToLower();
-                    nameCurrent = nameCurrent.Replace("3ds max", "").Trim();
-
-                    //Isolate the number out of the path that is the current best answer
-                    var nameNewest = Path.GetFileName(Path.GetDirectoryName(instance.dccOptionPaths[newestMaxVersion])).ToLower();
-                    nameNewest = nameNewest.Replace("3ds max", "").Trim();
+                        continue;
+                    }
 
                     //Check if the path we are considering is newer than the previously saved one
-                    if (int.Parse(nameCurrent) > int.Parse(nameNewest))
+                    if (FindMaxVersion(dccOptionPaths[i]) > FindMaxVersion(dccOptionPaths[newestMaxVersion]))
                     {
                         newestMaxVersion = i;
                     }
 
-
                 }
 
             }
@@ -376,6 +380,28 @@ public int FindMostRecentProgram()
             return 0;
         }
 
+        /// <summary>
+        /// Finds the 3ds Max version based off of the title of the application
+        /// </summary>
+        /// <param name="path"></param>
+        /// <returns> the year/version  OR -1 if the year could not be parsed </returns>
+        private static int FindMaxVersion(string path)
+        {
+            var fileName = Path.GetFileName(Path.GetDirectoryName(path)).ToLower();
+            fileName = fileName.Replace("3ds max", "").Trim();
+
+            int version;
+
+            if (int.TryParse(fileName, out version))
+            {
+                return version;
+            }
+            else
+            {
+                return -1;
+            }
+        }
+
         /// <summary>
         /// Find Maya and 3DsMax installations at default install path.
         /// Add results to given dictionary.
@@ -576,10 +602,8 @@ public static string GetMaxOptionName(string exePath){
         }
 
         public static bool IsEarlierThanMax2017(string exePath){
-            var name = Path.GetFileName (Path.GetDirectoryName (exePath)).ToLower();
-            name = name.Replace ("3ds max", "").Trim();
-            int version;
-            return int.TryParse (name, out version) && version < 2017;
+            int version = FindMaxVersion(exePath);
+            return version != -1 && version < 2017;
         }
 
         public static string GetSelectedDCCPath()