fix binormals export error if normals.length != tangents.length

+ add comparison test

Author: vkovec

Assets/FbxExporters/Editor/FbxExporter.cs

@@ -1430,7 +1430,7 @@ public Vector3 [] Binormals {
                             var normals = Normals;
                             var tangents = Tangents;
 
-                            if (HasValidNormals() && HasValidTangents()) {
+                            if (HasValidNormals() && HasValidTangents() && normals.Length == tangents.Length) {
                                 m_Binormals = new Vector3 [normals.Length];
 
                                 for (int i = 0; i < normals.Length; i++)
@@ -1512,19 +1512,22 @@ public MeshInfo (Mesh mesh, Material[] materials)
                 }
 
                 public bool HasValidNormals(){
-                    return Normals != null && Normals.Length >= 0;
+                    return Normals != null && Normals.Length > 0;
                 }
 
                 public bool HasValidBinormals(){
-                    return HasValidNormals () && HasValidTangents () && Binormals != null;
+                    return HasValidNormals () &&
+                        HasValidTangents () &&
+                        Normals.Length == Tangents.Length &&
+                        Binormals != null;
                 }
 
                 public bool HasValidTangents(){
-                    return Tangents != null && Tangents.Length >= 0;
+                    return Tangents != null && Tangents.Length > 0;
                 }
 
                 public bool HasValidVertexColors(){
-                    return VertexColors != null && VertexColors.Length >= 0;
+                    return VertexColors != null && VertexColors.Length > 0;
                 }
             }
 

Assets/FbxExporters/Editor/UnitTests/ModelExporterTest.cs

@@ -362,13 +362,7 @@ public void TestExportCamera(){
         /// <param name="filename">Filename.</param>
         /// <param name="cameraObj">Camera object.</param>
         private Camera ExportCamera(string filename, GameObject cameraObj){
-            ModelExporter.ExportObject (filename, cameraObj);
-
-            GameObject fbxObj = AssetDatabase.LoadMainAssetAtPath(filename) as GameObject;
-            var fbxCamera = fbxObj.GetComponent<Camera> ();
-
-            Assert.IsNotNull (fbxCamera);
-            return fbxCamera;
+            return ExportComponent<Camera> (filename, cameraObj);
         }
 
         private void CompareCameraValues(Camera camera, Camera fbxCamera, float delta=0.001f){
@@ -378,6 +372,23 @@ private void CompareCameraValues(Camera camera, Camera fbxCamera, float delta=0.
             Assert.AreEqual (camera.farClipPlane, fbxCamera.farClipPlane, delta);
         }
 
+        /// <summary>
+        /// Exports the GameObject and returns component of type T.
+        /// </summary>
+        /// <returns>The component.</returns>
+        /// <param name="filename">Filename.</param>
+        /// <param name="obj">Object.</param>
+        /// <typeparam name="T">The component type.</typeparam>
+        private T ExportComponent<T>(string filename, GameObject obj) where T : Component {
+            ModelExporter.ExportObject (filename, obj);
+
+            GameObject fbxObj = AssetDatabase.LoadMainAssetAtPath(filename) as GameObject;
+            var fbxComponent = fbxObj.GetComponent<T> ();
+
+            Assert.IsNotNull (fbxComponent);
+            return fbxComponent;
+        }
+
         [Test]
         public void TestComponentAttributeExport()
         {
@@ -396,17 +407,55 @@ public void TestComponentAttributeExport()
 
             mesh.vertices = quadMesh.vertices;
             mesh.triangles = quadMesh.triangles;
+            mesh.tangents = quadMesh.tangents;
             mesh.normals = quadMesh.normals;
             mesh.colors = quadMesh.colors;
 
+            Assert.IsNotNull (mesh.tangents);
+            Assert.IsNotNull (mesh.vertices);
+            Assert.IsNotNull (mesh.triangles);
+            Assert.IsNotNull (mesh.normals);
+            Assert.IsNotNull (mesh.colors);
+
             var gameObject = new GameObject ();
             var meshFilter = gameObject.AddComponent<MeshFilter> ();
-            gameObject.AddComponent<MeshRenderer> ();
 
             meshFilter.sharedMesh = mesh;
 
             // don't need quad anymore
             Object.DestroyImmediate(quad);
+
+            // try exporting default values
+            string filename = GetRandomFbxFilePath();
+            var fbxMeshFilter = ExportComponent<MeshFilter> (filename, gameObject);
+            var fbxMesh = fbxMeshFilter.sharedMesh;
+            CompareMeshComponentAttributes (mesh, fbxMesh);
+
+            // try exporting mesh without vertex colors
+            mesh.colors = new Color[]{ };
+
+            filename = GetRandomFbxFilePath();
+            fbxMeshFilter = ExportComponent<MeshFilter> (filename, gameObject);
+            fbxMesh = fbxMeshFilter.sharedMesh;
+            CompareMeshComponentAttributes (mesh, fbxMesh);
+
+            Object.DestroyImmediate (mesh);
+        }
+
+        private void CompareMeshComponentAttributes(Mesh mesh, Mesh fbxMesh)
+        {
+            Assert.IsNotNull (fbxMesh);
+            Assert.IsNotNull (fbxMesh.vertices);
+            Assert.IsNotNull (fbxMesh.triangles);
+            Assert.IsNotNull (fbxMesh.normals);
+            Assert.IsNotNull (fbxMesh.colors);
+            Assert.IsNotNull (fbxMesh.tangents);
+
+            Assert.AreEqual (mesh.vertices, fbxMesh.vertices);
+            Assert.AreEqual (mesh.triangles, fbxMesh.triangles);
+            Assert.AreEqual (mesh.normals, fbxMesh.normals);
+            Assert.AreEqual (mesh.colors, fbxMesh.colors);
+            Assert.AreEqual (mesh.tangents, fbxMesh.tangents);
         }
     }
 }