Ut 3710 fix export settings presets not working (#542)

* fix export settings not getting serialized to preset

* add unit test for presets

* update changelog

Author: vkovec

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changes in Fbx Exporter
 
+## [UNRELEASED] - 2020-09-29
+### Fixed
+- Fix Export Model and Convert to Prefab Variant setting presets not serializing settings properly.
+
 ## [3.2.1-preview.2] - 2020-08-05
 ### Added
 - Add an export option to preserve model import settings when overwriting an fbx file.

com.unity.formats.fbx/Editor/ExportModelSettings.cs

@@ -123,8 +123,10 @@ internal interface IExportOptions {
 
     internal abstract class ExportOptionsSettingsBase<T> : ScriptableObject where T : ExportOptionsSettingsSerializeBase, new()
     {
+        [SerializeField]
         private T m_info = new T();
-        public T info {
+        public T info
+        {
             get { return m_info; }
             set { m_info = value; }
         }

com.unity.formats.fbx/Tests/FbxTests/FbxExportSettingsTest.cs

@@ -3,6 +3,7 @@
 using System.Collections.Generic;
 using UnityEditor.Formats.Fbx.Exporter;
 using NUnit.Framework;
+using UnityEditor.Presets;
 
 namespace FbxExporter.UnitTests
 {
@@ -490,5 +491,36 @@ private void TestLocations(Dictionary<string,List<string>> data)
             }
         }
 
+        [Test]
+        public void TestExportSettingsPresets()
+        {
+            // make sure that the export settings exist
+            ExportSettings.instance.LoadDefaults();
+
+            var exportModelSettings = ExportSettings.instance.ExportModelSettings;
+            var convertPrefabSettings = ExportSettings.instance.ConvertToPrefabSettings;
+
+            // test ExportModelSettings preset
+            exportModelSettings.info.SetExportFormat(ExportSettings.ExportFormat.Binary);
+            Assert.That(exportModelSettings.info.ExportFormat, Is.EqualTo(ExportSettings.ExportFormat.Binary));
+
+            var exportModelPreset = new Preset(exportModelSettings);
+            exportModelSettings.info.SetExportFormat(ExportSettings.ExportFormat.ASCII);
+            Assert.That(exportModelSettings.info.ExportFormat, Is.EqualTo(ExportSettings.ExportFormat.ASCII));
+
+            exportModelPreset.ApplyTo(exportModelSettings);
+            Assert.That(exportModelSettings.info.ExportFormat, Is.EqualTo(ExportSettings.ExportFormat.Binary));
+
+            // test ConvertToPrefabSettings preset
+            convertPrefabSettings.info.SetExportFormat(ExportSettings.ExportFormat.Binary);
+            Assert.That(convertPrefabSettings.info.ExportFormat, Is.EqualTo(ExportSettings.ExportFormat.Binary));
+
+            var convertPrefabPreset = new Preset(convertPrefabSettings);
+            convertPrefabSettings.info.SetExportFormat(ExportSettings.ExportFormat.ASCII);
+            Assert.That(convertPrefabSettings.info.ExportFormat, Is.EqualTo(ExportSettings.ExportFormat.ASCII));
+
+            convertPrefabPreset.ApplyTo(convertPrefabSettings);
+            Assert.That(convertPrefabSettings.info.ExportFormat, Is.EqualTo(ExportSettings.ExportFormat.Binary));
+        }
     }
 }