Skip to content

Commit e69e071

Browse files
committed
code review fixes
-replace FbxExporter with variable in logs -put back *. for finding fbxsdk package
1 parent 1ed1ee6 commit e69e071

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

Assets/FbxExporters/Editor/FbxExporter.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ public class ModelExporter : System.IDisposable
5252

5353
const int UnitScaleFactor = 100;
5454

55+
public const string PACKAGE_UI_NAME = "FBX Exporter";
56+
5557
/// <summary>
5658
/// Create instance of exporter.
5759
/// </summary>
@@ -1005,7 +1007,7 @@ public int ExportAll (IEnumerable<UnityEngine.Object> unityExportSet)
10051007
fbxSceneInfo.mRevision = "1.0";
10061008
fbxSceneInfo.mKeywords = Keywords;
10071009
fbxSceneInfo.mComment = Comments;
1008-
fbxSceneInfo.Original_ApplicationName.Set("Unity FbxExporter Plugin");
1010+
fbxSceneInfo.Original_ApplicationName.Set(string.Format("Unity {0} Plugin", PACKAGE_UI_NAME));
10091011
// set last saved to be the same as original, as this is a new file.
10101012
fbxSceneInfo.LastSaved_ApplicationName.Set(fbxSceneInfo.Original_ApplicationName.Get());
10111013

@@ -1180,7 +1182,7 @@ public static bool OnValidateMenuItem ()
11801182
public static void DisplayNoSelectionDialog()
11811183
{
11821184
UnityEditor.EditorUtility.DisplayDialog (
1183-
"Fbx Exporter Warning",
1185+
string.Format("{0} Warning", PACKAGE_UI_NAME),
11841186
"No GameObjects selected for export.",
11851187
"Ok");
11861188
}

Assets/FbxExporters/Editor/FbxPrefabAutoUpdater.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public static string FindFbxPrefabAssetPath()
3939
return path;
4040
}
4141
}
42-
Debug.LogError("FbxPrefab.cs not found; are you trying to uninstall FbxExporters?");
42+
Debug.LogError(string.Format("{0} not found; are you trying to uninstall {1}?", FBX_PREFAB_FILE.Substring(1), FbxExporters.Editor.ModelExporter.PACKAGE_UI_NAME));
4343
return "";
4444
}
4545

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ if (NOT DEFINED FBXSDK_PACKAGE_PATH)
3737
set(FBXSDK_PACKAGE_PATH "${CMAKE_SOURCE_DIR}/../FbxSharpBuild")
3838

3939
# find the most recent package at the path
40-
file(GLOB FBXSDK_PACKAGES "${FBXSDK_PACKAGE_PATH}/FbxSdk_*.*.unitypackage")
40+
file(GLOB FBXSDK_PACKAGES "${FBXSDK_PACKAGE_PATH}/FbxSdk_*.*.*.unitypackage")
4141
set(NEWEST_PACKAGE "")
4242
foreach(fbxsdk_package ${FBXSDK_PACKAGES})
4343
if(fbxsdk_package IS_NEWER_THAN NEWEST_PACKAGE)

0 commit comments

Comments
 (0)