Skip to content

Commit f389d7e

Browse files
committed
code review fixes
- remove .pyc files before packaging - gitignore integrations.zip - remove .exe so 7zip runs on mac
1 parent 893674f commit f389d7e

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
[Bb]in/
1111
[Dd]ebug/
1212

13+
[Aa]ssets/FbxExporters/unityoneclick_for_maya.zip
14+
1315
# vim temp files
1416
*.swp
1517
*.swo

Assets/FbxExporters/Editor/InstallIntegration.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,7 @@ public static void DecompressZip(string zipPath, string destPath){
528528
System.Diagnostics.Process myProcess = new System.Diagnostics.Process();
529529
var ZIPAPP = "7z.exe";
530530
#if UNITY_EDITOR_OSX
531-
ZIPAPP = "7za.exe";
531+
ZIPAPP = "7za";
532532
#endif
533533
myProcess.StartInfo.FileName = EditorApplication.applicationContentsPath + "/Tools/" + ZIPAPP;
534534
myProcess.StartInfo.WindowStyle = System.Diagnostics.ProcessWindowStyle.Hidden;

CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,9 @@ set(MAYA_INTEGRATION_ZIP_NAME "unityoneclick_for_maya.zip")
9090

9191
# remove existing zip file
9292
file(REMOVE "${CMAKE_SOURCE_DIR}/Assets/FbxExporters/${MAYA_INTEGRATION_ZIP_NAME}")
93+
# remove .pyc files that we don't want to ship
94+
file(GLOB PYC_FILES "${CMAKE_SOURCE_DIR}/Assets/Integrations/Autodesk/maya/scripts/unityOneClick/*.pyc")
95+
file(REMOVE ${PYC_FILES})
9396

9497
add_custom_command(OUTPUT ${MAYA_INTEGRATION_ZIP_NAME}
9598
COMMAND ${CMAKE_COMMAND} -E tar "cfv" ${CMAKE_SOURCE_DIR}/Assets/FbxExporters/${MAYA_INTEGRATION_ZIP_NAME} --format=zip

0 commit comments

Comments
 (0)