code review fixes

-use streamreader/streamwriter in a "using" block
-get temp file using Path.GetTempFileName()

Author: vkovec

Assets/FbxExporters/Editor/FbxExporterRepairMissingScripts.cs

@@ -68,44 +68,46 @@ private static bool ReplaceGUIDInFile (string path)
             bool modified = false;
 
             try {
-                var sr = new StreamReader (path);
-
-                // verify that this is a text file
-                var firstLine = "";
-                if (sr.Peek () > -1) {
-                    firstLine = sr.ReadLine ();
-                    if (!firstLine.StartsWith ("%YAML")) {
-                        sr.Close ();
-                        return false;
-                    }
+                var tmpFile = Path.GetTempFileName();
+                if(string.IsNullOrEmpty(tmpFile)){
+                    return false;
                 }
 
-                var sw = new StreamWriter (path + ".remap", false);
+                using(var sr = new StreamReader (path)){
+                    // verify that this is a text file
+                    var firstLine = "";
+                    if (sr.Peek () > -1) {
+                        firstLine = sr.ReadLine ();
+                        if (!firstLine.StartsWith ("%YAML")) {
+                            sr.Close ();
+                            return false;
+                        }
+                    }
 
-                if (!string.IsNullOrEmpty (firstLine)) {
-                    sw.WriteLine (firstLine);
-                }
+                    using(var sw = new StreamWriter (tmpFile, false)){
+                        if (!string.IsNullOrEmpty (firstLine)) {
+                            sw.WriteLine (firstLine);
+                        }
 
-                while (sr.Peek () > -1) {
-                    var line = sr.ReadLine ();
+                        while (sr.Peek () > -1) {
+                            var line = sr.ReadLine ();
 
-                    if (line.Contains (ForumPackageSearchID)) {
-                        line = line.Replace (ForumPackageSearchID, CurrentPackageSearchID);
-                        modified |= true;
-                    }
+                            if (line.Contains (ForumPackageSearchID)) {
+                                line = line.Replace (ForumPackageSearchID, CurrentPackageSearchID);
+                                modified |= true;
+                            }
 
-                    sw.WriteLine (line);
+                            sw.WriteLine (line);
+                        }
+                    }
                 }
 
-                sr.Close ();
-                sw.Close ();
-
                 if (modified) {
                     File.Delete (path);
-                    File.Move (path + ".remap", path);
+                    File.Move (tmpFile, path);
                     return true;
                 } else {
-                    File.Delete (path + ".remap");
+                    File.Delete (tmpFile);
                 }
             } catch (IOException e) {
                 Debug.LogError (string.Format ("Failed to replace GUID in file {0} (error={1})", path, e));