Fix FDG warning - unused parameter

vkovec · vkovec · commit f6c2ae4f1915 · 2020-10-16T14:03:17.000-04:00
+ update ruleset
diff --git a/com.unity.formats.fbx/Editor/FbxExportSettings.cs b/com.unity.formats.fbx/Editor/FbxExportSettings.cs
@@ -505,7 +505,7 @@ internal ExportSettings()
             }
         }
 
-        internal void Save(bool saveAsText)
+        internal void SaveToFile()
         {
             if (s_Instance == null)
             {
@@ -1739,7 +1739,7 @@ internal void Save()
         {
             exportModelSettingsSerialize = ExportModelSettings.info;
             convertToPrefabSettingsSerialize = ConvertToPrefabSettings.info;
-            this.Save (true);
+            this.SaveToFile ();
         }
     }
 
diff --git a/fdgRulesets/Unity.ruleset b/fdgRulesets/Unity.ruleset
@@ -11,6 +11,7 @@
     <Rule Id="CA1017" Action="None" />
     <Rule Id="CA1026" Action="None" />
     <Rule Id="CA1031" Action="None" />
+    <Rule Id="CA1045" Action="None" />
     <Rule Id="CA1405" Action="None" />
     <Rule Id="CA1500" Action="None" />
     <Rule Id="CA1502" Action="None" />
@@ -27,6 +28,7 @@
     <Rule Id="CA1811" Action="None" />
     <Rule Id="CA1823" Action="None" />
     <Rule Id="CA1900" Action="None" />
+    <Rule Id="CA2122" Action="None" />
     <Rule Id="CA2204" Action="None" />
     <Rule Id="CA2211" Action="None" />
     <Rule Id="CA2235" Action="None" />

Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,7 @@ internal ExportSettings()`
`505`	`505`	`}`
`506`	`506`	`}`
`507`	`507`
`508`		`- internal void Save(bool saveAsText)`
	`508`	`+ internal void SaveToFile()`
`509`	`509`	`{`
`510`	`510`	`if (s_Instance == null)`
`511`	`511`	`{`
`@@ -1739,7 +1739,7 @@ internal void Save()`
`1739`	`1739`	`{`
`1740`	`1740`	`exportModelSettingsSerialize = ExportModelSettings.info;`
`1741`	`1741`	`convertToPrefabSettingsSerialize = ConvertToPrefabSettings.info;`
`1742`		`- this.Save (true);`
	`1742`	`+ this.SaveToFile ();`
`1743`	`1743`	`}`
`1744`	`1744`	`}`
`1745`	`1745`