Code Review Comments

MarcShakour · MarcShakour · commit f7bf797a3b93 · 2018-01-09T16:31:46.000-05:00
diff --git a/Assets/FbxExporters/FbxPrefab.cs b/Assets/FbxExporters/FbxPrefab.cs
@@ -27,7 +27,8 @@ public class FbxPrefab : MonoBehaviour
         [System.Serializable]
         public struct StringPair { public string FBXObjectName; public string UnityObjectName; }
 
-        public StringPair[] m_nameMapping;
+        [SerializeField]
+        StringPair[] m_nameMapping;
 
         /// <summary>
         /// Which FBX file does this refer to?
@@ -58,10 +59,6 @@ public StringPair[] NameMapping
             {
                 return m_nameMapping;
             }
-            set
-            {
-                m_nameMapping = value;
-            }
         }
 
         public GameObject FbxModel {

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,8 @@ public class FbxPrefab : MonoBehaviour`
`27`	`27`	`[System.Serializable]`
`28`	`28`	`public struct StringPair { public string FBXObjectName; public string UnityObjectName; }`
`29`	`29`
`30`		`- public StringPair[] m_nameMapping;`
	`30`	`+ [SerializeField]`
	`31`	`+ StringPair[] m_nameMapping;`
`31`	`32`
`32`	`33`	`/// <summary>`
`33`	`34`	`/// Which FBX file does this refer to?`
`@@ -58,10 +59,6 @@ public StringPair[] NameMapping`
`58`	`59`	`{`
`59`	`60`	`return m_nameMapping;`
`60`	`61`	`}`
`61`		`- set`
`62`		`- {`
`63`		`- m_nameMapping = value;`
`64`		`- }`
`65`	`62`	`}`
`66`	`63`
`67`	`64`	`public GameObject FbxModel {`