code review fixes

return FbxDouble3 instead of Vector3

Author: vkovec

Assets/FbxExporters/Editor/FbxExporter.cs

@@ -504,15 +504,23 @@ meshInfo.Vertices [v].z*UnitScaleFactor
 
             /// <summary>
             /// Takes a Quaternion and returns a Euler with XYZ rotation order.
+            /// Also converts from left (Unity) to righthanded (Maya) coordinates.
+            /// 
+            /// Note: Cannot simply use the FbxQuaternion.DecomposeSphericalXYZ()
+            ///       function as this returns the angle in spherical coordinates 
+            ///       instead of Euler angles, which Maya does not import properly. 
             /// </summary>
             /// <returns>Euler with XYZ rotation order.</returns>
-            public static Vector3 QuaternionToXYZEuler(Quaternion q)
+            public static FbxDouble3 QuaternionToXYZEuler(Quaternion q)
             {
                 FbxQuaternion quat = new FbxQuaternion (q.x, q.y, q.z, q.w);
                 FbxAMatrix m = new FbxAMatrix ();
                 m.SetQ (quat);
                 var vector4 = m.GetR ();
-                var result = new Vector3 ((float)vector4.X, (float)vector4.Y, (float)vector4.Z);
+
+                // Negate the y and z values of the rotation to convert 
+                // from Unity to Maya coordinates (left to righthanded).
+                var result = new FbxDouble3 (vector4.X, -vector4.Y, -vector4.Z);
 
                 return result;
             }
@@ -527,13 +535,13 @@ protected void ExportTransform (UnityEngine.Transform unityTransform, FbxNode fb
                 fbxNode.SetRotationOrder (FbxNode.EPivotSet.eSourcePivot, FbxEuler.EOrder.eOrderXYZ);
 
                 UnityEngine.Vector3 unityTranslate;
-                UnityEngine.Vector3 unityRotate;
+                FbxDouble3 unityRotate;
                 UnityEngine.Vector3 unityScale;
 
                 switch (exportType) {
                 case TransformExportType.Zeroed:
                     unityTranslate = Vector3.zero;
-                    unityRotate = Vector3.zero;
+                    unityRotate = new FbxDouble3 (0);
                     unityScale = Vector3.one;
                     break;
                 case TransformExportType.Global:
@@ -549,15 +557,15 @@ protected void ExportTransform (UnityEngine.Transform unityTransform, FbxNode fb
                 }
 
                 // transfer transform data from Unity to Fbx
-                // Negating the x value of the translation, and the y and z values of the rotation
-                // to convert from Unity to Maya coordinates (left to righthanded).
+                // Negating the x value of the translation to convert from Unity
+                // to Maya coordinates (left to righthanded).
                 // Scaling the translation by 100 to convert from m to cm.
                 var fbxTranslate = new FbxDouble3 (
                     -unityTranslate.x*UnitScaleFactor,
                     unityTranslate.y*UnitScaleFactor,
                     unityTranslate.z*UnitScaleFactor
                 );
-                var fbxRotate = new FbxDouble3 (unityRotate.x, -unityRotate.y, -unityRotate.z);
+                var fbxRotate = unityRotate;
                 var fbxScale = new FbxDouble3 (unityScale.x, unityScale.y, unityScale.z);
 
                 // set the local position of fbxNode