Skip to content

Commit 74e4a20

Browse files
sailroGitHub Enterprise
authored andcommitted
Merge pull request #183 from unity/generator-style
Add UnityProjectGeneratorStyle to Telemetry properties
2 parents e305c3c + 8b7fb84 commit 74e4a20

File tree

4 files changed

+9
-1
lines changed

4 files changed

+9
-1
lines changed

Packages/com.unity.ide.visualstudio.tests/Tests/Editor/CSProjectTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ public void DefaultSyncSettings_WhenSynced_CreatesProjectFileFromDefaultTemplate
173173
" <ProjectTypeGuids>{E097FAD1-6243-4DAD-9C02-E9B9EFC3FFC1};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>",
174174
" <UnityProjectGenerator>Package</UnityProjectGenerator>",
175175
$" <UnityProjectGeneratorVersion>{packageVersion}</UnityProjectGeneratorVersion>",
176+
" <UnityProjectGeneratorStyle>Legacy</UnityProjectGeneratorStyle>",
176177
$" <UnityProjectType>{buildTarget}</UnityProjectType>",
177178
$" <UnityBuildTarget>{EditorUserBuildSettings.activeBuildTarget + ":" + (int)EditorUserBuildSettings.activeBuildTarget}</UnityBuildTarget>",
178179
$" <UnityVersion>{unityVersion}</UnityVersion>",

Packages/com.unity.ide.visualstudio/Editor/ProjectGeneration/LegacyStyleProjectGeneration.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ namespace Microsoft.Unity.VisualStudio.Editor
1212

1313
internal class LegacyStyleProjectGeneration : ProjectGeneration
1414
{
15+
internal override string StyleName => "Legacy";
16+
1517
public LegacyStyleProjectGeneration(string tempDirectory, IAssemblyNameProvider assemblyNameProvider, IFileIO fileIoProvider, IGUIDGenerator guidGenerator) : base(tempDirectory, assemblyNameProvider, fileIoProvider, guidGenerator)
1618
{
1719
}

Packages/com.unity.ide.visualstudio/Editor/ProjectGeneration/ProjectGeneration.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,8 @@ public ProjectGeneration(string tempDirectory, IAssemblyNameProvider assemblyNam
8787
SetupProjectSupportedExtensions();
8888
}
8989

90+
internal virtual string StyleName => "";
91+
9092
/// <summary>
9193
/// Syncs the scripting solution if any affected files are relevant.
9294
/// </summary>
@@ -824,7 +826,7 @@ internal static void GetProjectHeaderAnalyzers(ProjectProperties properties, Str
824826
}
825827
}
826828

827-
internal static void GetProjectHeaderVstuFlavoring(ProjectProperties properties, StringBuilder headerBuilder, bool includeProjectTypeGuids = true)
829+
internal void GetProjectHeaderVstuFlavoring(ProjectProperties properties, StringBuilder headerBuilder, bool includeProjectTypeGuids = true)
828830
{
829831
// Flavoring
830832
headerBuilder.Append(@" <PropertyGroup>").Append(k_WindowsNewline);
@@ -836,6 +838,7 @@ internal static void GetProjectHeaderVstuFlavoring(ProjectProperties properties,
836838

837839
headerBuilder.Append(@" <UnityProjectGenerator>Package</UnityProjectGenerator>").Append(k_WindowsNewline);
838840
headerBuilder.Append(@" <UnityProjectGeneratorVersion>").Append(properties.FlavoringPackageVersion).Append(@"</UnityProjectGeneratorVersion>").Append(k_WindowsNewline);
841+
headerBuilder.Append(@" <UnityProjectGeneratorStyle>").Append(StyleName).Append("</UnityProjectGeneratorStyle>").Append(k_WindowsNewline);
839842
headerBuilder.Append(@" <UnityProjectType>").Append(properties.FlavoringProjectType).Append(@"</UnityProjectType>").Append(k_WindowsNewline);
840843
headerBuilder.Append(@" <UnityBuildTarget>").Append(properties.FlavoringBuildTarget).Append(@"</UnityBuildTarget>").Append(k_WindowsNewline);
841844
headerBuilder.Append(@" <UnityVersion>").Append(properties.FlavoringUnityVersion).Append(@"</UnityVersion>").Append(k_WindowsNewline);

Packages/com.unity.ide.visualstudio/Editor/ProjectGeneration/SdkStyleProjectGeneration.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ namespace Microsoft.Unity.VisualStudio.Editor
1313
{
1414
internal class SdkStyleProjectGeneration : ProjectGeneration
1515
{
16+
internal override string StyleName => "SDK";
17+
1618
internal class SdkStyleAssemblyNameProvider : AssemblyNameProvider
1719
{
1820
// disable PlayerGeneration with SdkStyle projects

0 commit comments

Comments
 (0)