Normalize bin folder

Author: sailro

Packages/com.unity.ide.visualstudio.tests/Tests/Editor/AssemblyNameProviderTests.cs

@@ -30,11 +30,11 @@ public void SetUp()
 			m_AssemblyNameProvider.ResetProjectGenerationFlag();
 		}
 
-		[TestCase(@"Temp\Bin\Debug\", "AssemblyName", "AssemblyName")]
-		[TestCase(@"Temp\Bin\Debug\", "My.Player.AssemblyName", "My.Player.AssemblyName")]
-		[TestCase(@"Temp\Bin\Debug\", "AssemblyName.Player", "AssemblyName.Player")]
-		[TestCase(@"Temp\Bin\Debug\Player\", "AssemblyName", "AssemblyName.Player")]
-		[TestCase(@"Temp\Bin\Debug\Player\", "AssemblyName.Player", "AssemblyName.Player.Player")]
+		[TestCase(@"Temp\bin\Debug\", "AssemblyName", "AssemblyName")]
+		[TestCase(@"Temp\bin\Debug\", "My.Player.AssemblyName", "My.Player.AssemblyName")]
+		[TestCase(@"Temp\bin\Debug\", "AssemblyName.Player", "AssemblyName.Player")]
+		[TestCase(@"Temp\bin\Debug\Player\", "AssemblyName", "AssemblyName.Player")]
+		[TestCase(@"Temp\bin\Debug\Player\", "AssemblyName.Player", "AssemblyName.Player.Player")]
 		public void GetOutputPath_ReturnsPlayerAndeditorOutputPath(string assemblyOutputPath, string assemblyName, string expectedAssemblyName)
 		{
 			Assert.AreEqual(expectedAssemblyName, m_AssemblyNameProvider.GetAssemblyName(assemblyOutputPath, assemblyName));
@@ -49,7 +49,7 @@ public void AllEditorAssemblies_AreCollected()
 
 			foreach (Assembly editorAssembly in editorAssemblies)
 			{
-				Assert.IsTrue(collectedAssemblies.Any(assembly => assembly.name == editorAssembly.name && assembly.outputPath == @"Temp\Bin\Debug\"), $"{editorAssembly.name}: was not found in collection.");
+				Assert.IsTrue(collectedAssemblies.Any(assembly => assembly.name == editorAssembly.name && assembly.outputPath == @"Temp\bin\Debug\"), $"{editorAssembly.name}: was not found in collection.");
 			}
 		}
 
@@ -91,7 +91,7 @@ public void PlayerAssemblies_AreNotCollected_BeforeToggling()
 
 			foreach (Assembly playerAssembly in playerAssemblies)
 			{
-				Assert.IsFalse(collectedAssemblies.Any(assembly => assembly.name == playerAssembly.name && assembly.outputPath == @"Temp\Bin\Debug\Player\"), $"{playerAssembly.name}: was found in collection.");
+				Assert.IsFalse(collectedAssemblies.Any(assembly => assembly.name == playerAssembly.name && assembly.outputPath == @"Temp\bin\Debug\Player\"), $"{playerAssembly.name}: was found in collection.");
 			}
 		}
 
@@ -106,7 +106,7 @@ public void AllPlayerAssemblies_AreCollected_AfterToggling()
 
 			foreach (Assembly playerAssembly in playerAssemblies)
 			{
-				Assert.IsTrue(collectedAssemblies.Any(assembly => assembly.name == playerAssembly.name && assembly.outputPath == @"Temp\Bin\Debug\Player\"), $"{playerAssembly.name}: was not found in collection.");
+				Assert.IsTrue(collectedAssemblies.Any(assembly => assembly.name == playerAssembly.name && assembly.outputPath == @"Temp\bin\Debug\Player\"), $"{playerAssembly.name}: was not found in collection.");
 			}
 		}
 

Packages/com.unity.ide.visualstudio/Editor/ProjectGeneration/AssemblyNameProvider.cs

@@ -63,13 +63,13 @@ public string GetAssemblyNameFromScriptPath(string path)
 
 		public IEnumerable<Assembly> GetAssemblies(Func<string, bool> shouldFileBePartOfSolution)
 		{
-			IEnumerable<Assembly> assemblies = GetAssembliesByType(AssembliesType.Editor, shouldFileBePartOfSolution, @"Temp\Bin\Debug\");
+			IEnumerable<Assembly> assemblies = GetAssembliesByType(AssembliesType.Editor, shouldFileBePartOfSolution, @"Temp\bin\Debug\");
 
 			if (!ProjectGenerationFlag.HasFlag(ProjectGenerationFlag.PlayerAssemblies))
 			{
 				return assemblies;
 			}
-			var playerAssemblies = GetAssembliesByType(AssembliesType.Player, shouldFileBePartOfSolution, @"Temp\Bin\Debug\Player\");
+			var playerAssemblies = GetAssembliesByType(AssembliesType.Player, shouldFileBePartOfSolution, @"Temp\bin\Debug\Player\");
 			return assemblies.Concat(playerAssemblies);
 		}
 
@@ -98,7 +98,8 @@ private static IEnumerable<Assembly> GetAssembliesByType(AssembliesType type, Fu
 
 		public string GetCompileOutputPath(string assemblyName)
 		{
-			return assemblyName.EndsWith(".Player", StringComparison.Ordinal) ? @"Temp\Bin\Debug\Player\" : @"Temp\Bin\Debug\";
+			// We need to keep this one for API surface check (AssemblyNameProvider is public), but not used anymore
+			throw new NotImplementedException();
 		}
 
 		public IEnumerable<string> GetAllAssetPaths()