Skip to content

Commit 37bf0fb

Browse files
committed
Couple for static turned into instance methods
1 parent ccdfd5d commit 37bf0fb

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

com.unity.mobile.notifications/Runtime/Android/Plugins/com/unity/androidnotifications/UnityNotificationManager.java

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ protected void performNotificationScheduling(int id, Notification.Builder notifi
347347
}
348348

349349
if (fireNow) {
350-
Notification notification = buildNotificationForSending(mContext, mOpenActivity, notificationBuilder);
350+
Notification notification = buildNotificationForSending(mOpenActivity, notificationBuilder);
351351
notify(id, notification);
352352
}
353353
}
@@ -385,29 +385,29 @@ static void scheduleAlarmWithNotification(Notification.Builder notificationBuild
385385
scheduleAlarmWithNotification(context, openActivity, notificationBuilder, intent, fireTime);
386386
}
387387

388-
protected static Notification buildNotificationForSending(Context context, Class openActivity, Notification.Builder builder) {
388+
private Notification buildNotificationForSending(Class openActivity, Notification.Builder builder) {
389389
int id = builder.getExtras().getInt(KEY_ID, -1);
390-
Intent openAppIntent = buildOpenAppIntent(context, openActivity);
390+
Intent openAppIntent = buildOpenAppIntent(openActivity);
391391
openAppIntent.putExtra(KEY_NOTIFICATION_ID, id);
392-
PendingIntent pendingIntent = getActivityPendingIntent(context, id, openAppIntent, 0);
392+
PendingIntent pendingIntent = getActivityPendingIntent(mContext, id, openAppIntent, 0);
393393
builder.setContentIntent(pendingIntent);
394394

395395
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
396396
// Can't check StatusBar notifications pre-M, so ask to be notified when dismissed
397-
Intent deleteIntent = new Intent(context, UnityNotificationManager.class);
397+
Intent deleteIntent = new Intent(mContext, UnityNotificationManager.class);
398398
deleteIntent.setAction(KEY_NOTIFICATION_DISMISSED); // need action to distinguish intent from content one
399399
deleteIntent.putExtra(KEY_NOTIFICATION_DISMISSED, id);
400-
PendingIntent deletePending = getBroadcastPendingIntent(context, id, deleteIntent, 0);
400+
PendingIntent deletePending = getBroadcastPendingIntent(mContext, id, deleteIntent, 0);
401401
builder.setDeleteIntent(deletePending);
402402
}
403403

404-
finalizeNotificationForDisplay(context, builder);
404+
finalizeNotificationForDisplay(builder);
405405
return builder.build();
406406
}
407407

408408
// Build an Intent to open the given activity with the data from input Intent.
409-
protected static Intent buildOpenAppIntent(Context context, Class className) {
410-
Intent openAppIntent = new Intent(context, className);
409+
private Intent buildOpenAppIntent(Class className) {
410+
Intent openAppIntent = new Intent(mContext, className);
411411
openAppIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_SINGLE_TOP);
412412

413413
return openAppIntent;
@@ -682,7 +682,7 @@ public void onReceive(Intent intent) {
682682
}
683683

684684
id = builder.getExtras().getInt(KEY_ID, -1);
685-
notif = buildNotificationForSending(mContext, openActivity, builder);
685+
notif = buildNotificationForSending(openActivity, builder);
686686
}
687687

688688
if (notif != null) {
@@ -731,17 +731,17 @@ public static int getNotificationGroupAlertBehavior(Notification notification) {
731731
return 0;
732732
}
733733

734-
public static void finalizeNotificationForDisplay(Context context, Notification.Builder notificationBuilder) {
734+
private void finalizeNotificationForDisplay(Notification.Builder notificationBuilder) {
735735
String icon = notificationBuilder.getExtras().getString(KEY_SMALL_ICON);
736-
int iconId = UnityNotificationUtilities.findResourceIdInContextByName(context, icon);
736+
int iconId = UnityNotificationUtilities.findResourceIdInContextByName(mContext, icon);
737737
if (iconId == 0) {
738-
iconId = context.getApplicationInfo().icon;
738+
iconId = mContext.getApplicationInfo().icon;
739739
}
740740
notificationBuilder.setSmallIcon(iconId);
741741
icon = notificationBuilder.getExtras().getString(KEY_LARGE_ICON);
742-
iconId = UnityNotificationUtilities.findResourceIdInContextByName(context, icon);
742+
iconId = UnityNotificationUtilities.findResourceIdInContextByName(mContext, icon);
743743
if (iconId != 0) {
744-
notificationBuilder.setLargeIcon(BitmapFactory.decodeResource(context.getResources(), iconId));
744+
notificationBuilder.setLargeIcon(BitmapFactory.decodeResource(mContext.getResources(), iconId));
745745
}
746746
}
747747

0 commit comments

Comments
 (0)