Refactor meta data retrieval to separate method

Author: aurimasc

com.unity.mobile.notifications/Runtime/Android/Plugins/com/unity/androidnotifications/UnityNotificationManager.java

@@ -12,7 +12,6 @@
 import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
-import android.content.pm.ApplicationInfo;
 import android.content.pm.PackageManager;
 import android.content.SharedPreferences;
 import android.graphics.BitmapFactory;
@@ -87,30 +86,25 @@ private void initialize(Activity activity, NotificationCallback notificationCall
         if (mVisibleNotifications == null)
             mVisibleNotifications = new HashSet<>();
 
-        try {
-            ApplicationInfo ai = activity.getPackageManager().getApplicationInfo(activity.getPackageName(), PackageManager.GET_META_DATA);
-            Bundle bundle = ai.metaData;
-
-            Boolean rescheduleOnRestart = bundle.getBoolean("reschedule_notifications_on_restart");
+        Bundle metaData = getAppMetadata();
 
-            if (rescheduleOnRestart) {
-                ComponentName receiver = new ComponentName(mContext, UnityNotificationRestartOnBootReceiver.class);
-                PackageManager pm = mContext.getPackageManager();
+        Boolean rescheduleOnRestart = false;
+        if (metaData != null)
+            rescheduleOnRestart = metaData.getBoolean("reschedule_notifications_on_restart", false);
 
-                pm.setComponentEnabledSetting(receiver,
-                    PackageManager.COMPONENT_ENABLED_STATE_ENABLED,
-                    PackageManager.DONT_KILL_APP);
-            }
+        if (rescheduleOnRestart) {
+            ComponentName receiver = new ComponentName(mContext, UnityNotificationRestartOnBootReceiver.class);
+            PackageManager pm = mContext.getPackageManager();
 
-            mOpenActivity = UnityNotificationUtilities.getOpenAppActivity(mContext, false);
-            if (mOpenActivity == null)
-                mOpenActivity = activity.getClass();
-        } catch (PackageManager.NameNotFoundException e) {
-            Log.e(TAG_UNITY, "Failed to load meta-data, NameNotFound: " + e.getMessage());
-        } catch (NullPointerException e) {
-            Log.e(TAG_UNITY, "Failed to load meta-data, NullPointer: " + e.getMessage());
+            pm.setComponentEnabledSetting(receiver,
+                PackageManager.COMPONENT_ENABLED_STATE_ENABLED,
+                PackageManager.DONT_KILL_APP);
         }
 
+        mOpenActivity = UnityNotificationUtilities.getOpenAppActivity(mContext, false);
+        if (mOpenActivity == null)
+            mOpenActivity = activity.getClass();
+
         mBackgroundThread.start();
     }
 
@@ -136,6 +130,14 @@ public static synchronized UnityNotificationManager getNotificationManagerImpl(A
         return mUnityNotificationManager;
     }
 
+    private Bundle getAppMetadata() {
+        try {
+            return mContext.getPackageManager().getApplicationInfo(mContext.getPackageName(), PackageManager.GET_META_DATA).metaData;
+        } catch (PackageManager.NameNotFoundException e) {
+            return null;
+        }
+    }
+
     public NotificationManager getNotificationManager() {
         return (NotificationManager) mContext.getSystemService(Context.NOTIFICATION_SERVICE);
     }