Do not polute settings and cache in case scheduling excepts

Author: aurimasc

com.unity.mobile.notifications/Runtime/Android/Plugins/com/unity/androidnotifications/UnityNotificationBackgroundThread.java

@@ -28,8 +28,16 @@ public ScheduleNotificationTask(int id, Notification.Builder builder) {
         @Override
         public boolean run(Context context, Set<String> notificationIds) {
             String id = String.valueOf(notificationId);
-            UnityNotificationManager.mUnityNotificationManager.performNotificationScheduling(notificationId, notificationBuilder);
-            return notificationIds.add(id);
+            try {
+                UnityNotificationManager.mUnityNotificationManager.performNotificationScheduling(notificationId, notificationBuilder);
+                return notificationIds.add(id);
+            } finally {
+                // if failed to schedule or replace, remove from settings and cache, so the status is correctly reported
+                if (!notificationIds.contains(id)) {
+                    UnityNotificationManager.deleteExpiredNotificationIntent(context, id);
+                    UnityNotificationManager.removeScheduledNotification(Integer.valueOf(notificationId));
+                }
+            }
         }
     }
 

com.unity.mobile.notifications/Runtime/Android/Plugins/com/unity/androidnotifications/UnityNotificationManager.java

@@ -864,7 +864,7 @@ private static synchronized Notification getScheduledNotification(Integer id) {
         return mScheduledNotifications.get(id);
     }
 
-    private static synchronized Notification removeScheduledNotification(Integer id) {
+    protected static synchronized Notification removeScheduledNotification(Integer id) {
         return mScheduledNotifications.remove(id);
     }
 }