Merge pull request #239 from Unity-Technologies/android-permission-fixes

Android permission fixes

Author: aurimasc

com.unity.mobile.notifications/CHANGELOG.md

@@ -5,6 +5,7 @@ All notable changes to this package will be documented in this file.
 ## [Unreleased]
 
 ### Fixes:
+- [Android] - No longer use DeniedAndDontAskAgain permission response, only Denied.
 - [iOS] - Fix occasional crash when registering for push notifications.
 
 ## [2.1.0] - 2022-09-23

com.unity.mobile.notifications/Runtime/Android/AndroidNotificationCenter.cs

@@ -631,6 +631,9 @@ public static PermissionStatus UserPermissionToPost
                         permissionStatus = PermissionStatus.Denied;
                         SetPostPermissionSetting(permissionStatus);
                         break;
+                    case PermissionStatus.DeniedDontAskAgain:  // no longer used, revert to Denied
+                        permissionStatus = PermissionStatus.Denied;
+                        break;
                 }
 
                 return permissionStatus;

com.unity.mobile.notifications/Runtime/Android/NotificationPermission.cs

@@ -23,7 +23,7 @@ public enum PermissionStatus
         Denied = 2,
 
         /// <summary>
-        /// User denied permission and expressed intent to not be prompted again.
+        /// No longer used. User denied permission and expressed intent to not be prompted again.
         /// </summary>
         DeniedDontAskAgain = 3,
 
@@ -53,14 +53,14 @@ public class PermissionRequest
         /// Create a new request.
         /// Will show user a dialog asking for permission if that is required to post notifications and user hasn't permanently denied it already.
         /// </summary>
-        /// <see cref="PermissionStatus.DeniedDontAskAgain"/>
         public PermissionRequest()
         {
             Status = AndroidNotificationCenter.UserPermissionToPost;
             switch (Status)
             {
                 case PermissionStatus.NotRequested:
                 case PermissionStatus.Denied:
+                case PermissionStatus.DeniedDontAskAgain:  // this one is no longer used, but might be found in settings
                     Status = PermissionStatus.RequestPending;
                     RequestPermission();
                     break;
@@ -72,7 +72,6 @@ void RequestPermission()
             var callbacks = new PermissionCallbacks();
             callbacks.PermissionGranted += (unused) => PermissionResponse(PermissionStatus.Allowed);
             callbacks.PermissionDenied += (unused) => PermissionResponse(PermissionStatus.Denied);
-            callbacks.PermissionDeniedAndDontAskAgain += (unused) => PermissionResponse(PermissionStatus.DeniedDontAskAgain);
             Permission.RequestUserPermission(AndroidNotificationCenter.PERMISSION_POST_NOTIFICATIONS, callbacks);
         }