More issue fixes (#1253)

Author: jabbacakes

docs/advanced-topics/message-system/rpc.md

@@ -5,25 +5,20 @@ title: Rpc
 import ImageSwitcher from '@site/src/ImageSwitcher.js';
 
 
-Any process can communicate with any other process by sending an RPC. Starting in version 1.8, the `Rpc` attribute encompasses Server to Client Rpcs, Client to Server Rpcs, and Client to Client Rpcs.
+Any process can communicate with any other process by sending an RPC. Starting in version 1.8, the `Rpc` attribute encompasses server to client RPCs, client to server RPCs, and client to client RPCs.
 
 <figure>
 <ImageSwitcher
 lightImageSrc="/sequence_diagrams/RPCs/ServerRPCs.png?text=LightMode"
 darkImageSrc="/sequence_diagrams/RPCs/ServerRPCs_Dark.png?text=DarkMode"/>
 </figure>
 
-
-
 <figure>
 <ImageSwitcher
 lightImageSrc="/sequence_diagrams/RPCs/ClientRPCs.png?text=LightMode"
 darkImageSrc="/sequence_diagrams/RPCs/ClientRPCs_Dark.png?text=DarkMode"/>
 </figure>
 
-
-
-
 ## Declaring an RPC (Remote Procedure Call)
 
 You can declare an RPC by marking a method with the `[Rpc]` attribute and including the `Rpc` suffix in the method name. RPCs have a number of possible targets that can be declared at both runtime and compile time, but a default must be passed to the `[Rpc]` attribute. For example, to create an RPC that will be executed on the server, you would declare it like this:
@@ -58,7 +53,7 @@ While client-to-client RPCs are supported, it is important to note that there ar
 
 ## Invoking an RPC
 
-You can invoke an RPC by invoking the function directly with parameters:
+You can invoke an RPC by invoking the function directly with parameters. The following code is a heavily simplified example of a server to client RPC and a client to server RPC, with additional logic removed to display only the most basic features of an RPC.
 
 ```csharp
 [Rpc(SendTo.Server)]

docs/advanced-topics/serialization/cprimitives.md

@@ -3,7 +3,9 @@ id: cprimitives
 title: C# primitives
 ---
 
-C# primitive types will be serialized by built-in serialization code. These types include `bool`, `char`, `sbyte`, `byte`, `short`, `ushort`, `int`, `uint`, `long`, `ulong`, `float`, `double`, and `string`.
+C# primitive types are serialized by built-in serialization code. These types include `bool`, `char`, `sbyte`, `byte`, `short`, `ushort`, `int`, `uint`, `long`, `ulong`, `float`, `double`, and `string`.
+
+You can also serialize [arrays](serialization-arrays.md) of C# primitive types, with the exception of arrays of `strings` (`string[]`) for [performance reasons](serialization-arrays.md#performance-considerations).
 
 ```csharp
 [Rpc(SendTo.Server)]

docs/advanced-topics/serialization/serialization-arrays.md

@@ -3,18 +3,27 @@ id: arrays
 title: Arrays and native containers
 ---
 
-Arrays of [C# primitive types](cprimatives.md), like `int[]`, and [Unity primitive types](unity-primitives.md), such as `Vector3`, are serialized by built-in serialization code. Otherwise, any array of types that aren't handled by the built-in serialization code, such as `string[]`, needs to be handled through a container class or structure that implements the  [`INetworkSerializable`](inetworkserializable.md) interface.
+Netcode for GameObjects has built-in serialization code for arrays of [C# value-type primitives](cprimitives.md), like `int[]`, and [Unity primitive types](unity-primitives.md). Any arrays of types that aren't handled by the built-in serialization code, such as `string[]`, need to be handled using a container class or structure that implements the [`INetworkSerializable`](inetworkserializable.md) interface.
+
+## Performance considerations
+
+Sending arrays and strings over the network has performance implications. An array incurs a garbage collected allocation, and a string also incurs a garbage collected allocation, so an array of strings results in an allocation for every element in the array, plus one more for the array itself.
+
+For this reason, arrays of strings (`string[]`) aren't supported by the built-in serialization code. Instead, it's recommended to use `NativeArray<FixedString*>` or `NativeList<FixedString*>`, because they're more efficient and don't incur garbage collected memory allocation. Refer to [`NativeArray<T>`](#nativearrayt) and [`NativeList<T>`](#nativelistt) below for more details.
+
+## Built-in primitive types example
+
+Using built-in primitive types is fairly straightforward:
 
-## Built-In Primitive Types Example
-Using built-in primitive types is fairly straight forward:
 ```csharp
 [Rpc(SendTo.Server)]
 void HelloServerRpc(int[] scores, Color[] colors) { /* ... */ }
 ```
 
-## INetworkSerializable Implementation Example
-There are many ways to handle sending an array of managed types.
-The below example is a simple `string` container class that implements `INetworkSerializable` and can be used as an array of "StringContainers":
+## INetworkSerializable implementation example
+
+There are many ways to handle sending an array of managed types. The following example is a simple `string` container class that implements `INetworkSerializable` and can be used as an array of "StringContainers":
+
 ```csharp
 [Rpc(SendTo.ClientsAndHost)]
 void SendMessagesClientRpc(StringContainer[] messages)
@@ -42,11 +51,12 @@ public class StringContainer : INetworkSerializable
 }
 ```
 
-## Native Containers
+## Native containers
 
-Netcode for GameObjects supports `NativeArray` and `NativeList` native containers with built-in serialization, RPCs, and NetworkVariables. However, you cannot nest either of these containers without causing a crash.
+Netcode for GameObjects supports `NativeArray` and `NativeList` native containers with built-in serialization, RPCs, and NetworkVariables. However, you can't nest either of these containers without causing a crash.
 
 A few examples of nesting that will cause a crash:
+
 * `NativeArray<NativeList<T>>`
 * `NativeList<NativeArray<T>>`
 * `NativeArray<NativeArray<T>>`
@@ -59,6 +69,7 @@ To serialize a `NativeArray` container, use `serializer.SerializeValue(ref Array
 ### `NativeList<T>`
 
 To serialize a `NativeList` container, you must:
+
 1. Ensure your assemblies reference `Collections`.
 2. You must add `UNITY_NETCODE_NATIVE_COLLECTION_SUPPORT` to your **Scriptiong Define Symbols** list.
    1. From the Unity Editor top bar menu, go to **Edit** > **Project Settings...** > **Player**.
@@ -71,8 +82,7 @@ To serialize a `NativeList` container, you must:
 When using `NativeLists` within `INetworkSerializable`, the list `ref` value must be a valid, initialized `NativeList`.
 
 NetworkVariables are similar that the value must be initialized before it can receive updates.
-For example,
-`public NetworkVariable<NativeList<byte>> ByteListVar = new NetworkVariable<NativeList<byte>>{Value = new NativeList<byte>(Allocator.Persistent)};`
+For example, `public NetworkVariable<NativeList<byte>> ByteListVar = new NetworkVariable<NativeList<byte>>{Value = new NativeList<byte>(Allocator.Persistent)};`.
 
 RPCs do this automatically.
 :::