fix: PVP-151-1

Fixing the remaining PVP-151-1 errors.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Tests/Runtime/DistributedAuthority/ExtendedNetworkShowAndHideTests.cs

@@ -8,7 +8,7 @@ namespace Unity.Netcode.RuntimeTests
 {
     [TestFixture(HostOrServer.DAHost, true)]
     [TestFixture(HostOrServer.DAHost, false)]
-    public class ExtendedNetworkShowAndHideTests : NetcodeIntegrationTest
+    internal class ExtendedNetworkShowAndHideTests : NetcodeIntegrationTest
     {
         protected override int NumberOfClients => 3;
         private bool m_EnableSceneManagement;

com.unity.netcode.gameobjects/Tests/Runtime/DistributedAuthority/RpcProxyMessageTesting.cs

@@ -17,7 +17,7 @@ namespace Unity.Netcode.RuntimeTests
     /// </summary>
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.DAHost)]
-    public class RpcProxyMessageTesting : NetcodeIntegrationTest
+    internal class RpcProxyMessageTesting : NetcodeIntegrationTest
     {
         protected override int NumberOfClients => 2;
 

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableBaseInitializesWhenPersisted.cs

@@ -12,7 +12,7 @@ namespace Unity.Netcode.RuntimeTests
     [TestFixture(NetworkTopologyTypes.ClientServer, HostOrServer.Server)]
     [TestFixture(NetworkTopologyTypes.ClientServer, HostOrServer.Host)]
     [TestFixture(NetworkTopologyTypes.DistributedAuthority, HostOrServer.DAHost)]
-    public class NetworkVariableBaseInitializesWhenPersisted : NetcodeIntegrationTest
+    internal class NetworkVariableBaseInitializesWhenPersisted : NetcodeIntegrationTest
     {
         protected override int NumberOfClients => 1;
 

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableCollectionsTests.cs

@@ -23,7 +23,7 @@ namespace Unity.Netcode.RuntimeTests
     /// </summary>
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.Server)]
-    public class NetworkVariableCollectionsTests : NetcodeIntegrationTest
+    internal class NetworkVariableCollectionsTests : NetcodeIntegrationTest
     {
         protected override int NumberOfClients => 2;
 
@@ -1218,7 +1218,7 @@ public IEnumerator TestHashSetBuiltInTypeCollections()
     [TestFixture(HostOrServer.Host, CollectionTypes.Dictionary)]
     [TestFixture(HostOrServer.Server, CollectionTypes.List)]
     [TestFixture(HostOrServer.Server, CollectionTypes.Dictionary)]
-    public class NetworkVariableCollectionsChangingTests : NetcodeIntegrationTest
+    internal class NetworkVariableCollectionsChangingTests : NetcodeIntegrationTest
     {
         protected override int NumberOfClients => 2;
         public enum CollectionTypes
@@ -1411,7 +1411,7 @@ public IEnumerator CollectionAndOwnershipChangingTest()
     /// Helper class to test adding <see cref="NetworkVariable{T}"/> dictionary entries rapidly with frequent ownership changes.
     /// This includes a companion <see cref="NetworkVariable{T}"/> integer that is continually incremented and used as the key value for each entry.
     /// </summary>
-    public class DictionaryCollectionUpdateHelper : BaseCollectionUpdateHelper
+    internal class DictionaryCollectionUpdateHelper : BaseCollectionUpdateHelper
     {
         private NetworkVariable<Dictionary<int, int>> m_DictionaryCollection = new NetworkVariable<Dictionary<int, int>>(new Dictionary<int, int>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Owner);
         private NetworkVariable<int> m_CurrentKeyValue = new NetworkVariable<int>(0, NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Owner);
@@ -1459,7 +1459,7 @@ protected override void AddItem()
     /// <summary>
     /// Helper class to test adding list entries rapidly with frequent ownership changes
     /// </summary>
-    public class ListCollectionUpdateHelper : BaseCollectionUpdateHelper
+    internal class ListCollectionUpdateHelper : BaseCollectionUpdateHelper
     {
         private NetworkVariable<List<int>> m_ListCollection = new NetworkVariable<List<int>>(new List<int>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Owner);
 
@@ -1507,7 +1507,7 @@ protected override void AddItem()
     /// <summary>
     /// The base class to test rapidly adding items to a collection type
     /// </summary>
-    public class BaseCollectionUpdateHelper : NetworkBehaviour
+    internal class BaseCollectionUpdateHelper : NetworkBehaviour
     {
         public static bool VerboseMode;
         private const int k_OwnershipTickDelay = 1;
@@ -1700,7 +1700,7 @@ protected void Log(string msg)
     #endregion
 
     #region HASHSET COMPONENT HELPERS
-    public class HashSetBaseTypeTestHelper : ListTestHelperBase, IHashSetTestHelperBase<int>
+    internal class HashSetBaseTypeTestHelper : ListTestHelperBase, IHashSetTestHelperBase<int>
     {
         public static Dictionary<ulong, Dictionary<ulong, HashSetBaseTypeTestHelper>> Instances = new Dictionary<ulong, Dictionary<ulong, HashSetBaseTypeTestHelper>>();
 
@@ -1949,7 +1949,7 @@ public override void OnNetworkDespawn()
     #endregion
 
     #region DICTIONARY COMPONENT HELPERS
-    public class NestedDictionaryTestHelper : ListTestHelperBase, IDictionaryTestHelperBase<int, Dictionary<int, SerializableObject>>
+    internal class NestedDictionaryTestHelper : ListTestHelperBase, IDictionaryTestHelperBase<int, Dictionary<int, SerializableObject>>
     {
         public static Dictionary<ulong, Dictionary<ulong, NestedDictionaryTestHelper>> Instances = new Dictionary<ulong, Dictionary<ulong, NestedDictionaryTestHelper>>();
 
@@ -2256,7 +2256,7 @@ public override void OnNetworkDespawn()
         }
     }
 
-    public class DictionaryTestHelper : ListTestHelperBase, IDictionaryTestHelperBase<int, SerializableObject>
+    internal class DictionaryTestHelper : ListTestHelperBase, IDictionaryTestHelperBase<int, SerializableObject>
     {
         public static Dictionary<ulong, Dictionary<ulong, DictionaryTestHelper>> Instances = new Dictionary<ulong, Dictionary<ulong, DictionaryTestHelper>>();
 
@@ -2542,7 +2542,7 @@ public override void OnNetworkDespawn()
     #endregion
 
     #region INETWORKSERIALIZABLE LIST TEST COMPONENT HELPERS
-    public class SerializableObject : INetworkSerializable, IEquatable<SerializableObject>
+    internal class SerializableObject : INetworkSerializable, IEquatable<SerializableObject>
     {
         public static SerializableObject GetRandomObject()
         {
@@ -2598,7 +2598,7 @@ public bool Equals(SerializableObject other)
 
     }
 
-    public class ListTestHelperListSerializableObject : ListTestHelperBase, IListTestHelperBase<List<SerializableObject>>
+    internal class ListTestHelperListSerializableObject : ListTestHelperBase, IListTestHelperBase<List<SerializableObject>>
     {
         public static Dictionary<ulong, Dictionary<ulong, ListTestHelperListSerializableObject>> Instances = new Dictionary<ulong, Dictionary<ulong, ListTestHelperListSerializableObject>>();
 
@@ -2897,7 +2897,7 @@ public override void OnNetworkDespawn()
         }
     }
 
-    public class ListTestHelperSerializableObject : ListTestHelperBase, IListTestHelperBase<SerializableObject>
+    internal class ListTestHelperSerializableObject : ListTestHelperBase, IListTestHelperBase<SerializableObject>
     {
         public static Dictionary<ulong, Dictionary<ulong, ListTestHelperSerializableObject>> Instances = new Dictionary<ulong, Dictionary<ulong, ListTestHelperSerializableObject>>();
 
@@ -3162,7 +3162,7 @@ public override void OnNetworkDespawn()
     #endregion
 
     #region BUILT-IN LIST TEST COMPONENT HELPERS
-    public class ListTestHelperListInt : ListTestHelperBase, IListTestHelperBase<List<int>>
+    internal class ListTestHelperListInt : ListTestHelperBase, IListTestHelperBase<List<int>>
     {
         public static Dictionary<ulong, Dictionary<ulong, ListTestHelperListInt>> Instances = new Dictionary<ulong, Dictionary<ulong, ListTestHelperListInt>>();
 
@@ -3466,7 +3466,7 @@ public override void OnNetworkDespawn()
 
     }
 
-    public class ListTestHelperInt : ListTestHelperBase, IListTestHelperBase<int>
+    internal class ListTestHelperInt : ListTestHelperBase, IListTestHelperBase<int>
     {
         public static Dictionary<ulong, Dictionary<ulong, ListTestHelperInt>> Instances = new Dictionary<ulong, Dictionary<ulong, ListTestHelperInt>>();
 
@@ -3735,7 +3735,7 @@ public override void OnNetworkDespawn()
     #endregion
 
     #region BASE TEST COMPONENT HELPERS
-    public class ListTestHelperBase : NetworkBehaviour
+    internal class ListTestHelperBase : NetworkBehaviour
     {
         protected static bool IsDebugMode { get; private set; }
 
@@ -3782,7 +3782,7 @@ public virtual bool CompareTrackedChanges(Targets target)
         }
     }
 
-    public interface IListTestHelperBase<T>
+    internal interface IListTestHelperBase<T>
     {
         public bool ValidateInstances();
 
@@ -3815,7 +3815,7 @@ public interface IListTestHelperBase<T>
         public void ResetTrackedChanges();
     }
 
-    public interface IDictionaryTestHelperBase<TKey, TValue>
+    internal interface IDictionaryTestHelperBase<TKey, TValue>
     {
         public bool ValidateInstances();
 
@@ -3844,7 +3844,7 @@ public interface IDictionaryTestHelperBase<TKey, TValue>
         public void ResetTrackedChanges();
     }
 
-    public interface IHashSetTestHelperBase<T>
+    internal interface IHashSetTestHelperBase<T>
     {
         public bool ValidateInstances();
 

com.unity.netcode.gameobjects/Tests/Runtime/TestHelpers/Components/ObjectNameIdentifier.cs

@@ -1,6 +1,12 @@
 using System;
 namespace Unity.Netcode.TestHelpers.Runtime
 {
+    /// <summary>
+    /// Used in conjunction with integratioin tests, this <see cref="NetworkBehaviour"/> derived
+    /// class is used to provide additional identification information in the name of the spawned
+    /// objects in order to simplify finding a specific instance.
+    /// <see cref="NetcodeIntegrationTest"/>
+    /// </summary>
     public class ObjectNameIdentifier : NetworkBehaviour
     {
         private ulong m_CurrentOwner;
@@ -18,12 +24,16 @@ public class ObjectNameIdentifier : NetworkBehaviour
         private NetworkObject m_NetworkObject;
         private string m_OriginalName;
 
+        /// <inheritdoc/>
         public override void OnNetworkSpawn()
         {
             RegisterAndLabelNetworkObject();
         }
 
 
+        /// <summary>
+        /// Invoke to register and label the spawned <see cref="NetworkObject"/>.
+        /// </summary>
         protected void RegisterAndLabelNetworkObject()
         {
             if (!m_IsRegistered)
@@ -58,6 +68,9 @@ protected void RegisterAndLabelNetworkObject()
             }
         }
 
+        /// <summary>
+        /// Invoke to remove the object from registration.
+        /// </summary>
         protected void DeRegisterNetworkObject()
         {
             if (m_IsRegistered)
@@ -67,23 +80,27 @@ protected void DeRegisterNetworkObject()
             }
         }
 
+        /// <inheritdoc/>
         public override void OnLostOwnership()
         {
             DeRegisterNetworkObject();
             RegisterAndLabelNetworkObject();
         }
 
+        /// <inheritdoc/>
         public override void OnGainedOwnership()
         {
             DeRegisterNetworkObject();
             RegisterAndLabelNetworkObject();
         }
 
+        /// <inheritdoc/>
         public override void OnNetworkDespawn()
         {
             DeRegisterNetworkObject();
         }
 
+        /// <inheritdoc/>
         public override void OnDestroy()
         {
             if (m_NetworkObject != null)

com.unity.netcode.gameobjects/Tests/Runtime/TestHelpers/ConditionalPredicate.cs

@@ -12,32 +12,48 @@ public class ConditionalPredicateBase : IConditionalPredicate
 
         public bool TimedOut { get { return m_TimedOut; } }
 
+        /// <summary>
+        /// Override this method to incorporate your own conditional logic
+        /// </summary>
+        /// <returns>true for condition being met and false for the condition has yet to be met.</returns>
         protected virtual bool OnHasConditionBeenReached()
         {
             return true;
         }
 
+        /// <inheritdoc/>
         public bool HasConditionBeenReached()
         {
             return OnHasConditionBeenReached();
         }
 
+        /// <summary>
+        /// Override this to initialize anything for the conditioinal check.
+        /// </summary>
         protected virtual void OnStarted() { }
 
+        /// <inheritdoc/>
         public void Started()
         {
             OnStarted();
         }
 
+        /// <summary>
+        /// Override this to clean up anything used in the conditional check.
+        /// </summary>
         protected virtual void OnFinished() { }
 
+        /// <inheritdoc/>
         public void Finished(bool timedOut)
         {
             m_TimedOut = timedOut;
             OnFinished();
         }
     }
 
+    /// <summary>
+    /// A conditional predicate interface used with integration testing.
+    /// </summary>
     public interface IConditionalPredicate
     {
         /// <summary>