Skip to content

Commit 1904645

Browse files
committed
Corrected last 150-1 exceptions
1 parent 7813e16 commit 1904645

File tree

4 files changed

+6
-13
lines changed

4 files changed

+6
-13
lines changed

com.unity.netcode.gameobjects/Runtime/SceneManagement/NetworkSceneManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3204,7 +3204,7 @@ public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReade
32043204
/// Returns the list of all scene mappings when scene management is enabled.
32053205
/// </summary>
32063206
/// <param name="mapType">The map type to return <see cref="MapTypes"/></param>
3207-
/// <returns></returns>
3207+
/// <returns>A list of <see cref="SceneMap"/> objects representing the scene mappings.</returns>
32083208
public List<SceneMap> GetSceneMapping(MapTypes mapType)
32093209
{
32103210
var mapping = new List<SceneMap>();

com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ private bool ClientBindAndConnect()
600600
/// Virtual method that is invoked during <see cref="StartClient"/>.
601601
/// </summary>
602602
/// <param name="serverEndpoint">The <see cref="NetworkEndpoint"/> that the client is connecting to.</param>
603-
/// <returns></returns>
603+
/// <returns>A <see cref="NetworkConnection"/> representing the connection to the server, or an invalid connection if the connection attempt fails.</returns>
604604
protected virtual NetworkConnection Connect(NetworkEndpoint serverEndpoint)
605605
{
606606
return m_Driver.Connect(serverEndpoint);

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableBaseInitializesWhenPersisted.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ public static void OneTimeSetup(int numberOfInstances, GameObject prefabInstance
253253
/// <summary>
254254
/// Invoke when <see cref="NetworkManager"/>s are created but not started.
255255
/// </summary>
256-
/// <param name="networkManager"></param>
256+
/// <param name="networkManager">The <see cref="NetworkManager"/> instance to assign a handler to. Must not be null and must not already have a handler assigned.</param>
257257
public static void AssignHandler(NetworkManager networkManager)
258258
{
259259
if (s_PrefabInstanceHandlers.Count > 0)
@@ -290,9 +290,9 @@ public static bool ValidatePersistedInstances(NetworkManager networkManager, int
290290

291291
/// <summary>
292292
/// Releases back to the queue and if destroy is true it will completely
293-
/// remove all references so they are cleaned up when
293+
/// remove all references so they are cleaned up when
294294
/// </summary>
295-
/// <param name="destroy"></param>
295+
/// <param name="destroy">If true, completely removes all references and cleans up instances. If false, returns handlers to the queue for reuse.</param>
296296
public static void ReleaseAll(bool destroy = false)
297297
{
298298
foreach (var entry in s_AssignedInstances)
@@ -333,6 +333,7 @@ public void Initialize(NetworkManager networkManager)
333333
/// <summary>
334334
/// This validates that the instances persisted to the next test set and persisted
335335
/// between network sessions
336+
/// </summary>
336337
public bool ValidateInstanceSpawnCount(int minCount)
337338
{
338339
// First pass we should have no instances

pvpExceptions.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,6 @@
55
"CHANGELOG.md: line 9: Unreleased section is not allowed for public release"
66
]
77
},
8-
"PVP-150-1": {
9-
"errors": [
10-
"Unity.Netcode.RuntimeTests.NetworkVariableBaseInitializesWhenPersisted.PrefabInstanceHandler: void AssignHandler(NetworkManager): empty <param> tag",
11-
"Unity.Netcode.RuntimeTests.NetworkVariableBaseInitializesWhenPersisted.PrefabInstanceHandler: void ReleaseAll(bool): empty <param> tag",
12-
"Unity.Netcode.RuntimeTests.NetworkVariableBaseInitializesWhenPersisted.PrefabInstanceHandler: bool ValidateInstanceSpawnCount(int): XML is not well-formed: Expected an end tag for element 'summary'",
13-
"Unity.Netcode.Transports.UTP.UnityTransport: NetworkConnection Connect(NetworkEndPoint): empty <returns> tag"
14-
]
15-
},
168
"PVP-151-1": {
179
"errors": [
1810
"Unity.Netcode.Editor.Configuration.NetcodeForGameObjectsProjectSettings: undocumented",

0 commit comments

Comments
 (0)