fix: client network transform initialization (#1290)

* fix: client network transform initialization

* restore private

Author: mattwalsh-unity

com.unity.netcode.gameobjects/Components/NetworkTransform.cs

@@ -683,17 +683,8 @@ private void Awake()
         {
             m_Transform = transform;
 
-            // ReplNetworkState.NetworkVariableChannel = NetworkChannel.PositionUpdate; // todo figure this out, talk with Matt/Fatih, this should be unreliable
-
-            m_ReplicatedNetworkState.OnValueChanged += OnNetworkStateChanged;
-        }
-
-        public override void OnNetworkSpawn()
-        {
-            CanCommitToTransform = IsServer;
-            m_CachedIsServer = IsServer;
-            m_CachedNetworkManager = NetworkManager;
-
+            // we only want to create our interpolators during Awake so that, when pooled, we do not create tons
+            //  of gc thrash each time objects wink out and are re-used
             m_PositionXInterpolator = new BufferedLinearInterpolatorFloat();
             m_PositionYInterpolator = new BufferedLinearInterpolatorFloat();
             m_PositionZInterpolator = new BufferedLinearInterpolatorFloat();
@@ -711,14 +702,32 @@ public override void OnNetworkSpawn()
                 m_AllFloatInterpolators.Add(m_ScaleYInterpolator);
                 m_AllFloatInterpolators.Add(m_ScaleZInterpolator);
             }
+        }
+
+        public override void OnNetworkSpawn()
+        {
+            m_ReplicatedNetworkState.OnValueChanged += OnNetworkStateChanged;
+
+            CanCommitToTransform = IsServer;
+            m_CachedIsServer = IsServer;
+            m_CachedNetworkManager = NetworkManager;
+
             if (CanCommitToTransform)
             {
                 TryCommitTransformToServer(m_Transform, m_CachedNetworkManager.LocalTime.Time);
             }
             m_LocalAuthoritativeNetworkState = m_ReplicatedNetworkState.Value;
+
+            // crucial we do this to reset the interpolators so that recycled objects when using a pool will
+            //  not have leftover interpolator state from the previous object
             Initialize();
         }
 
+        public override void OnNetworkDespawn()
+        {
+            m_ReplicatedNetworkState.OnValueChanged -= OnNetworkStateChanged;
+        }
+
         public override void OnGainedOwnership()
         {
             Initialize();
@@ -743,13 +752,6 @@ private void Initialize()
             }
         }
 
-        public override void OnDestroy()
-        {
-            m_ReplicatedNetworkState.OnValueChanged -= OnNetworkStateChanged;
-
-            base.OnDestroy();
-        }
-
         #region state set
 
         /// <summary>

com.unity.netcode.gameobjects/Runtime/Timing/NetworkTime.cs

@@ -105,7 +105,7 @@ public NetworkTime ToFixedTime()
             return new NetworkTime(m_TickRate, m_CachedTick);
         }
 
-        public NetworkTime TimeTicksAgo(uint ticks)
+        public NetworkTime TimeTicksAgo(int ticks)
         {
             return this - new NetworkTime(TickRate, ticks);
         }

com.unity.netcode.gameobjects/Samples/ClientNetworkTransform/Scripts/ClientNetworkTransform.cs

@@ -18,8 +18,9 @@ public class ClientNetworkTransform : NetworkTransform
         /// </summary>
         // This is public to make sure that users don't depend on this IsClient && IsOwner check in their code. If this logic changes in the future, we can make it invisible here
 
-        private void Awake()
+        public override void OnNetworkSpawn()
         {
+            base.OnNetworkSpawn();
             CanCommitToTransform = IsOwner;
         }