fix

First pass at fixing the issue where a server authority instance would lag behind when using the new interpolators. This was especially visible when the moving body completely stopped, all state updates were processed, and then shortly later it began to move again there would be a delay between the 1st state update and the rest of the pending state updates.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Runtime/Components/Interpolator/BufferedLinearInterpolator.cs

@@ -192,6 +192,8 @@ public void Reset(T currentValue)
                 TimeToTargetValue = 0.0f;
                 DeltaTime = 0.0f;
                 m_CurrentDeltaTime = 0.0f;
+                MaxDeltaTime = 0.0f;
+                LastRemainingTime = 0.0f;
             }
         }
 
@@ -292,13 +294,9 @@ private void TryConsumeFromBuffer(double renderTime, double minDeltaTime, double
             var potentialItemNeedsProcessing = false;
 
             // In the event there is nothing left in the queue (i.e. motion/change stopped), we still need to determine if the target has been reached.
-            if (!noStateSet && m_BufferQueue.Count == 0)
+            if (!noStateSet && !InterpolateState.TargetReached)
             {
-                if (!InterpolateState.TargetReached)
-                {
-                    InterpolateState.TargetReached = IsApproximately(InterpolateState.CurrentValue, InterpolateState.Target.Value.Item, GetPrecision());
-                }
-                return;
+                InterpolateState.TargetReached = IsApproximately(InterpolateState.CurrentValue, InterpolateState.Target.Value.Item, GetPrecision());
             }
 
             // Continue to process any remaining state updates in the queue (if any)
@@ -314,14 +312,10 @@ private void TryConsumeFromBuffer(double renderTime, double minDeltaTime, double
                 if (!noStateSet)
                 {
                     potentialItemNeedsProcessing = ((potentialItem.TimeSent <= renderTime) && potentialItem.TimeSent > InterpolateState.Target.Value.TimeSent);
-                    if (!InterpolateState.TargetReached)
-                    {
-                        InterpolateState.TargetReached = IsApproximately(InterpolateState.CurrentValue, InterpolateState.Target.Value.Item, GetPrecision());
-                    }
                 }
 
                 // If we haven't set a target or we have another item that needs processing.
-                if (noStateSet || potentialItemNeedsProcessing)
+                if ((noStateSet && (potentialItem.TimeSent <= renderTime)) || potentialItemNeedsProcessing)
                 {
                     if (m_BufferQueue.TryDequeue(out BufferedItem target))
                     {

com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs

@@ -4049,13 +4049,12 @@ public double GetPositionLastRemainingTime()
         }
 #endif
 
-
-
         // Non-Authority
         private void UpdateInterpolation()
         {
             AdjustForChangeInTransformSpace();
-            var timeSystem = m_CachedNetworkManager.ServerTime;
+            // Select the time system relative to the type of NetworkManager instance.
+            var timeSystem = m_CachedNetworkManager.IsServer ? m_CachedNetworkManager.ServerTime : m_CachedNetworkManager.LocalTime;
             var currentTime = timeSystem.Time;
 #if COM_UNITY_MODULES_PHYSICS || COM_UNITY_MODULES_PHYSICS2D
             var cachedDeltaTime = m_UseRigidbodyForMotion ? m_CachedNetworkManager.RealTimeProvider.FixedDeltaTime : m_CachedNetworkManager.RealTimeProvider.DeltaTime;