Final fixes

Author: EmandM

com.unity.netcode.gameobjects/Editor/CodeGen/NetworkBehaviourILPP.cs

@@ -1431,8 +1431,7 @@ private void ProcessNetworkBehaviour(TypeDefinition typeDefinition, string[] ass
                     MethodReference callMethod = rpcHandler;
                     if (typeDefinition.HasGenericParameters)
                     {
-                        var genericTypes = new List<TypeReference>();
-                        genericTypes.AddRange(typeDefinition.GenericParameters);
+                        var genericTypes = new List<TypeReference>(typeDefinition.GenericParameters);
                         callMethod = callMethod.MakeGeneric(genericTypes.ToArray());
                     }
 
@@ -3098,8 +3097,7 @@ private MethodDefinition GenerateStaticHandler(MethodDefinition methodDefinition
             var callMethod = (MethodReference)methodDefinition;
             if (castType.HasGenericParameters)
             {
-                var genericTypes = new List<TypeReference>();
-                genericTypes.AddRange(castType.GenericParameters);
+                var genericTypes = new List<TypeReference>(castType.GenericParameters);
                 castType = castType.MakeGenericInstanceType(genericTypes.ToArray());
                 callMethod = callMethod.MakeGeneric(genericTypes.ToArray());
             }

com.unity.netcode.gameobjects/Runtime/Components/Helpers/AttachableBehaviour.cs

@@ -463,8 +463,7 @@ internal void InternalDetach()
                 {
                     // Set the original parent and origianl local position and rotation
                     transform.SetParent(m_DefaultParent.transform, false);
-                    transform.localPosition = m_OriginalLocalPosition;
-                    transform.localRotation = m_OriginalLocalRotation;
+                    transform.SetLocalPositionAndRotation(m_OriginalLocalPosition, m_OriginalLocalRotation);
                 }
                 m_AttachState = AttachState.Detached;
             }

testproject/Assets/Tests/Manual/InSceneObjectParentingTests/ChildObjectScript.cs

@@ -65,10 +65,9 @@ public override void OnNetworkObjectParentChanged(NetworkObject parentNetworkObj
             {
                 // This preserves the original position offset of the object when parented with
                 // WorldPositionStays set to false.
-                transform.localPosition = m_OriginalLocalPosition;
+                transform.SetLocalPositionAndRotation(m_OriginalLocalPosition, m_OriginalLocalRotation);
 
-                // Optionally, you can also make other modifications to rotation or scale
-                transform.localRotation = m_OriginalLocalRotation;
+                // Optionally, you can also make other modifications to scale
                 transform.localScale = m_OriginalLocalScale;
             }
             else if (parentNetworkObject == null && m_LastParent)