fix: TestTimeIntegrationTest can skip the required shutdown and clean up if it asserts (#1896)

NoelStephensUnity · web-flow · commit 595a3e502cf3 · 2022-04-26T04:23:18.000-05:00
* fix

* style

adding comment
diff --git a/com.unity.netcode.gameobjects/Tests/Runtime/Timing/TimeMultiInstanceTest.cs b/com.unity.netcode.gameobjects/Tests/Runtime/Timing/TimeMultiInstanceTest.cs
@@ -89,8 +89,13 @@ public IEnumerator TestTimeIntegrationTest(int targetFrameRate, uint tickRate)
                 // compares the two client times, only difference should be based on buffering.
                 m_Client1State.AssertCheckDifference(m_Client2State, 0.2 - tickInterval, (0.1 - tickInterval), tickInterval * 2 + frameInterval * 2 + k_AdditionalTimeTolerance);
             }
+        }
 
+        protected override IEnumerator OnTearDown()
+        {
+            // Always "shutdown in a tear-down" otherwise you can cause all proceeding tests to fail
             ShutdownAndCleanUp();
+            yield return base.OnTearDown();
         }
 
         // This is from NetcodeIntegrationTest but we need a custom version of this to modifiy the config

Original file line number	Diff line number	Diff line change
`@@ -89,8 +89,13 @@ public IEnumerator TestTimeIntegrationTest(int targetFrameRate, uint tickRate)`
`89`	`89`	`// compares the two client times, only difference should be based on buffering.`
`90`	`90`	`m_Client1State.AssertCheckDifference(m_Client2State, 0.2 - tickInterval, (0.1 - tickInterval), tickInterval * 2 + frameInterval * 2 + k_AdditionalTimeTolerance);`
`91`	`91`	`}`
	`92`	`+ }`
`92`	`93`
	`94`	`+ protected override IEnumerator OnTearDown()`
	`95`	`+ {`
	`96`	`+ // Always "shutdown in a tear-down" otherwise you can cause all proceeding tests to fail`
`93`	`97`	`ShutdownAndCleanUp();`
	`98`	`+ yield return base.OnTearDown();`
`94`	`99`	`}`
`95`	`100`
`96`	`101`	`// This is from NetcodeIntegrationTest but we need a custom version of this to modifiy the config`