Added --wait flag when downloading editor

Author: michalChrobot

.yamato/code-coverage.yml

@@ -34,7 +34,7 @@ code_coverage_{{ platform.name }}_{{ editor }}:
     image: {{ platform.image }}
     flavor: {{ platform.flavor }}
   commands:
-    - unity-downloader-cli -u {{ editor }} -c Editor
+    - unity-downloader-cli -u {{ editor }} -c Editor --wait
     - upm-pvp create-test-project test-project --packages "upm-ci~/packages/*.tgz" --unity .Editor
     - UnifiedTestRunner --suite=editor --suite=playmode --editor-location=.Editor --testproject=test-project --enable-code-coverage -coverage-results-path=$PWD/test-results/CodeCoverage --coverage-options="generateHtmlReport;generateAdditionalMetrics;assemblyFilters:+Unity.Netcode.Editor,+Unity.Netcode.Runtime" --extra-editor-arg=--burst-disable-compilation --timeout=1800 --reruncount=1 --clean-library-on-rerun --artifacts-path=test-results
   artifacts:

.yamato/console-standalone-test.yml

@@ -47,7 +47,7 @@ console_standalone_build_{{ project.name }}_{{ platform.name }}_{{ editor }}:
     image: {{ platform.image }}
     flavor: {{ platform.flavor }}
   commands:
-    - unity-downloader-cli -u {{ editor }} -c Editor -c il2cpp -c {{ platform.name }}
+    - unity-downloader-cli -u {{ editor }} -c Editor -c il2cpp -c {{ platform.name }} --wait
     - UnifiedTestRunner --testproject={{ project.path }} --architecture={% if platform.name == "switch" %}arm64{% else %}x64{% endif %} --scripting-backend=il2cpp --suite=playmode --platform={{ platform.standalone }} --editor-location=.Editor --artifacts-path=artifacts --player-save-path=build/players --testfilter="Unity.Netcode.RuntimeTests.*" --extra-editor-arg=-batchmode --extra-editor-arg=-nographics --reruncount=1 --clean-library-on-rerun --build-only --timeout=1800
   variables:
 # PS4 related
@@ -86,7 +86,7 @@ console_standalone_test_{{ project.name }}_{{ platform.name }}_{{ editor }}:
     model: {{ platform.model }}
 {% endif %}
   commands:
-    - unity-downloader-cli -u {{ editor }} -c Editor -c il2cpp -c {{ platform.name }}
+    - unity-downloader-cli -u {{ editor }} -c Editor -c il2cpp -c {{ platform.name }} --wait
     - UnifiedTestRunner --suite=playmode --testproject={{ project.path }} --editor-location=.Editor --artifacts-path=test-results --player-load-path=build/players --fail-on-assert --reruncount=1 --clean-library-on-rerun --timeout=1800
   variables:
 # PS4 related

.yamato/desktop-standalone-tests.yml

@@ -40,7 +40,7 @@ desktop_standalone_build_{{ project.name }}_{{ platform.name }}_{{ backend }}_{{
     image: {{ platform.image }}
     flavor: {{ platform.flavor }}
   commands:
-    - unity-downloader-cli -u {{ editor }} -c Editor {% if backend == "il2cpp" %} -c il2cpp {% endif %}
+    - unity-downloader-cli -u {{ editor }} -c Editor {% if backend == "il2cpp" %} -c il2cpp {% endif %} --wait
     - UnifiedTestRunner --suite=playmode --platform={{ platform.standalone }} --editor-location=.Editor --testproject={{ project.path }} --scripting-backend={{ backend }} --testfilter="Unity.Netcode.RuntimeTests.*" --player-save-path=build/players --artifacts-path=artifacts --extra-editor-arg=-batchmode --extra-editor-arg=-nographics --reruncount=1 --clean-library-on-rerun --build-only --timeout=1800
   artifacts:
     players:
@@ -81,7 +81,7 @@ desktop_standalone_test_{{ project.name }}_{{ platform.name }}_{{ backend }}_{{
 {% endif %}
 
   commands:
-    - unity-downloader-cli -u {{ editor }} -c Editor {% if backend == "il2cpp" %} -c il2cpp {% endif %}
+    - unity-downloader-cli -u {{ editor }} -c Editor {% if backend == "il2cpp" %} -c il2cpp {% endif %} --wait
     - UnifiedTestRunner --suite=playmode --player-load-path=build/players --artifacts-path=test-results --testproject={{ project.path }} --editor-location=.Editor --playergraphicsapi=Null --fail-on-assert --reruncount=1 --clean-library-on-rerun --timeout=1800
 
     # If ubuntu, run rust echo server

.yamato/mobile-standalone-test.yml

@@ -46,7 +46,7 @@ mobile_standalone_build_{{ project.name }}_{{ platform.name }}_{{ editor }}:
     image: {{ platform.image }}
     flavor: {{ platform.flavor }}
   commands:
-    - unity-downloader-cli -u {{ editor }} -c Editor -c il2cpp {% if platform.base == "mac" %} -c ios {% else %} -c android {% endif %}
+    - unity-downloader-cli -u {{ editor }} -c Editor -c il2cpp {% if platform.base == "mac" %} -c ios {% else %} -c android {% endif %} --wait
     - UnifiedTestRunner --suite=playmode --platform={{ platform.standalone }} --testproject={{ project.path }} --architecture={{ platform.architecture }} --scripting-backend=il2cpp --editor-location=.Editor --artifacts-path=artifacts --testfilter="Unity.Netcode.RuntimeTests.*" --player-save-path=build/players --extra-editor-arg=-batchmode --extra-editor-arg=-nographics --reruncount=1 --clean-library-on-rerun --build-only --timeout=1800
   artifacts:
     players:
@@ -75,7 +75,7 @@ mobile_standalone_test_{{ project.name }}_{{ platform.name }}_{{ editor }}:
 {% endif %}
   commands:
     # Installing editor. We still need the editor to run tests on standalone build and for that the Editor is required
-    - unity-downloader-cli -u {{ editor }} -c Editor -c il2cpp {% if platform.base == "mac" %} -c ios {% else %} -c android {% endif %}
+    - unity-downloader-cli -u {{ editor }} -c Editor -c il2cpp {% if platform.base == "mac" %} -c ios {% else %} -c android {% endif %} --wait
 
 {% if platform.standalone == "Android" %}
     # Download standalone UnityTestRunner and ADB setup

.yamato/package-tests.yml

@@ -36,7 +36,7 @@ package_test_-_ngo_{{ editor }}_{{ platform.name }}:
     XRAY_PROFILE: "supported ./pvpExceptions.json"
     UNITY_EXT_LOGGING: 1
   commands:
-    - unity-downloader-cli -u {{ editor }} -c Editor --fast --wait
+    - unity-downloader-cli -u {{ editor }} -c Editor --wait
 
     # Validate PVP checks for package.
     - upm-pvp test --unity .Editor --packages "upm-ci~/packages/*.tgz" --filter "com.unity.netcode.gameobjects" --results pvp-results

.yamato/performance-tests.yml

@@ -32,7 +32,7 @@ performance_editor_tests_-_NGO_{{ platform.name }}_{{ editor }}_no_data_reportin
     image: {{ platform.image }}
     flavor: {{ platform.flavor }}
   commands:
-    - unity-downloader-cli -u {{ editor }} -c Editor # Installing basic editor
+    - unity-downloader-cli -u {{ editor }} -c Editor --wait # Installing basic editor
     - UnifiedTestRunner --suite=editor --suite=playmode --testproject={{ project.path }} --editor-location=.Editor --timeout=3600 --artifacts-path=artifacts --extra-editor-arg=-assemblyNames --extra-editor-arg=Unity.NetCode.* --extra-editor-arg=-testCategory --extra-editor-arg=Performance --extra-editor-arg=-enablePackageManagerTraces --reruncount=1 --clean-library-on-rerun --dontreportperformancedata
     # TODO: when performance tests will be present we need to add actual execution of this test
   artifacts:

.yamato/project-standards.yml

@@ -41,7 +41,7 @@ standards_{{ platform.name }}_{{ project.name }}_{{ editor }}:
     - dotnet --version
     - dotnet format --version
 
-    - unity-downloader-cli -u {{ editor }} -c editor # Downloads basic editor
+    - unity-downloader-cli -u {{ editor }} -c editor --wait # Downloads basic editor
     - .Editor/Unity -batchmode -nographics -logFile - -executeMethod Packages.Rider.Editor.RiderScriptEditor.SyncSolution -projectPath {{ project.path }} -quit # This command is used to invoke Unity in a "headless" mode. It's used to sync the project
     - dotnet run --project=dotnet-tools/netcode.standards -- --project={{ project.path }} --check # Runs standards check
 {% endfor -%}

.yamato/project-tests.yml

@@ -36,7 +36,7 @@ test_{{ project.name }}_{{ platform.name }}_{{ editor }}:
     flavor: {{ platform.flavor }}
   commands:
     - npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm # upm-ci is not preinstalled on the image so we need to download it
-    - unity-downloader-cli -u {{ editor }} -c Editor # Installing basic editor for tests execution
+    - unity-downloader-cli -u {{ editor }} -c Editor --wait # Installing basic editor for tests execution
     - upm-ci project test -u {{ editor }} --project-path {{ project.path }} --type project-tests --extra-utr-arg="--reruncount=1 --clean-library-on-rerun" # project tests execution via upm-ci
   artifacts:
     logs:

.yamato/webgl-build.yml

@@ -33,7 +33,7 @@ webgl_build_{{ project.name }}_{{ platform.name }}_{{ editor }}:
     image: {{ platform.image }}
     flavor: {{ platform.flavor }}
   commands:
-    - unity-downloader-cli -u {{ editor }} -c Editor -c webgl -c il2cpp # Downloading the editor with additional webgl and il2cpp components
+    - unity-downloader-cli -u {{ editor }} -c Editor -c webgl -c il2cpp --wait # Downloading the editor with additional webgl and il2cpp components
 
     # The following step builds the player with defined options such as:
     # Suite parameter if defined since it's a mandatory field to define which test suite should be used, but it doesn't matter in this case since we won't run any tests (--suite)