Additional fixes

Author: EmandM

Examples/CharacterControllerMovingBodies/Assets/Scripts/MoverScriptNoRigidbody.cs

@@ -136,8 +136,7 @@ protected override void OnNetworkPreSpawn(ref NetworkManager networkManager)
 
     /// <summary>
     /// We are using post spawn to handle any final spawn initializations.
-    /// At this point we know all NetworkBehaviours on this instance has 
-    /// been spawned.
+    /// At this point we know all NetworkBehaviours on this instance have been spawned.
     /// </summary>
     protected override void OnNetworkPostSpawn()
     {
@@ -173,8 +172,7 @@ public override void OnNetworkDespawn()
         {
             m_CharacterController.enabled = false;
             Camera.main.transform.SetParent(null, false);
-            Camera.main.transform.position = m_CameraOriginalPosition;
-            Camera.main.transform.rotation = m_CameraOriginalRotation;
+            Camera.main.transform.SetPositionAndRotation(m_CameraOriginalPosition, m_CameraOriginalRotation);
         }
         base.OnNetworkDespawn();
     }

Examples/OverridingScenesAndPrefabs/Assets/Scripts/MoverScriptNoRigidbody.cs

@@ -5,7 +5,7 @@
 using Random = UnityEngine.Random;
 using Debug = UnityEngine.Debug;
 
-#region MoverScriptNoRigidbody Custom Editor 
+#region MoverScriptNoRigidbody Custom Editor
 #if UNITY_EDITOR
 using Unity.Netcode.Editor;
 using UnityEditor;
@@ -144,8 +144,7 @@ protected override void OnNetworkPreSpawn(ref NetworkManager networkManager)
 
     /// <summary>
     /// We are using post spawn to handle any final spawn initializations.
-    /// At this point we know all NetworkBehaviours on this instance has 
-    /// been spawned.
+    /// At this point we know all NetworkBehaviours on this instance have been spawned.
     /// </summary>
     protected override void OnNetworkPostSpawn()
     {
@@ -182,14 +181,13 @@ protected override void OnNetworkPostSpawn()
 
     public override void OnNetworkDespawn()
     {
-        // Notify any client or server specific componant that this instance has despawned.
+        // Notify any client or server specific component that this instance has despawned.
         NotifySpawnStatusChanged?.Invoke(false);
         if (IsLocalPlayer)
         {
             m_CharacterController.enabled = false;
             Camera.main.transform.SetParent(null, false);
-            Camera.main.transform.position = m_CameraOriginalPosition;
-            Camera.main.transform.rotation = m_CameraOriginalRotation;
+            Camera.main.transform.SetPositionAndRotation(m_CameraOriginalPosition, m_CameraOriginalRotation);
         }
         base.OnNetworkDespawn();
     }

Examples/OverridingScenesAndPrefabs/Assets/Scripts/NetworkManagerBootstrapper.cs

@@ -415,8 +415,7 @@ private void SetCameraDefaults()
         if (Camera.main != null && Camera.main.transform.parent != null)
         {
             Camera.main.transform.SetParent(null, false);
-            Camera.main.transform.position = m_CameraOriginalPosition;
-            Camera.main.transform.rotation = m_CameraOriginalRotation;
+            Camera.main.transform.SetPositionAndRotation(m_CameraOriginalPosition, m_CameraOriginalRotation);
         }
     }
 
@@ -522,7 +521,7 @@ private void StartDedicatedServer()
 
     /// <summary>
     /// Register callbacks when the OnServerStarted callback is invoked.
-    /// This makes it easier to know you are registering for events only 
+    /// This makes it easier to know you are registering for events only
     /// when the server successfully has started.
     /// </summary>
     private void ServerStarted()
@@ -578,11 +577,11 @@ private void HandleEditorKeyCommands()
 #else
     private void HandleConsoleKeyCommands()
     {
-        if (Console.KeyAvailable) 
+        if (Console.KeyAvailable)
         {
             var networkManager = NetworkManager.Singleton;
             var keyPressed = Console.ReadKey(true);
-            switch(keyPressed.Key) 
+            switch(keyPressed.Key)
             {
                 case ConsoleKey.X:
                     {

Examples/OverridingScenesAndPrefabs/Assets/Scripts/NetworkPrefabOverrideHandler.cs

@@ -45,8 +45,7 @@ public NetworkObject Instantiate(ulong ownerClientId, Vector3 position, Quaterni
         var gameObject = m_NetworkManager.IsClient ? Instantiate(NetworkPrefabOverride) : Instantiate(NetworkPrefab);
         // You could integrate spawn locations here and on the server side apply the spawn position at
         // this stage of the spawn process.
-        gameObject.transform.position = position;
-        gameObject.transform.rotation = rotation;
+        gameObject.transform.SetPositionAndRotation(position, rotation);
         return gameObject.GetComponent<NetworkObject>();
     }
 
@@ -64,4 +63,3 @@ public void Destroy(NetworkObject networkObject)
         Destroy(networkObject.gameObject);
     }
 }
-

com.unity.netcode.gameobjects/Documentation~/basics/object-spawning.md

@@ -153,8 +153,7 @@ This type of dynamically spawned `NetworkObject` typically is a simple wrapper c
             m_prefabInstance = Instantiate(prefabToSpawn);
 
             // Optional, this example applies the spawner's position and rotation to the new instance
-            m_prefabInstance.transform.position = transform.position;
-            m_prefabInstance.transform.rotation = transform.rotation;
+            m_prefabInstance.transform.SetPositionAndRotation(transform.position, transform.rotation);
 
             // Get the instance's NetworkObject and Spawn
             m_SpawnedNetworkObject = m_prefabInstance.GetComponent<NetworkObject>();
@@ -233,8 +232,7 @@ public class SinglePooledDynamicSpawner : NetworkBehaviour, INetworkprefabInstan
     public NetworkObject Instantiate(ulong ownerClientId, Vector3 position, Quaternion rotation)
     {
         m_prefabInstance.SetActive(true);
-        m_prefabInstance.transform.position = transform.position;
-        m_prefabInstance.transform.rotation = transform.rotation;
+        m_prefabInstance.transform.position.SetPositionAndRotation(transform.position, transform.rotation);
         return m_SpawnedNetworkObject;
     }
 

com.unity.netcode.gameobjects/Runtime/Components/AnticipatedNetworkTransform.cs

@@ -277,9 +277,8 @@ private void ProcessSmoothing()
                 m_PreviousAnticipatedTransform = m_AnticipatedTransform;
                 if (!CanCommitToTransform)
                 {
-                    transform_.position = m_AnticipatedTransform.Position;
+                    transform_.SetPositionAndRotation(m_AnticipatedTransform.Position, m_AnticipatedTransform.Rotation);
                     transform_.localScale = m_AnticipatedTransform.Scale;
-                    transform_.rotation = m_AnticipatedTransform.Rotation;
                 }
             }
         }
@@ -549,18 +548,16 @@ protected override void OnTransformUpdated()
             if (!m_OutstandingAuthorityChange)
             {
                 // Keep the anticipated value unchanged, we have no updates from the server at all.
-                transform_.position = previousAnticipatedTransform.Position;
+                transform_.SetPositionAndRotation(previousAnticipatedTransform.Position, previousAnticipatedTransform.Rotation);
                 transform_.localScale = previousAnticipatedTransform.Scale;
-                transform_.rotation = previousAnticipatedTransform.Rotation;
                 return;
             }
 
             if (StaleDataHandling == StaleDataHandling.Ignore && m_LastAnticipaionCounter > m_LastAuthorityUpdateCounter)
             {
                 // Keep the anticipated value unchanged because it is more recent than the authoritative one.
-                transform_.position = previousAnticipatedTransform.Position;
+                transform_.SetPositionAndRotation(previousAnticipatedTransform.Position, previousAnticipatedTransform.Rotation);
                 transform_.localScale = previousAnticipatedTransform.Scale;
-                transform_.rotation = previousAnticipatedTransform.Rotation;
                 return;
             }
 

com.unity.netcode.gameobjects/Tests/Runtime/Transports/UnityTransportConnectionTests.cs

@@ -5,7 +5,6 @@
 using NUnit.Framework;
 using Unity.Netcode.TestHelpers.Runtime;
 using Unity.Netcode.Transports.UTP;
-using Unity.Networking.Transport;
 using UnityEngine;
 using UnityEngine.TestTools;
 using static Unity.Netcode.RuntimeTests.UnityTransportTestHelpers;

testproject/Assets/Samples/PrefabPool/NetworkPrefabHandlerObjectPool.cs

@@ -71,8 +71,7 @@ public NetworkObject Instantiate(ulong ownerClientId, Vector3 position, Quaterni
     {
         var gameObject = GetNextSpawnObject();
         gameObject.SetActive(true);
-        gameObject.transform.position = position;
-        gameObject.transform.rotation = rotation;
+        gameObject.transform.SetPositionAndRotation(position, rotation);
         return gameObject.GetComponent<NetworkObject>();
     }
 

testproject/Assets/Samples/PrefabPool/NetworkPrefabHandlerObjectPoolOverride.cs

@@ -128,8 +128,7 @@ public NetworkObject Instantiate(ulong ownerClientId, Vector3 position, Quaterni
     {
         var gameObject = GetNextSpawnObject();
         gameObject.SetActive(true);
-        gameObject.transform.position = position;
-        gameObject.transform.rotation = rotation;
+        gameObject.transform.SetPositionAndRotation(position, rotation);
         return gameObject.GetComponent<NetworkObject>();
     }
 
@@ -180,4 +179,3 @@ private IEnumerator SpawnObjects()
         }
     }
 }
-

testproject/Assets/Tests/Manual/DeltaPositionNetworkTransform/LinearMotionHandler.cs

@@ -396,8 +396,8 @@ private void LateUpdate()
                 SetNextDirection();
             }
 
-            ClientPositionVisual.transform.position = m_ClientPosition;
-            ClientPositionVisual.transform.rotation = InLocalSpace ? transform.localRotation : transform.rotation;
+            var rotation = InLocalSpace ? transform.localRotation : transform.rotation;
+            ClientPositionVisual.transform.SetPositionAndRotation(m_ClientPosition, rotation);
         }
 
         private Vector3 m_ServerPosition;