Fix whitespace issues

Author: EmandM

com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs

@@ -28,15 +28,13 @@ public enum ConnectionEvent
         /// On the server side, the <see cref="ConnectionEventData.ClientId"/> will be the ID of the client that just connected.
         /// </remarks>
         ClientConnected,
-
         /// <summary>
         /// This event is set on clients that are already connected to the session.
         /// </summary>
         /// <remarks>
         /// The <see cref="ConnectionEventData.ClientId"/> will be the ID of the client that just connected.
         /// </remarks>
         PeerConnected,
-
         /// <summary>
         /// This event is set on the client-side of the client that disconnected client and on the server-side.
         /// </summary>
@@ -45,7 +43,6 @@ public enum ConnectionEvent
         /// On the server side, this will be the ID of the client that disconnected.
         /// </remarks>
         ClientDisconnected,
-
         /// <summary>
         /// This event is set on clients that are already connected to the session.
         /// </summary>
@@ -150,7 +147,7 @@ internal void InvokeOnClientConnectedCallback(ulong clientId)
                 return;
             }
 
-            // Invoking connection event on NonAuthority client. Need to calculate PeerIds.
+            // Invoking connection event on non-authority local client. Need to calculate PeerIds.
             var peerClientIds = new NativeArray<ulong>(Math.Max(NetworkManager.ConnectedClientsIds.Count - 1, 0), Allocator.Temp);
             // `using var peerClientIds` or `using(peerClientIds)` renders it immutable...
             using var sentinel = peerClientIds;
@@ -857,7 +854,6 @@ internal void HandleConnectionApproval(ulong ownerClientId, NetworkManager.Conne
                             };
                         }
                     }
-
                     if (!MockSkippingApproval)
                     {
                         SendMessage(ref message, NetworkDelivery.ReliableFragmentedSequenced, ownerClientId);
@@ -866,7 +862,6 @@ internal void HandleConnectionApproval(ulong ownerClientId, NetworkManager.Conne
                     {
                         NetworkLog.LogInfo("Mocking server not responding with connection approved...");
                     }
-
                     message.MessageVersions.Dispose();
                     message.ConnectedClientIds.Dispose();
                     if (MockSkippingApproval)
@@ -883,8 +878,8 @@ internal void HandleConnectionApproval(ulong ownerClientId, NetworkManager.Conne
                         {
                             InvokeOnPeerConnectedCallback(ownerClientId);
                         }
-
                         NetworkManager.SpawnManager.DistributeNetworkObjects(ownerClientId);
+
                     }
                     else // Otherwise, let NetworkSceneManager handle the initial scene and NetworkObject synchronization
                     {
@@ -927,7 +922,6 @@ internal void HandleConnectionApproval(ulong ownerClientId, NetworkManager.Conne
                 {
                     return;
                 }
-
                 // Separating this into a contained function call for potential further future separation of when this notification is sent.
                 ApprovedPlayerSpawn(ownerClientId, response.PlayerPrefabHash ?? NetworkManager.NetworkConfig.PlayerPrefab.GetComponent<NetworkObject>().GlobalObjectIdHash);
             }
@@ -942,7 +936,6 @@ internal void HandleConnectionApproval(ulong ownerClientId, NetworkManager.Conne
                     SendMessage(ref disconnectReason, NetworkDelivery.Reliable, ownerClientId);
                     MessageManager.ProcessSendQueues();
                 }
-
                 DisconnectRemoteClient(ownerClientId);
             }
         }
@@ -1017,14 +1010,12 @@ internal NetworkClient AddClient(ulong clientId)
             {
                 networkClient = new NetworkClient();
             }
-
             networkClient.SetRole(clientId == NetworkManager.ServerClientId, isClient: true, NetworkManager);
             networkClient.ClientId = clientId;
             if (!ConnectedClients.ContainsKey(clientId))
             {
                 ConnectedClients.Add(clientId, networkClient);
             }
-
             if (!ConnectedClientsList.Contains(networkClient))
             {
                 ConnectedClientsList.Add(networkClient);
@@ -1048,7 +1039,6 @@ internal NetworkClient AddClient(ulong clientId)
                     NetworkManager.MessageManager.SendMessage(ref message, NetworkDelivery.ReliableSequenced, NetworkManager.CurrentSessionOwner);
                 }
             }
-
             if (!ConnectedClientIds.Contains(clientId))
             {
                 ConnectedClientIds.Add(clientId);
@@ -1074,7 +1064,6 @@ internal NetworkClient AddClient(ulong clientId)
                     {
                         continue;
                     }
-
                     networkObject.Observers.Add(clientId);
                 }
             }
@@ -1092,7 +1081,6 @@ internal void RemoveClient(ulong clientId)
             {
                 ConnectedClientIds.Remove(clientId);
             }
-
             if (ConnectedClients.ContainsKey(clientId))
             {
                 ConnectedClientsList.Remove(ConnectedClients[clientId]);
@@ -1199,7 +1187,6 @@ internal void OnClientDisconnectFromServer(ulong clientId)
                                     // Don't destroy (prefab handler will determine this, but always notify
                                     NetworkManager.SpawnManager.DespawnObject(ownedObject, false, true);
                                 }
-
                                 NetworkManager.PrefabHandler.HandleNetworkPrefabDestroy(ownedObject);
                             }
                             else
@@ -1239,7 +1226,6 @@ internal void OnClientDisconnectFromServer(ulong clientId)
                                         break;
                                     }
                                 }
-
                                 if (EnableDistributeLogging)
                                 {
                                     Debug.Log($"[Disconnected][Client-{clientId}][NetworkObjectId-{ownedObject.NetworkObjectId} Distributed to Client-{targetOwner}");
@@ -1262,7 +1248,6 @@ internal void OnClientDisconnectFromServer(ulong clientId)
                                     {
                                         continue;
                                     }
-
                                     // If the client owner disconnected, it is ok to unlock this at this point in time.
                                     if (childObject.IsOwnershipLocked)
                                     {

testproject/Assets/Tests/Runtime/NetworkSceneManager/SceneManagementSynchronizationTests.cs

@@ -155,7 +155,7 @@ public IEnumerator SynchronizationCallbacks_NonAuthority()
             var peerClientId = GetNonAuthorityNetworkManager().LocalClientId;
             var expectedClientId = peerClientId + 1;
 
-            var expectedPeerClientIds = m_UseHost ? new[] { authorityId, peerClientId } : new[]{peerClientId};
+            var expectedPeerClientIds = m_UseHost ? new[] { authorityId, peerClientId } : new[] { peerClientId };
 
             // Setup expected events
             m_ExpectedEventQueue.Enqueue(new ExpectedEvent()