Skip to content

Commit 664c1d8

Browse files
committed
Ensure no empty space in job setup
1 parent 04d4751 commit 664c1d8

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

.yamato/desktop-standalone-tests.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,15 @@ desktop_standalone_test_{{ project.name }}_{{ platform.name }}_{{ backend }}_{{
7676
type: {% if platform.name == "mac" %} {{ platform.type }} {% else %} {{ platform.type }}::GPU {% endif %}
7777
image: {{ platform.image }}
7878
flavor: {{ platform.flavor }}
79+
80+
# Set additional variables for running the echo server
81+
{% if platform.name != "win" %}
7982
variables:
8083
ECHO_SERVER_PORT: "7788"
81-
# Ensure the DA codec tests will fail if they cannot connect to the echo-server
84+
# Set this to ensure the DA codec tests will fail if they cannot connect to the echo-server
8285
# The default is to ignore the codec tests if the echo-server fails to connect
83-
ENSURE_CODEC_TESTS: {% if platform.name != "win" %} "true" {% else %} "" {% endif %}
86+
ENSURE_CODEC_TESTS: "true"
87+
{% endif %}
8488

8589
commands:
8690
# Platform specific UTR setup

com.unity.netcode.gameobjects/Tests/Runtime/DistributedAuthority/DistributedAuthorityCodecTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,13 @@ protected override void OnOneTimeSetup()
7979
if (!CanConnectToServer(m_TransportHost, k_TransportPort))
8080
{
8181
var shouldFail = Environment.GetEnvironmentVariable("ENSURE_CODEC_TESTS");
82-
if (!string.IsNullOrEmpty(shouldFail))
82+
if (string.IsNullOrEmpty(shouldFail) || shouldFail.ToLower == "false")
8383
{
84-
Assert.Fail($"Failed to connect to the rust echo-server at {m_TransportHost}:{k_TransportPort}");
84+
Assert.Ignore($"ignoring DA codec tests because UTP transport cannot connect to the rust echo-server at {m_TransportHost}:{k_TransportPort}");
8585
}
8686
else
8787
{
88-
Assert.Ignore($"ignoring DA codec tests because UTP transport cannot connect to the rust echo-server at {m_TransportHost}:{k_TransportPort}");
88+
Assert.Fail($"Failed to connect to the rust echo-server at {m_TransportHost}:{k_TransportPort}");
8989
}
9090
}
9191
#endif

0 commit comments

Comments
 (0)