@@ -152,7 +152,7 @@ private IEnumerator CheckVisible(bool isVisible)
152
152
int count = 0 ;
153
153
do
154
154
{
155
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 5 ) ;
155
+ yield return WaitForTicks ( m_ServerNetworkManager , 5 ) ;
156
156
count ++ ;
157
157
158
158
if ( count > 20 )
@@ -268,11 +268,11 @@ public IEnumerator NetworkShowHideTest()
268
268
// hide them on one client
269
269
Show ( mode == 0 , false ) ;
270
270
271
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 5 ) ;
271
+ yield return WaitForTicks ( m_ServerNetworkManager , 5 ) ;
272
272
273
273
m_NetSpawnedObject1 . GetComponent < ShowHideObject > ( ) . MyNetworkVariable . Value = 3 ;
274
274
275
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 5 ) ;
275
+ yield return WaitForTicks ( m_ServerNetworkManager , 5 ) ;
276
276
277
277
// verify they got hidden
278
278
yield return CheckVisible ( false ) ;
@@ -314,10 +314,10 @@ public IEnumerator NetworkShowHideQuickTest()
314
314
Show ( mode == 0 , false ) ;
315
315
Show ( mode == 0 , true ) ;
316
316
317
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 5 ) ;
317
+ yield return WaitForTicks ( m_ServerNetworkManager , 5 ) ;
318
318
yield return WaitForConditionOrTimeOut ( RefreshNetworkObjects ) ;
319
319
AssertOnTimeout ( $ "Could not refresh all NetworkObjects!") ;
320
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 5 ) ;
320
+ yield return WaitForTicks ( m_ServerNetworkManager , 5 ) ;
321
321
322
322
// verify they become visible
323
323
yield return CheckVisible ( true ) ;
@@ -343,7 +343,7 @@ public IEnumerator NetworkHideDespawnTest()
343
343
m_NetSpawnedObject1 . NetworkHide ( m_ClientId0 ) ;
344
344
m_NetSpawnedObject1 . Despawn ( ) ;
345
345
346
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 5 ) ;
346
+ yield return WaitForTicks ( m_ServerNetworkManager , 5 ) ;
347
347
348
348
LogAssert . NoUnexpectedReceived ( ) ;
349
349
}
@@ -400,7 +400,7 @@ public IEnumerator NetworkHideChangeOwnershipNotHidden()
400
400
m_NetSpawnedObject1 . GetComponent < ShowHideObject > ( ) . MyOwnerReadNetworkVariable . Value ++ ;
401
401
402
402
// wait for three ticks
403
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
403
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
404
404
405
405
// check we'll actually be changing owners
406
406
Assert . False ( ShowHideObject . ClientTargetedNetworkObjects [ 0 ] . OwnerClientId == m_ClientNetworkManagers [ 0 ] . LocalClientId ) ;
@@ -412,8 +412,8 @@ public IEnumerator NetworkHideChangeOwnershipNotHidden()
412
412
m_NetSpawnedObject1 . ChangeOwnership ( m_ClientNetworkManagers [ 0 ] . LocalClientId ) ;
413
413
414
414
// wait three ticks
415
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
416
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
415
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
416
+ yield return WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
417
417
418
418
// verify ownership changed
419
419
Assert . True ( ShowHideObject . ClientTargetedNetworkObjects [ 0 ] . OwnerClientId == m_ClientNetworkManagers [ 0 ] . LocalClientId ) ;
@@ -461,64 +461,64 @@ private IEnumerator HideThenShowAndHideThenModifyAndShow()
461
461
Debug . Log ( "Hiding" ) ;
462
462
// hide
463
463
m_NetSpawnedObject1 . NetworkHide ( 1 ) ;
464
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
465
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
464
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
465
+ yield return WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
466
466
467
467
Debug . Log ( "Showing and Hiding" ) ;
468
468
// show and hide
469
469
m_NetSpawnedObject1 . NetworkShow ( 1 ) ;
470
470
m_NetSpawnedObject1 . NetworkHide ( 1 ) ;
471
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
472
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
471
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
472
+ yield return WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
473
473
474
474
Debug . Log ( "Modifying and Showing" ) ;
475
475
// modify and show
476
476
m_NetSpawnedObject1 . GetComponent < ShowHideObject > ( ) . MyList . Add ( 5 ) ;
477
477
m_NetSpawnedObject1 . NetworkShow ( 1 ) ;
478
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
479
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
478
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
479
+ yield return WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
480
480
}
481
481
482
482
483
483
private IEnumerator HideThenModifyAndShow ( )
484
484
{
485
485
// hide
486
486
m_NetSpawnedObject1 . NetworkHide ( 1 ) ;
487
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
487
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
488
488
489
489
// modify
490
490
m_NetSpawnedObject1 . GetComponent < ShowHideObject > ( ) . MyList . Add ( 5 ) ;
491
491
// show
492
492
m_NetSpawnedObject1 . NetworkShow ( 1 ) ;
493
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
494
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
493
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
494
+ yield return WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
495
495
496
496
}
497
497
498
498
private IEnumerator HideThenShowAndModify ( )
499
499
{
500
500
// hide
501
501
m_NetSpawnedObject1 . NetworkHide ( 1 ) ;
502
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
502
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
503
503
504
504
// show
505
505
m_NetSpawnedObject1 . NetworkShow ( 1 ) ;
506
506
// modify
507
507
m_NetSpawnedObject1 . GetComponent < ShowHideObject > ( ) . MyList . Add ( 5 ) ;
508
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
509
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
508
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
509
+ yield return WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
510
510
}
511
511
512
512
private IEnumerator HideThenShowAndRPC ( )
513
513
{
514
514
// hide
515
515
m_NetSpawnedObject1 . NetworkHide ( 1 ) ;
516
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
516
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
517
517
518
518
// show
519
519
m_NetSpawnedObject1 . NetworkShow ( 1 ) ;
520
520
m_NetSpawnedObject1 . GetComponent < ShowHideObject > ( ) . TriggerRpc ( ) ;
521
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
521
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
522
522
}
523
523
524
524
[ UnityTest ]
@@ -540,8 +540,8 @@ public IEnumerator NetworkShowHideAroundListModify()
540
540
for ( int i = 0 ; i < 4 ; i ++ )
541
541
{
542
542
// wait for three ticks
543
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ServerNetworkManager , 3 ) ;
544
- yield return NetcodeIntegrationTestHelpers . WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
543
+ yield return WaitForTicks ( m_ServerNetworkManager , 3 ) ;
544
+ yield return WaitForTicks ( m_ClientNetworkManagers [ 0 ] , 3 ) ;
545
545
546
546
switch ( i )
547
547
{
@@ -561,7 +561,9 @@ public IEnumerator NetworkShowHideAroundListModify()
561
561
Debug . Log ( "Running HideThenShowAndRPC" ) ;
562
562
ShowHideObject . ClientIdsRpcCalledOn = new List < ulong > ( ) ;
563
563
yield return HideThenShowAndRPC ( ) ;
564
- Debug . Assert ( ShowHideObject . ClientIdsRpcCalledOn . Count == NumberOfClients + 1 ) ;
564
+ // Provide enough time for slower systems or VM systems possibly under a heavy load could fail on this test
565
+ yield return WaitForConditionOrTimeOut ( ( ) => ShowHideObject . ClientIdsRpcCalledOn . Count == NumberOfClients + 1 ) ;
566
+ AssertOnTimeout ( $ "Timed out waiting for ClientIdsRpcCalledOn.Count ({ ShowHideObject . ClientIdsRpcCalledOn . Count } ) to equal ({ NumberOfClients + 1 } )!") ;
565
567
break ;
566
568
567
569
}
0 commit comments