Fix NetworkVariables sometimes dropping changes

khyperia · NoelStephensUnity · commit 67b1015dd7d0 · 2025-05-28T13:08:12.000-05:00
diff --git a/com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs b/com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs
@@ -1094,8 +1094,8 @@ internal void NetworkVariableUpdate(ulong targetClientId, bool forceSend = false
                         if (networkVariable.CanSend())
                         {
                             shouldSend = true;
+                            break;
                         }
-                        break;
                     }
                 }
                 // All of this is just to prevent the DA Host from re-sending a NetworkVariable update it received from the client owner

Original file line number	Diff line number	Diff line change
`@@ -1094,8 +1094,8 @@ internal void NetworkVariableUpdate(ulong targetClientId, bool forceSend = false`
`1094`	`1094`	`if (networkVariable.CanSend())`
`1095`	`1095`	`{`
`1096`	`1096`	`shouldSend = true;`
	`1097`	`+ break;`
`1097`	`1098`	`}`
`1098`		`- break;`
`1099`	`1099`	`}`
`1100`	`1100`	`}`
`1101`	`1101`	`// All of this is just to prevent the DA Host from re-sending a NetworkVariable update it received from the client owner`