Skip to content

Commit 6d7c00e

Browse files
fix: NetcodeIntegrationTest remove extra OnNewClientCreated call (#2005)
1 parent 9199f82 commit 6d7c00e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

com.unity.netcode.gameobjects/TestHelpers/Runtime/NetcodeIntegrationTest.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,9 @@ protected IEnumerator CreateAndStartNewClient()
288288
{
289289
var networkManager = NetcodeIntegrationTestHelpers.CreateNewClient(m_ClientNetworkManagers.Length);
290290
networkManager.NetworkConfig.PlayerPrefab = m_PlayerPrefab;
291+
292+
// Notification that the new client (NetworkManager) has been created
293+
// in the event any modifications need to be made before starting the client
291294
OnNewClientCreated(networkManager);
292295

293296
NetcodeIntegrationTestHelpers.StartOneClient(networkManager);
@@ -302,7 +305,6 @@ protected IEnumerator CreateAndStartNewClient()
302305
AssertOnTimeout($"{nameof(CreateAndStartNewClient)} timed out waiting for the new client to be connected!");
303306
ClientNetworkManagerPostStart(networkManager);
304307
VerboseDebug($"[{networkManager.name}] Created and connected!");
305-
OnNewClientCreated(networkManager);
306308
}
307309

308310
protected IEnumerator StopOneClient(NetworkManager networkManager, bool destroy = false)

0 commit comments

Comments
 (0)