Fixed return type checks for RPC

TwoTenPvP · TwoTenPvP · commit 6e667cc9d597 · 2019-01-31T13:55:48.000+01:00
diff --git a/MLAPI/MonoBehaviours/Core/NetworkedBehaviour.cs b/MLAPI/MonoBehaviours/Core/NetworkedBehaviour.cs
@@ -571,7 +571,7 @@ private void CacheAttributes()
                     }
                     else
                     {
-                        if (methods[i].ReturnType != typeof(void) && methods[i].ReturnType.GetGenericTypeDefinition() != typeof(RpcResponse<>))
+                        if (methods[i].ReturnType != typeof(void) && !SerializationHelper.IsTypeSupported(methods[i].ReturnType))
                         {
                             if (LogHelper.CurrentLogLevel <= LogLevel.Error) LogHelper.LogWarning("Invalid return type of RPC. Has to be either void or RpcResponse<T> with a serializable type");
                         }
@@ -608,7 +608,7 @@ private void CacheAttributes()
                     }
                     else
                     {
-                        if (methods[i].ReturnType != typeof(void) && methods[i].ReturnType.GetGenericTypeDefinition() != typeof(RpcResponse<>))
+                        if (methods[i].ReturnType != typeof(void) && !SerializationHelper.IsTypeSupported(methods[i].ReturnType))
                         {
                             if (LogHelper.CurrentLogLevel <= LogLevel.Error) LogHelper.LogWarning("Invalid return type of RPC. Has to be either void or RpcResponse<T> with a serializable type");
                         }

Original file line number	Diff line number	Diff line change
`@@ -571,7 +571,7 @@ private void CacheAttributes()`
`571`	`571`	`}`
`572`	`572`	`else`
`573`	`573`	`{`
`574`		`- if (methods[i].ReturnType != typeof(void) && methods[i].ReturnType.GetGenericTypeDefinition() != typeof(RpcResponse<>))`
	`574`	`+ if (methods[i].ReturnType != typeof(void) && !SerializationHelper.IsTypeSupported(methods[i].ReturnType))`
`575`	`575`	`{`
`576`	`576`	`if (LogHelper.CurrentLogLevel <= LogLevel.Error) LogHelper.LogWarning("Invalid return type of RPC. Has to be either void or RpcResponse<T> with a serializable type");`
`577`	`577`	`}`
`@@ -608,7 +608,7 @@ private void CacheAttributes()`
`608`	`608`	`}`
`609`	`609`	`else`
`610`	`610`	`{`
`611`		`- if (methods[i].ReturnType != typeof(void) && methods[i].ReturnType.GetGenericTypeDefinition() != typeof(RpcResponse<>))`
	`611`	`+ if (methods[i].ReturnType != typeof(void) && !SerializationHelper.IsTypeSupported(methods[i].ReturnType))`
`612`	`612`	`{`
`613`	`613`	`if (LogHelper.CurrentLogLevel <= LogLevel.Error) LogHelper.LogWarning("Invalid return type of RPC. Has to be either void or RpcResponse<T> with a serializable type");`
`614`	`614`	`}`