refactor: remove animation, physics and physics2d dependencies (#1812)

Author: 0xFA11

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -14,6 +14,10 @@ Additional documentation and release notes are available at [Multiplayer Documen
 
 ### Changed
 
+### Removed
+
+- Removed `com.unity.modules.animation`, `com.unity.modules.physics` and `com.unity.modules.physics2d` dependencies from the package (#1812)
+
 ### Fixed
 
 - Fixed user never being notified in the editor that a NetworkBehaviour requires a NetworkObject to function properly. (#1808)

com.unity.netcode.gameobjects/Components/NetworkAnimator.cs

@@ -1,3 +1,4 @@
+#if COM_UNITY_MODULES_ANIMATION
 using Unity.Collections;
 using Unity.Collections.LowLevel.Unsafe;
 using UnityEngine;
@@ -427,3 +428,4 @@ public void ResetTrigger(int hash)
         }
     }
 }
+#endif // COM_UNITY_MODULES_ANIMATION

com.unity.netcode.gameobjects/Components/NetworkRigidbody.cs

@@ -1,3 +1,4 @@
+#if COM_UNITY_MODULES_PHYSICS
 using UnityEngine;
 
 namespace Unity.Netcode.Components
@@ -78,3 +79,4 @@ public override void OnNetworkDespawn()
         }
     }
 }
+#endif // COM_UNITY_MODULES_PHYSICS

com.unity.netcode.gameobjects/Components/NetworkRigidbody2D.cs

@@ -1,3 +1,4 @@
+#if COM_UNITY_MODULES_PHYSICS2D
 using UnityEngine;
 
 namespace Unity.Netcode.Components
@@ -78,3 +79,4 @@ public override void OnNetworkDespawn()
         }
     }
 }
+#endif // COM_UNITY_MODULES_PHYSICS2D

com.unity.netcode.gameobjects/Components/com.unity.netcode.components.asmdef

@@ -5,5 +5,22 @@
         "Unity.Netcode.Runtime",
         "Unity.Collections"
     ],
-    "allowUnsafeCode": true
+    "allowUnsafeCode": true,
+    "versionDefines": [
+        {
+            "name": "com.unity.modules.animation",
+            "expression": "",
+            "define": "COM_UNITY_MODULES_ANIMATION"
+        },
+        {
+            "name": "com.unity.modules.physics",
+            "expression": "",
+            "define": "COM_UNITY_MODULES_PHYSICS"
+        },
+        {
+            "name": "com.unity.modules.physics2d",
+            "expression": "",
+            "define": "COM_UNITY_MODULES_PHYSICS2D"
+        }
+    ]
 }

com.unity.netcode.gameobjects/Editor/NetworkTransformEditor.cs

@@ -112,19 +112,23 @@ public override void OnInspectorGUI()
             EditorGUILayout.PropertyField(m_InLocalSpaceProperty);
             EditorGUILayout.PropertyField(m_InterpolateProperty);
 
+#if COM_UNITY_MODULES_PHYSICS
             // if rigidbody is present but network rigidbody is not present
             var go = ((NetworkTransform)target).gameObject;
             if (go.TryGetComponent<Rigidbody>(out _) && go.TryGetComponent<NetworkRigidbody>(out _) == false)
             {
                 EditorGUILayout.HelpBox("This GameObject contains a Rigidbody but no NetworkRigidbody.\n" +
                     "Add a NetworkRigidbody component to improve Rigidbody synchronization.", MessageType.Warning);
             }
+#endif // COM_UNITY_MODULES_PHYSICS
 
+#if COM_UNITY_MODULES_PHYSICS2D
             if (go.TryGetComponent<Rigidbody2D>(out _) && go.TryGetComponent<NetworkRigidbody2D>(out _) == false)
             {
                 EditorGUILayout.HelpBox("This GameObject contains a Rigidbody2D but no NetworkRigidbody2D.\n" +
                     "Add a NetworkRigidbody2D component to improve Rigidbody2D synchronization.", MessageType.Warning);
             }
+#endif // COM_UNITY_MODULES_PHYSICS2D
 
             serializedObject.ApplyModifiedProperties();
         }

com.unity.netcode.gameobjects/Tests/Runtime/NetworkAnimator/NetworkAnimatorTests.cs

@@ -1,3 +1,4 @@
+#if COM_UNITY_MODULES_ANIMATION
 using System.Collections;
 using System.Collections.Generic;
 using NUnit.Framework;
@@ -235,3 +236,4 @@ public IEnumerator AnimationStateSyncTestWithOverride()
         }
     }
 }
+#endif // COM_UNITY_MODULES_ANIMATION

com.unity.netcode.gameobjects/Tests/Runtime/Physics/NetworkRigidbody2DTest.cs

@@ -1,3 +1,4 @@
+#if COM_UNITY_MODULES_PHYSICS2D
 using System.Collections;
 using NUnit.Framework;
 using Unity.Netcode.Components;
@@ -76,3 +77,4 @@ public IEnumerator TestRigidbodyKinematicEnableDisable()
         }
     }
 }
+#endif // COM_UNITY_MODULES_PHYSICS2D

com.unity.netcode.gameobjects/Tests/Runtime/Physics/NetworkRigidbodyTest.cs

@@ -1,3 +1,4 @@
+#if COM_UNITY_MODULES_PHYSICS
 using System.Collections;
 using NUnit.Framework;
 using Unity.Netcode.Components;
@@ -75,3 +76,4 @@ public IEnumerator TestRigidbodyKinematicEnableDisable()
         }
     }
 }
+#endif // COM_UNITY_MODULES_PHYSICS

com.unity.netcode.gameobjects/package.json

@@ -5,9 +5,6 @@
     "version": "1.0.0-pre.6",
     "unity": "2020.3",
     "dependencies": {
-        "com.unity.modules.animation": "1.0.0",
-        "com.unity.modules.physics": "1.0.0",
-        "com.unity.modules.physics2d": "1.0.0",
         "com.unity.nuget.mono-cecil": "1.10.1",
         "com.unity.collections": "1.1.0"
     }