Add tests

Author: EmandM

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -1468,17 +1468,17 @@ private void HostServerInitialize()
         }
 
         /// <summary>
-        /// Get the transportId from the associated clientId.
+        /// Get the TransportId from the associated ClientId.
         /// </summary>
         /// <param name="clientId">The ClientId to get the TransportId from</param>
-        /// <returns></returns>
+        /// <returns>The TransportId associated with the given ClientId</returns>
         public ulong GetTransportIdFromClientId(ulong clientId) => ConnectionManager.ClientIdToTransportId(clientId);
 
         /// <summary>
-        /// Get the clientId from the associated transportId.
+        /// Get the ClientId from the associated TransportId.
         /// </summary>
-        /// <param name="clientId">The TransportId to get the ClientId from</param>
-        /// <returns></returns>
+        /// <param name="transportId">The TransportId to get the ClientId from</param>
+        /// <returns>The ClientId from the associated TransportId</returns>
         public ulong GetClientIdFromTransportId(ulong transportId) => ConnectionManager.TransportIdToClientId(transportId);
 
         /// <summary>

testproject/Assets/Tests/Runtime/NetworkManagerTests.cs

@@ -9,9 +9,28 @@
 
 namespace TestProject.RuntimeTests
 {
+    public class NetworkManagerTests : NetcodeIntegrationTest
+    {
+        protected override int NumberOfClients => 2;
+
+        [Test]
+        public void ValidateTransportAndClientIds()
+        {
+            var transportId = m_ServerNetworkManager.GetTransportIdFromClientId(m_ServerNetworkManager.LocalClientId);
+            Assert.IsTrue(m_ServerNetworkManager.GetTransportIdFromClientId(m_ServerNetworkManager.LocalClientId) == m_ServerNetworkManager.ConnectionManager.ServerTransportId);
+            Assert.IsTrue(m_ServerNetworkManager.GetClientIdFromTransportId(transportId) == m_ServerNetworkManager.LocalClientId);
+
+            foreach (var client in m_ClientNetworkManagers)
+            {
+                transportId = m_ServerNetworkManager.GetTransportIdFromClientId(client.LocalClientId);
+                Assert.AreEqual(client.LocalClientId, m_ServerNetworkManager.GetClientIdFromTransportId(transportId), "Server and client transport IDs don't match.");
+            }
+        }
+    }
+
     [TestFixture(UseSceneManagement.SceneManagementDisabled)]
     [TestFixture(UseSceneManagement.SceneManagementEnabled)]
-    public class NetworkManagerTests : NetcodeIntegrationTest
+    public class NetworkManagerSceneTests : NetcodeIntegrationTest
     {
         private const string k_SceneToLoad = "InSceneNetworkObject";
         protected override int NumberOfClients => 0;
@@ -33,7 +52,7 @@ public enum UseSceneManagement
 
         private bool m_UseSceneManagement;
 
-        public NetworkManagerTests(UseSceneManagement useSceneManagement)
+        public NetworkManagerSceneTests(UseSceneManagement useSceneManagement)
         {
             m_UseSceneManagement = useSceneManagement == UseSceneManagement.SceneManagementEnabled;
         }