fix: Fix object traversal assigning instanceIds to none scene objects (#629)

TwoTenPvP · mattwalsh-unity · web-flow · commit 79fbed13647a · 2021-03-16T13:13:59.000-07:00
* fix: Fix object traversal assigning instanceIds to none scene objects

* comment added

Co-authored-by: Matt Walsh &lt;matt.walsh@unity3d.com&gt;
diff --git a/com.unity.multiplayer.mlapi/Editor/PostProcessScene.cs b/com.unity.multiplayer.mlapi/Editor/PostProcessScene.cs
@@ -11,7 +11,9 @@ public class NetworkScenePostProcess : MonoBehaviour
         [PostProcessScene(int.MaxValue)]
         public static void ProcessScene()
         {
-            var traverseSortedObjects = FindObjectsOfType<NetworkObject>().ToList();
+            // find all scene objects that have not been spawned yet
+            // TODO: long term, replace the means of finding candidate objects to repace FindObjectsOfType
+            var traverseSortedObjects = FindObjectsOfType<NetworkObject>().Where(x => x.IsSceneObject == null).ToList();
 
             traverseSortedObjects.Sort((x, y) =>
             {

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,9 @@ public class NetworkScenePostProcess : MonoBehaviour`
`11`	`11`	`[PostProcessScene(int.MaxValue)]`
`12`	`12`	`public static void ProcessScene()`
`13`	`13`	`{`
`14`		`- var traverseSortedObjects = FindObjectsOfType<NetworkObject>().ToList();`
	`14`	`+ // find all scene objects that have not been spawned yet`
	`15`	`+ // TODO: long term, replace the means of finding candidate objects to repace FindObjectsOfType`
	`16`	`+ var traverseSortedObjects = FindObjectsOfType<NetworkObject>().Where(x => x.IsSceneObject == null).ToList();`
`15`	`17`
`16`	`18`	`traverseSortedObjects.Sort((x, y) =>`
`17`	`19`	`{`