Corrected PR trigger definition and added initial check as dependency of project pack job

Author: michalChrobot

.yamato/_run-all.yml

@@ -15,8 +15,6 @@
 run_quick_checks:
   name: Run Quick Initial Checks
   dependencies:
-    - .yamato/package-pack.yml#package_pack_-_ngo_win
-    - .yamato/package-pack.yml#package_pack_-_ngo_mac
     - .yamato/package-pack.yml#package_pack_-_ngo_ubuntu
     - .yamato/project-standards.yml#standards_win_testproject_trunk
 

.yamato/_triggers.yml

@@ -38,31 +38,13 @@
 
 #-----------------------------------------------------------------------------------
 
-initial_pull_request_trigger:
-  name: (INITIAL) Pull Request Trigger (develop, develop-2.0.0, & release branches)
-  dependencies:
-    # Run fast checks that allow for detection of the simplest issues
-    - .yamato/_run-all.yml#run_quick_checks
-  triggers:
-    cancel_old_ci: true
-    pull_requests:
-      - targets:
-          only:
-            - "develop"
-            - "develop-2.0.0"
-            - "/release\/.*/"
-      - drafts: false
-
 # Run all relevant tasks when a pull request targeting the develop or release branch is created or updated.
 # In order to have better coverage we run desktop standalone tests with different configurations which allows to mostly cover for different platforms, scripting backends and editor versions.
-# This job will FIRST run "run_quick_checks" jobs (defined in _run-all.yml) which runs the fastest checks (like PVP or code standards) and ONLY IF those pass it will run the rest of the tests.
+# This job will FIRST run "run_quick_checks" jobs (defined in _run-all.yml) since it's the dependency of project pack jobs which is on the lowest dependency tier. This runs the fastest checks (like PVP or code standards) and ONLY IF those pass it will run the rest of the tests.
 # This optimization allows to speed up feedback look for any "obvious" errors and save resources.
-# THIS JOB WILL NOT RUN IF THE INITIAL JOB FAILS (the one above. For example if the code standards fail)
-extended_pull_request_trigger:
+pull_request_trigger:
   name: Pull Request Trigger (develop, develop-2.0.0, & release branches)
   dependencies:
-    # Run fast checks that allow for detection of the simplest issues (Needs to be included as dependency to make the expression at the bottom of this job possible)
-    - .yamato/_triggers.yml#initial_pull_request_trigger
     # Run project standards to verify package/default project. This is fine to just run for trunk
     - .yamato/project-standards.yml#standards_ubuntu_testproject_trunk
     # Run package EditMode and Playmode package tests on trunk
@@ -78,7 +60,13 @@ extended_pull_request_trigger:
     - .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_win_mono_6000.0
   triggers:
     cancel_old_ci: true
-    expression: pull_request.dependencies.initial_pull_request_trigger.status == "success"
+    pull_requests:
+      - targets:
+          only:
+            - "develop"
+            - "develop-2.0.0"
+            - "/release\/.*/"
+      - drafts: false
 
 
 # Run all tests on trunk on nightly basis.

.yamato/project-pack.yml

@@ -35,6 +35,8 @@ project_pack_-_{{ project.name }}_{{ platform.name }}:
   commands:
     - npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm # upm-ci is not preinstalled on the image so we need to download it
     - upm-ci project pack --project-path {{ project.path }}
+  dependencies:
+    - .yamato/_run-all.yml#run_quick_checks
   artifacts:
     packages:
       paths: