Skip to content

Commit 92a6385

Browse files
update
Minor adjustments for when ENABLE_NGO_ANALYTICS_LOGGING is defined.
1 parent 2287c05 commit 92a6385

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

com.unity.netcode.gameobjects/Editor/Analytics/NetworkManagerAnalytics.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
#if UNITY_EDITOR
22
using System;
33
using System.Text;
4+
#if ENABLE_NGO_ANALYTICS_LOGGING
5+
using UnityEngine;
6+
#endif
47
using UnityEngine.Analytics;
58

69
namespace Unity.Netcode.Editor
@@ -32,7 +35,7 @@ public override string ToString()
3235
#if ENABLE_NGO_ANALYTICS_LOGGING
3336
internal void LogAnalytics(int sessionNumber)
3437
{
35-
Debug.Log($"{ToString()}");
38+
Debug.Log($"{nameof(NetworkManagerAnalytics)} Session-{sessionNumber}:\n {ToString()}");
3639
}
3740
#endif
3841
public bool Equals(NetworkManagerAnalytics other)

com.unity.netcode.gameobjects/Editor/NetworkManagerHelper.cs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
using Unity.Netcode.Editor.Configuration;
44
using UnityEditor;
55
using UnityEngine;
6+
#if ENABLE_NGO_ANALYTICS_LOGGING
7+
using UnityEngine.Analytics;
8+
#endif
69
using UnityEngine.SceneManagement;
710

811
namespace Unity.Netcode.Editor
@@ -242,14 +245,16 @@ public void UpdateAnalytics()
242245
{
243246
var networkManagerAnalytics = GetNetworkManagerAnalytics(NetworkManager.RecentSessions[i]);
244247

245-
#if ENABLE_NGO_ANALYTICS_LOGGING
246-
networkManagerAnalytics.LogAnalytics(NetworkManager.RecentSessions[i].SessionIndex);
247-
#endif
248+
248249
// If the previous session has no changes to the configuration then skip it (only unique configurations)
249250
if (previousAnalytics.Equals(networkManagerAnalytics))
250251
{
251252
continue;
252253
}
254+
255+
#if ENABLE_NGO_ANALYTICS_LOGGING
256+
networkManagerAnalytics.LogAnalytics(NetworkManager.RecentSessions[i].SessionIndex);
257+
#endif
253258
var result = EditorAnalytics.SendAnalytic(new NetworkManagerAnalyticsHandler(networkManagerAnalytics));
254259
#if ENABLE_NGO_ANALYTICS_LOGGING
255260
if (result != AnalyticsResult.Ok)

0 commit comments

Comments
 (0)