Skip to content

Commit 96cb8d8

Browse files
committed
150-1 PVP fixes
1 parent 7a95a10 commit 96cb8d8

File tree

4 files changed

+1
-10
lines changed

4 files changed

+1
-10
lines changed

com.unity.netcode.gameobjects/TestHelpers/Runtime/NetcodeIntegrationTestHelpers.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,6 @@ private static void SceneManagerValidationAndTestRunnerInitialization(NetworkMan
425425
/// <param name="server">The Server NetworkManager</param>
426426
/// <param name="clients">The Clients NetworkManager</param>
427427
/// <param name="callback">called immediately after server is started and before client(s) are started</param>
428-
/// <returns></returns>
429428
public static bool Start(bool host, NetworkManager server, NetworkManager[] clients, BeforeClientStartCallback callback = null)
430429
{
431430
if (s_IsStarted)

com.unity.netcode.gameobjects/Tests/Runtime/Components/BufferDataValidationComponent.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ private void Start()
5454
/// <summary>
5555
/// Returns back whether the test has completed the total number of iterations
5656
/// </summary>
57-
/// <returns></returns>
5857
public bool IsTestComplete()
5958
{
6059
if (m_CurrentBufferSize > MaximumBufferSize || TestFailed)

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariableBaseInitializesWhenPersisted.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -334,6 +334,7 @@ public void Initialize(NetworkManager networkManager)
334334
/// <summary>
335335
/// This validates that the instances persisted to the next test set and persisted
336336
/// between network sessions
337+
/// </summary>
337338
public bool ValidateInstanceSpawnCount(int minCount)
338339
{
339340
// First pass we should have no instances

pvpExceptions.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,6 @@
1010
"Failed to find a suitable OpenCL device, baking cannot use GPU lightmapper."
1111
]
1212
},
13-
"PVP-150-1": {
14-
"errors": [
15-
"Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: bool Start(bool, NetworkManager, NetworkManager[], BeforeClientStartCallback): empty <returns> tag",
16-
"Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: IEnumerator WaitForClientsConnected(NetworkManager[], ResultWrapper<bool>, float): XML is not well-formed: An identifier was expected",
17-
"Unity.Netcode.RuntimeTests.BufferDataValidationComponent: bool IsTestComplete(): empty <returns> tag",
18-
"Unity.Netcode.RuntimeTests.NetworkVariableBaseInitializesWhenPersisted.PrefabInstanceHandler: bool ValidateInstanceSpawnCount(int): XML is not well-formed: Expected an end tag for element 'summary'"
19-
]
20-
},
2113
"PVP-151-1": {
2214
"errors": [
2315
"Unity.Netcode.NetworkConfig: Prefabs: undocumented",

0 commit comments

Comments
 (0)