chore: fix minor typos in NetcodeIntegrationTest (#1767)

Author: 0xFA11

com.unity.netcode.gameobjects/TestHelpers/Runtime/NetcodeIntegrationTest.cs

@@ -11,12 +11,12 @@
 namespace Unity.Netcode.TestHelpers.Runtime
 {
     /// <summary>
-    /// The default Netcode For GameObjects integration test helper class
+    /// The default Netcode for GameObjects integration test helper class
     /// </summary>
     public abstract class NetcodeIntegrationTest
     {
-        static protected TimeoutHelper s_GloabalTimeoutHelper = new TimeoutHelper(4.0f);
-        static protected WaitForSeconds s_DefaultWaitForTick = new WaitForSeconds(1.0f / k_DefaultTickRate);
+        protected static TimeoutHelper s_GlobalTimeoutHelper = new TimeoutHelper(4.0f);
+        protected static WaitForSeconds s_DefaultWaitForTick = new WaitForSeconds(1.0f / k_DefaultTickRate);
 
         /// <summary>
         /// Registered list of all NetworkObjects spawned.
@@ -288,9 +288,9 @@ protected IEnumerator StartServerAndClients()
                 // Wait for all clients to connect
                 yield return WaitForClientsConnectedOrTimeOut();
 
-                Assert.False(s_GloabalTimeoutHelper.TimedOut, $"{nameof(StartServerAndClients)} timed out waiting for all clients to be connected!");
+                Assert.False(s_GlobalTimeoutHelper.TimedOut, $"{nameof(StartServerAndClients)} timed out waiting for all clients to be connected!");
 
-                if (s_GloabalTimeoutHelper.TimedOut)
+                if (s_GlobalTimeoutHelper.TimedOut)
                 {
                     yield return null;
                 }
@@ -534,7 +534,7 @@ public static IEnumerator WaitForConditionOrTimeOut(Func<bool> checkForCondition
             // If none is provided we use the default global time out helper
             if (timeOutHelper == null)
             {
-                timeOutHelper = s_GloabalTimeoutHelper;
+                timeOutHelper = s_GlobalTimeoutHelper;
             }
 
             // Start checking for a timeout
@@ -568,7 +568,7 @@ public static IEnumerator WaitForConditionOrTimeOut(IConditionalPredicate condit
             // If none is provided we use the default global time out helper
             if (timeOutHelper == null)
             {
-                timeOutHelper = s_GloabalTimeoutHelper;
+                timeOutHelper = s_GlobalTimeoutHelper;
             }
 
             conditionalPredicate.Started();

com.unity.netcode.gameobjects/Tests/Runtime/IntegrationTestExamples.cs

@@ -33,7 +33,7 @@ public IEnumerator MyFirstIntegationTest()
             Object.FindObjectsOfType<NetworkVisibilityComponent>().Where(
                 (c) => c.IsSpawned).Count() == 2);
 
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out waiting for instances " +
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out waiting for instances " +
                 "to be detected!");
         }
     }
@@ -68,7 +68,7 @@ public IEnumerator MyFirstIntegationTest()
             Object.FindObjectsOfType<NetworkVisibilityComponent>().Where(
                 (c) => c.IsSpawned).Count() == 2);
 
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out waiting for instances " +
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out waiting for instances " +
                 "to be detected!");
         }
     }
@@ -151,7 +151,7 @@ public IEnumerator TestRelativeNetworkObjects()
             var expected = m_NumberToSpawn * TotalClients;
             // Wait for all clients to have spawned all instances
             yield return WaitForConditionOrTimeOut(() => SpawnTest.TotalSpawned == expected);
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, $"Timed out waiting for all to " +
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, $"Timed out waiting for all to " +
                 $"spawn! Total Spawned: {SpawnTest.TotalSpawned}");
 
             var client1Relative = s_GlobalNetworkObjects[1].Values.Where((c) =>
@@ -177,7 +177,7 @@ public IEnumerator TestDespawnNetworkObjects()
             }
             // Wait for all clients to have spawned all instances
             yield return WaitForConditionOrTimeOut(() => SpawnTest.TotalSpawned == 0);
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, $"Timed out waiting for all to " +
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, $"Timed out waiting for all to " +
                 $"despawn! Total Spawned: {SpawnTest.TotalSpawned}");
         }
     }

com.unity.netcode.gameobjects/Tests/Runtime/Metrics/RttMetricsTests.cs

@@ -65,7 +65,7 @@ public IEnumerator TrackRttMetricServerToClient()
             }
 
             yield return WaitForConditionOrTimeOut(() => waitForMetricValues.MetricFound());
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, $"{nameof(TrackRttMetricServerToClient)} timed out waiting for metric to be found for {m_ClientCount} clients!");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, $"{nameof(TrackRttMetricServerToClient)} timed out waiting for metric to be found for {m_ClientCount} clients!");
 
             var rttValue = waitForMetricValues.AssertMetricValueHaveBeenFound();
             Assert.AreEqual(0f, rttValue);
@@ -87,7 +87,7 @@ public IEnumerator TrackRttMetricClientToServer()
             }
 
             yield return WaitForConditionOrTimeOut(() => clientGaugeMetricValues.Where((c) => c.MetricFound()).Count() == NumberOfClients);
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, $"{nameof(TrackRttMetricClientToServer)} timed out waiting for metric to be found for {m_ClientCount} clients!");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, $"{nameof(TrackRttMetricClientToServer)} timed out waiting for metric to be found for {m_ClientCount} clients!");
 
             foreach (var clientGaugeMetricValue in clientGaugeMetricValues)
             {

com.unity.netcode.gameobjects/Tests/Runtime/NetworkAnimator/NetworkAnimatorTests.cs

@@ -85,10 +85,10 @@ public IEnumerator AnimationTriggerReset([Values(true, false)] bool asHash)
 
             // verify trigger is set for client and server
             yield return WaitForConditionOrTimeOut(() => asHash ? m_PlayerOnServerAnimator.GetBool(triggerHash) : m_PlayerOnServerAnimator.GetBool(triggerString));
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out on server trigger set check");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out on server trigger set check");
 
             yield return WaitForConditionOrTimeOut(() => asHash ? m_PlayerOnClientAnimator.GetBool(triggerHash) : m_PlayerOnClientAnimator.GetBool(triggerString));
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out on client trigger set check");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out on client trigger set check");
 
             // reset the trigger
             if (asHash)
@@ -102,10 +102,10 @@ public IEnumerator AnimationTriggerReset([Values(true, false)] bool asHash)
 
             // verify trigger is reset for client and server
             yield return WaitForConditionOrTimeOut(() => asHash ? m_PlayerOnServerAnimator.GetBool(triggerHash) == false : m_PlayerOnServerAnimator.GetBool(triggerString) == false);
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out on server reset check");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out on server reset check");
 
             yield return WaitForConditionOrTimeOut(() => asHash ? m_PlayerOnClientAnimator.GetBool(triggerHash) == false : m_PlayerOnClientAnimator.GetBool(triggerString) == false);
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out on client reset check");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out on client reset check");
         }
 
 
@@ -122,11 +122,11 @@ public IEnumerator AnimationStateSyncTest()
 
             // ...and now we should be in the AlphaState having triggered the AlphaParameter
             yield return WaitForConditionOrTimeOut(() => m_PlayerOnServerAnimator.GetCurrentAnimatorStateInfo(0).IsName("AlphaState"));
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Server failed to reach its animation state");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Server failed to reach its animation state");
 
             // ...and now the client should also have sync'd and arrived at the correct state
             yield return WaitForConditionOrTimeOut(() => m_PlayerOnClientAnimator.GetCurrentAnimatorStateInfo(0).IsName("AlphaState"));
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Client failed to sync its animation state from the server");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Client failed to sync its animation state from the server");
         }
 
         [UnityTest]
@@ -143,11 +143,11 @@ public IEnumerator AnimationLayerStateSyncTest()
 
             // ...and now we should be in the AlphaState having triggered the AlphaParameter
             yield return WaitForConditionOrTimeOut(() => m_PlayerOnServerAnimator.GetCurrentAnimatorStateInfo(layer).IsName("Layer2AlphaState"));
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Server failed to reach its animation state");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Server failed to reach its animation state");
 
             // ...and now the client should also have sync'd and arrived at the correct state
             yield return WaitForConditionOrTimeOut(() => m_PlayerOnClientAnimator.GetCurrentAnimatorStateInfo(layer).IsName("Layer2AlphaState"));
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Client failed to sync its animation state from the server");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Client failed to sync its animation state from the server");
         }
 
         [UnityTest]
@@ -166,13 +166,13 @@ public IEnumerator AnimationLayerWeightTest()
             yield return WaitForConditionOrTimeOut(() =>
                 Mathf.Approximately(m_PlayerOnServerAnimator.GetLayerWeight(layer), targetWeight)
             );
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Server failed to reach its animation state");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Server failed to reach its animation state");
 
             // ...and now the client should also have sync'd and arrived at the correct state
             yield return WaitForConditionOrTimeOut(() =>
                 Mathf.Approximately(m_PlayerOnClientAnimator.GetLayerWeight(layer), targetWeight)
             );
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Server failed to reach its animation state");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Server failed to reach its animation state");
         }
 
 
@@ -202,11 +202,11 @@ public IEnumerator AnimationStateSyncTriggerTest([Values(true, false)] bool asHa
 
             // ...and now we should be in the AlphaState having triggered the AlphaParameter
             yield return WaitForConditionOrTimeOut(() => m_PlayerOnServerAnimator.GetCurrentAnimatorStateInfo(0).IsName("TriggeredState"));
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Server failed to reach its animation state via trigger");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Server failed to reach its animation state via trigger");
 
             // ...and now the client should also have sync'd and arrived at the correct state
             yield return WaitForConditionOrTimeOut(() => m_PlayerOnClientAnimator.GetCurrentAnimatorStateInfo(0).IsName("TriggeredState"));
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Client failed to sync its animation state from the server via trigger");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Client failed to sync its animation state from the server via trigger");
         }
 
         [UnityTest]
@@ -227,11 +227,11 @@ public IEnumerator AnimationStateSyncTestWithOverride()
 
             // ...and now we should be in the AlphaState having set the AlphaParameter
             yield return WaitForConditionOrTimeOut(() => HasClip(m_PlayerOnServerAnimator, "OverrideAlphaAnimation"));
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Server failed to reach its overriden animation state");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Server failed to reach its overriden animation state");
 
             // ...and now the client should also have sync'd and arrived at the correct state
             yield return WaitForConditionOrTimeOut(() => HasClip(m_PlayerOnServerAnimator, "OverrideAlphaAnimation"));
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Client failed to reach its overriden animation state");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Client failed to reach its overriden animation state");
         }
     }
 }

com.unity.netcode.gameobjects/Tests/Runtime/NetworkBehaviourUpdaterTests.cs

@@ -290,7 +290,7 @@ public IEnumerator BehaviourUpdaterAllTests([Values] bool useHost,
             {
                 // Waits for all clients to spawn the NetworkObjects
                 yield return WaitForConditionOrTimeOut(() => numberOfObjectsToSpawnOnClients == s_ClientSpawnedNetworkObjects.Count);
-                Assert.IsFalse(s_GloabalTimeoutHelper.TimedOut, $"Timed out waiting for clients to report spawning objects! " +
+                Assert.IsFalse(s_GlobalTimeoutHelper.TimedOut, $"Timed out waiting for clients to report spawning objects! " +
                     $"Total reported client-side spawned objects {s_ClientSpawnedNetworkObjects.Count}");
             }
 
@@ -335,7 +335,7 @@ public IEnumerator BehaviourUpdaterAllTests([Values] bool useHost,
                 yield return WaitForConditionOrTimeOut(() =>
                 clientSideNetVarContainers.Where(d =>
                 d.HaveAllValuesChanged(NetVarValueToSet)).Count() == clientSideNetVarContainers.Count);
-                Assert.IsFalse(s_GloabalTimeoutHelper.TimedOut, $"Timed out waiting for client side NetVarContainers to report all NetworkVariables have been updated!");
+                Assert.IsFalse(s_GlobalTimeoutHelper.TimedOut, $"Timed out waiting for client side NetVarContainers to report all NetworkVariables have been updated!");
             }
 
             Object.DestroyImmediate(prefabToSpawn);

com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectOnSpawnTests.cs

@@ -125,7 +125,7 @@ bool HasConditionBeenMet()
             // now verify that all clients have been spawned
             checkSpawnCondition = true;
             yield return WaitForConditionOrTimeOut(HasConditionBeenMet);
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out while waiting for client side spawns!");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out while waiting for client side spawns!");
 
             // despawn on server.  However, since we'll be using this object later in the test, don't delete it
             serverInstance.GetComponent<NetworkObject>().Despawn(false);
@@ -140,7 +140,7 @@ bool HasConditionBeenMet()
             checkSpawnCondition = false;
             yield return WaitForConditionOrTimeOut(HasConditionBeenMet);
 
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out while waiting for client side despawns!");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out while waiting for client side despawns!");
 
             //----------- step 2 check spawn and destroy again
             serverInstance.GetComponent<NetworkObject>().Spawn();
@@ -152,7 +152,7 @@ bool HasConditionBeenMet()
             checkSpawnCondition = true;
             yield return WaitForConditionOrTimeOut(HasConditionBeenMet);
 
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out while waiting for client side spawns! (2nd pass)");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out while waiting for client side spawns! (2nd pass)");
 
             // destroy the server object
             Object.Destroy(serverInstance.gameObject);
@@ -165,7 +165,7 @@ bool HasConditionBeenMet()
             checkSpawnCondition = false;
             yield return WaitForConditionOrTimeOut(HasConditionBeenMet);
 
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out while waiting for client side despawns! (2nd pass)");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out while waiting for client side despawns! (2nd pass)");
         }
 
         private class TrackOnSpawnFunctions : NetworkBehaviour

com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectSpawnManyObjectsTests.cs

@@ -59,7 +59,7 @@ public IEnumerator WhenManyObjectsAreSpawnedAtOnce_AllAreReceived()
             }
             // ensure all objects are replicated before spawning more
             yield return WaitForConditionOrTimeOut(() => SpawnObjecTrackingComponent.SpawnedObjects < k_SpawnedObjects);
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, $"Timed out waiting for the client to spawn {k_SpawnedObjects} objects!");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, $"Timed out waiting for the client to spawn {k_SpawnedObjects} objects!");
         }
     }
 }

com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformTests.cs

@@ -78,7 +78,7 @@ protected override IEnumerator OnServerAndClientsConnected()
             // Wait for the client-side to notify it is finished initializing and spawning.
             yield return WaitForConditionOrTimeOut(() => otherSideNetworkTransformComponent.ReadyToReceivePositionUpdate == true);
 
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "Timed out waiting for client-side to notify it is ready!");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "Timed out waiting for client-side to notify it is ready!");
 
             yield return base.OnServerAndClientsConnected();
         }
@@ -115,7 +115,7 @@ public IEnumerator TestAuthoritativeTransformChangeOneAtATime([Values] bool test
 
             yield return WaitForConditionOrTimeOut(() => otherSideNetworkTransform.transform.position.x > approximation);
 
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, $"timeout while waiting for position change! Otherside value {otherSideNetworkTransform.transform.position.x} vs. Approximation {approximation}");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, $"timeout while waiting for position change! Otherside value {otherSideNetworkTransform.transform.position.x} vs. Approximation {approximation}");
 
             Assert.True(new Vector3(10, 20, 30) == otherSideNetworkTransform.transform.position, $"wrong position on ghost, {otherSideNetworkTransform.transform.position}"); // Vector3 already does float approximation with ==
 
@@ -125,7 +125,7 @@ public IEnumerator TestAuthoritativeTransformChangeOneAtATime([Values] bool test
 
             yield return WaitForConditionOrTimeOut(() => otherSideNetworkTransform.transform.rotation.eulerAngles.x > approximation);
 
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "timeout while waiting for rotation change");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "timeout while waiting for rotation change");
 
             // approximation needed here since eulerAngles isn't super precise.
             Assert.LessOrEqual(Math.Abs(45 - otherSideNetworkTransform.transform.rotation.eulerAngles.x), approximation, $"wrong rotation on ghost on x, got {otherSideNetworkTransform.transform.rotation.eulerAngles.x}");
@@ -140,7 +140,7 @@ public IEnumerator TestAuthoritativeTransformChangeOneAtATime([Values] bool test
 
             yield return WaitForConditionOrTimeOut(() => otherSideNetworkTransform.transform.lossyScale.x > 1f + approximation);
 
-            Assert.False(s_GloabalTimeoutHelper.TimedOut, "timeout while waiting for scale change");
+            Assert.False(s_GlobalTimeoutHelper.TimedOut, "timeout while waiting for scale change");
 
             UnityEngine.Assertions.Assert.AreApproximatelyEqual(2f, otherSideNetworkTransform.transform.lossyScale.x, "wrong scale on ghost");
             UnityEngine.Assertions.Assert.AreApproximatelyEqual(3f, otherSideNetworkTransform.transform.lossyScale.y, "wrong scale on ghost");