Merge branch 'fixing-disabled-tests-round1' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fixing-disabled-tests-round1

Author: michalChrobot

.yamato/wrench/api-validation-jobs.yml

@@ -13,7 +13,7 @@ api_validation_-_netcode_gameobjects_-_2021_3_-_windows:
     type: Unity::VM
     flavor: b1.large
   commands:
-  - command: curl https://artifactory.prd.it.unity3d.com/artifactory/stevedore-unity-internal/wrench-localapv/1-2-58_ab06748e39f9b01f55b979c0c06d7c1f787e07cbca4dc6ae5eef274fd195612a.zip -o wrench-localapv.zip
+  - command: curl https://artifactory.prd.it.unity3d.com/artifactory/stevedore-unity-internal/wrench-localapv/1-2-59_594aea2e5eb3a7468ad88458b5c5da2e5e72af0d2267db7b025602fb69e57bd7.zip -o wrench-localapv.zip
   - command: 7z x -aoa wrench-localapv.zip
   - command: pip install semver requests --index-url https://artifactory-slo.bf.unity3d.com/artifactory/api/pypi/pypi/simple
   - command: python PythonScripts/print_machine_info.py
@@ -51,8 +51,8 @@ api_validation_-_netcode_gameobjects_-_2021_3_-_windows:
   dependencies:
   - path: .yamato/wrench/package-pack-jobs.yml#package_pack_-_netcode_gameobjects
   variables:
-    UPMPVP_CONTEXT_WRENCH: 0.10.41.0
+    UPMPVP_CONTEXT_WRENCH: 0.10.44.0
   metadata:
     Job Maintainers: '#rm-packageworks'
-    Wrench: 0.10.41.0
+    Wrench: 0.10.44.0
 

.yamato/wrench/package-pack-jobs.yml

@@ -24,5 +24,5 @@ package_pack_-_netcode_gameobjects:
     UPMCI_ACK_LARGE_PACKAGE: 1
   metadata:
     Job Maintainers: '#rm-packageworks'
-    Wrench: 0.10.41.0
+    Wrench: 0.10.44.0
 

.yamato/wrench/preview-a-p-v.yml

@@ -9,7 +9,7 @@ publish_dry_run_netcode_gameobjects:
     type: Unity::VM
     flavor: b1.large
   commands:
-  - command: curl https://artifactory.prd.it.unity3d.com/artifactory/stevedore-unity-internal/wrench-localapv/1-2-58_ab06748e39f9b01f55b979c0c06d7c1f787e07cbca4dc6ae5eef274fd195612a.zip -o wrench-localapv.zip
+  - command: curl https://artifactory.prd.it.unity3d.com/artifactory/stevedore-unity-internal/wrench-localapv/1-2-59_594aea2e5eb3a7468ad88458b5c5da2e5e72af0d2267db7b025602fb69e57bd7.zip -o wrench-localapv.zip
   - command: 7z x -aoa wrench-localapv.zip
   - command: pip install semver requests --index-url https://artifactory-slo.bf.unity3d.com/artifactory/api/pypi/pypi/simple
   - command: python PythonScripts/print_machine_info.py
@@ -148,10 +148,10 @@ publish_dry_run_netcode_gameobjects:
         unzip: true
   variables:
     UPMPVP_ACK_UPMPVP_DOES_NO_API_VALIDATION: 1
-    UPMPVP_CONTEXT_WRENCH: 0.10.41.0
+    UPMPVP_CONTEXT_WRENCH: 0.10.44.0
   metadata:
     Job Maintainers: '#rm-packageworks'
-    Wrench: 0.10.41.0
+    Wrench: 0.10.44.0
 
 # Publish  for netcode.gameobjects to https://artifactory-slo.bf.unity3d.com/artifactory/api/npm/upm-npm
 publish_netcode_gameobjects:
@@ -161,7 +161,7 @@ publish_netcode_gameobjects:
     type: Unity::VM
     flavor: b1.large
   commands:
-  - command: curl https://artifactory.prd.it.unity3d.com/artifactory/stevedore-unity-internal/wrench-localapv/1-2-58_ab06748e39f9b01f55b979c0c06d7c1f787e07cbca4dc6ae5eef274fd195612a.zip -o wrench-localapv.zip
+  - command: curl https://artifactory.prd.it.unity3d.com/artifactory/stevedore-unity-internal/wrench-localapv/1-2-59_594aea2e5eb3a7468ad88458b5c5da2e5e72af0d2267db7b025602fb69e57bd7.zip -o wrench-localapv.zip
   - command: 7z x -aoa wrench-localapv.zip
   - command: pip install semver requests --index-url https://artifactory-slo.bf.unity3d.com/artifactory/api/pypi/pypi/simple
   - command: python PythonScripts/print_machine_info.py
@@ -300,8 +300,8 @@ publish_netcode_gameobjects:
         unzip: true
   variables:
     UPMPVP_ACK_UPMPVP_DOES_NO_API_VALIDATION: 1
-    UPMPVP_CONTEXT_WRENCH: 0.10.41.0
+    UPMPVP_CONTEXT_WRENCH: 0.10.44.0
   metadata:
     Job Maintainers: '#rm-packageworks'
-    Wrench: 0.10.41.0
+    Wrench: 0.10.44.0
 

.yamato/wrench/promotion-jobs.yml

@@ -11,7 +11,7 @@ test_-_wrench_jobs_up_to_date:
   commands:
   - command: dotnet run --project Tools\CI\NGO.Cookbook.csproj
   - command: |-
-      if [ -n "$(git status --porcelain -- .yamato/wrench)"]; then
+      if [ -n "$(git status --porcelain -- .yamato/wrench)" ]; then
         git status
         echo "Your repo is not clean - diff output:"
         git diff
@@ -26,5 +26,5 @@ test_-_wrench_jobs_up_to_date:
     cancel_old_ci: true
   metadata:
     Job Maintainers: '#rm-packageworks'
-    Wrench: 0.10.41.0
+    Wrench: 0.10.44.0
 

.yamato/wrench/recipe-regeneration.yml

@@ -31,7 +31,7 @@
   },
   "publishing_job": ".yamato/wrench/promotion-jobs.yml#publish_netcode_gameobjects",
   "branch_pattern": "ReleaseSlash",
-  "wrench_version": "0.10.41.0",
+  "wrench_version": "0.10.44.0",
   "pvp_exemption_path": ".yamato/wrench/pvp-exemptions.json",
   "cs_project_path": "Tools\\CI\\NGO.Cookbook.csproj"
 }

.yamato/wrench/validation-jobs.yml

@@ -8,7 +8,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-      <PackageReference Include="RecipeEngine.Modules.Wrench" Version="0.10.41" />
+      <PackageReference Include="RecipeEngine.Modules.Wrench" Version="0.10.44" />
     </ItemGroup>
 
 </Project>

.yamato/wrench/wrench_config.json

@@ -158,6 +158,8 @@ public enum NetworkTransformSettings
 
         protected override IEnumerator OnSetup()
         {
+            //TODO: Remove this when we determine what the random failure is
+            m_EnableVerboseDebug = true;
             TestComponentHelper.ClientsRegistered.Clear();
             TestComponentHelper.NetworkObjectIdToIndex.Clear();
             for (int i = 0; i < k_NestedChildren; i++)
@@ -169,6 +171,8 @@ protected override IEnumerator OnSetup()
 
         protected override IEnumerator OnTearDown()
         {
+            //TODO: Remove this when we determine what the random failure is
+            m_EnableVerboseDebug = false;
             if (m_ServerSideParent != null && m_ServerSideParent.GetComponent<NetworkObject>().IsSpawned)
             {
                 // Clean up in reverse order (also makes sure we can despawn parents before children)