fix pvp exceptions

Author: EmandM

com.unity.netcode.gameobjects/TestHelpers/Runtime/NetcodeIntegrationTestHelpers.cs

@@ -215,7 +215,12 @@ private static void AddMockTransport(NetworkManager networkManager)
             networkManager.NetworkConfig.NetworkTransport = mockTransport;
         }
 
-        public static NetworkManager CreateServer(bool mockTransport = false, bool useCmbService = false)
+        /// <summary>
+        /// Creates and configures a new server instance for integration testing.
+        /// </summary>
+        /// <param name="useMockTransport">When true, uses mock transport for testing, otherwise uses real transport. Default value is false</param>
+        /// <returns>The created server <see cref="NetworkManager"/> instance.</returns>
+        public static NetworkManager CreateServer(bool mockTransport = false)
         {
             // Create gameObject
             var go = new GameObject("NetworkManager - Server");
@@ -229,7 +234,7 @@ public static NetworkManager CreateServer(bool mockTransport = false, bool useCm
             }
             else
             {
-                AddUnityTransport(server, useCmbService);
+                AddUnityTransport(server);
             }
             return server;
         }
@@ -242,7 +247,9 @@ public static NetworkManager CreateServer(bool mockTransport = false, bool useCm
         /// <param name="clients">The clients NetworkManagers</param>
         /// <param name="targetFrameRate">The targetFrameRate of the Unity engine to use while the multi instance helper is running. Will be reset on shutdown.</param>
         /// <param name="serverFirst">This determines if the server or clients will be instantiated first (defaults to server first)</param>
-        /// <param name="useCmbService">If true, the server transport will use a mock transport, and the clients will be created with a connection to a locally hosted da service</param>
+        /// <param name="useMockTransport">When true, uses mock transport for testing, otherwise uses real transport. Default value is false</param>
+        /// <param name="useCmbService">If true, all clients will be created with a connection to a locally hosted da service. The server transport will use a mock transport as it is not needed.</param>
+        /// <returns> Returns `true` if the server and client instances were successfully created and configured, otherwise `false`</returns>
         public static bool Create(int clientCount, out NetworkManager server, out NetworkManager[] clients, int targetFrameRate = 60, bool serverFirst = true, bool useMockTransport = false, bool useCmbService = false)
         {
             s_NetworkManagerInstances = new List<NetworkManager>();
@@ -290,6 +297,7 @@ internal static NetworkManager CreateNewClient(int identifier, bool mockTranspor
         /// <param name="clients">Output array containing the created NetworkManager instances</param>
         /// <param name="useMockTransport">When true, uses mock transport for testing, otherwise uses real transport. Default value is false</param>
         /// <param name="useCmbService">If true, each client will be created with transport configured to connect to a locally hosted da service</param>
+        /// <returns> Returns `true` if the clients were successfully created and configured, otherwise `false`</returns>
         public static bool CreateNewClients(int clientCount, out NetworkManager[] clients, bool useMockTransport = false, bool useCmbService = false)
         {
             clients = new NetworkManager[clientCount];

pvpExceptions.json

@@ -179,10 +179,6 @@
           "Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: NetworkManagerInstances: undocumented",
           "Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: void RegisterHandlers(NetworkManager, bool): missing <param name=\"networkManager\">",
           "Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: void RegisterHandlers(NetworkManager, bool): missing <param name=\"serverSideSceneManager\">",
-          "Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: NetworkManager CreateServer(bool): undocumented",
-          "Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: bool Create(int, out NetworkManager, out NetworkManager[], int, bool, bool): missing <param name=\"useMockTransport\">",
-          "Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: bool Create(int, out NetworkManager, out NetworkManager[], int, bool, bool): missing <returns>",
-          "Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: bool CreateNewClients(int, out NetworkManager[], bool): missing <returns>",
           "Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: bool Start(bool, NetworkManager, NetworkManager[], BeforeClientStartCallback, bool): missing <param name=\"startServer\">",
           "Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: uint GetNextGlobalIdHashValue(): undocumented",
           "Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTestHelpers: IsNetcodeIntegrationTestRunning: undocumented",