feat: Remove lag compensation related stuff from config (#622)

Author: LukeStampfli

com.unity.multiplayer.mlapi/Editor/NetworkManagerEditor.cs

@@ -30,7 +30,6 @@ public class NetworkManagerEditor : Editor
     private SerializedProperty m_MaxObjectUpdatesPerTickProperty;
     private SerializedProperty m_ClientConnectionBufferTimeoutProperty;
     private SerializedProperty m_ConnectionApprovalProperty;
-    private SerializedProperty m_SecondsHistoryProperty;
     private SerializedProperty m_EnableTimeResyncProperty;
     private SerializedProperty m_TimeResyncIntervalProperty;
     private SerializedProperty m_EnableNetworkVariableProperty;
@@ -106,7 +105,6 @@ private void Init()
         m_EventTickrateProperty = m_NetworkConfigProperty.FindPropertyRelative("EventTickrate");
         m_ClientConnectionBufferTimeoutProperty = m_NetworkConfigProperty.FindPropertyRelative("ClientConnectionBufferTimeout");
         m_ConnectionApprovalProperty = m_NetworkConfigProperty.FindPropertyRelative("ConnectionApproval");
-        m_SecondsHistoryProperty = m_NetworkConfigProperty.FindPropertyRelative("SecondsHistory");
         m_EnableTimeResyncProperty = m_NetworkConfigProperty.FindPropertyRelative("EnableTimeResync");
         m_TimeResyncIntervalProperty = m_NetworkConfigProperty.FindPropertyRelative("TimeResyncInterval");
         m_EnableNetworkVariableProperty = m_NetworkConfigProperty.FindPropertyRelative("EnableNetworkVariable");
@@ -144,7 +142,6 @@ private void CheckNullProperties()
         m_EventTickrateProperty = m_NetworkConfigProperty.FindPropertyRelative("EventTickrate");
         m_ClientConnectionBufferTimeoutProperty = m_NetworkConfigProperty.FindPropertyRelative("ClientConnectionBufferTimeout");
         m_ConnectionApprovalProperty = m_NetworkConfigProperty.FindPropertyRelative("ConnectionApproval");
-        m_SecondsHistoryProperty = m_NetworkConfigProperty.FindPropertyRelative("SecondsHistory");
         m_EnableTimeResyncProperty = m_NetworkConfigProperty.FindPropertyRelative("EnableTimeResync");
         m_TimeResyncIntervalProperty = m_NetworkConfigProperty.FindPropertyRelative("TimeResyncInterval");
         m_EnableNetworkVariableProperty = m_NetworkConfigProperty.FindPropertyRelative("EnableNetworkVariable");
@@ -309,9 +306,6 @@ public override void OnInspectorGUI()
                 EditorGUILayout.PropertyField(m_ClientConnectionBufferTimeoutProperty);
             }
 
-            EditorGUILayout.LabelField("Lag Compensation", EditorStyles.boldLabel);
-            EditorGUILayout.PropertyField(m_SecondsHistoryProperty);
-
             EditorGUILayout.LabelField("Spawning", EditorStyles.boldLabel);
             EditorGUILayout.PropertyField(m_CreatePlayerPrefabProperty);
             EditorGUILayout.PropertyField(m_ForceSamePrefabsProperty);

com.unity.multiplayer.mlapi/Runtime/Configuration/NetworkConfig.cs

@@ -89,7 +89,7 @@ public class NetworkConfig
         /// <summary>
         /// The amount of times per second internal frame events will occur, e.g. send checking.
         /// </summary>
-        [Tooltip("The amount of times per second the internal event loop will run. This includes for example NetworkVariable checking and LagCompensation tracking")]
+        [Tooltip("The amount of times per second the internal event loop will run. This includes for example NetworkVariable checking.")]
         public int EventTickrate = 64;
 
         /// <summary>
@@ -110,12 +110,6 @@ public class NetworkConfig
         [Tooltip("The connection data sent along with connection requests")]
         public byte[] ConnectionData = new byte[0];
 
-        /// <summary>
-        /// The amount of seconds to keep a lag compensation position history
-        /// </summary>
-        [Tooltip("The amount of seconds to keep lag compensation position history")]
-        public int SecondsHistory = 5;
-
         /// <summary>
         /// If your logic uses the NetworkTime, this should probably be turned off. If however it's needed to maximize accuracy, this is recommended to be turned on
         /// </summary>
@@ -233,7 +227,6 @@ public string ToBase64()
                 writer.WriteInt32Packed(config.EventTickrate);
                 writer.WriteInt32Packed(config.ClientConnectionBufferTimeout);
                 writer.WriteBool(config.ConnectionApproval);
-                writer.WriteInt32Packed(config.SecondsHistory);
                 writer.WriteInt32Packed(config.LoadSceneTimeOut);
                 writer.WriteBool(config.EnableTimeResync);
                 writer.WriteBool(config.EnsureNetworkVariableLengthSafety);
@@ -278,7 +271,6 @@ public void FromBase64(string base64)
                 config.EventTickrate = reader.ReadInt32Packed();
                 config.ClientConnectionBufferTimeout = reader.ReadInt32Packed();
                 config.ConnectionApproval = reader.ReadBool();
-                config.SecondsHistory = reader.ReadInt32Packed();
                 config.LoadSceneTimeOut = reader.ReadInt32Packed();
                 config.EnableTimeResync = reader.ReadBool();
                 config.EnsureNetworkVariableLengthSafety = reader.ReadBool();