fix: PVP issues related to assemblies, file names, and other non-xml-API related (#3444)

## PVP Fixes
This includes fixes for all remaining NGO v2.x PVP errors.

Depends upon
[PR-720](Unity-Technologies/com.unity.multiplayer.tools#720)

<!-- Add short version of the JIRA ticket to the PR title (e.g. "feat:
new shiny feature [MTT-123]") -->

## Changelog

NA

## Testing and Documentation

- Tools tests have been migrated to multiplayer tools repository.
- Tools test project was removed.
- Includes adding `[Obsolete]` to a couple of legacy test related
methods not used by anything.
- Includes updating tests or test related classes, enums, structs (all
unique for existing NGO tests) from being public to internal.
- Includes XML API documentation changes.

### Deprecated API
- [X] An `[Obsolete]` attribute was added.
- [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter
yyyy-mm-dd)` entry.
- [ ] An [api updater] was added.
- [ ] Deprecation of the API is explained in the CHANGELOG.
- [ ] The users can understand why this API was removed and what they
should use instead.


## Backport

A backport similar to this will be required but will not be these
specific changes.

---------

Co-authored-by: michalChrobot <[email protected]>

Author: NoelStephensUnity

.yamato/package-pack.yml

@@ -35,7 +35,7 @@ package_pack_-_ngo_{{ platform.name }}:
 {% endif %}
   timeout: 0.25
   variables:
-    XRAY_PROFILE: "supported ./pvpExceptions.json"
+    XRAY_PROFILE: "gold ./pvpExceptions.json"
   commands:
     - upm-pvp pack "com.unity.netcode.gameobjects" --output upm-ci~/packages
     - upm-pvp xray --packages "upm-ci~/packages/com.unity.netcode.gameobjects*.tgz" --results pvp-results

.yamato/package-tests.yml

@@ -36,7 +36,7 @@ package_test_-_ngo_{{ editor }}_{{ platform.name }}:
     model: {{ platform.model }} # This is set only in platforms where we want non-default model to use (more information in project.metafile)
 {% endif %}
   variables:
-    XRAY_PROFILE: "supported ./pvpExceptions.json"
+    XRAY_PROFILE: "gold ./pvpExceptions.json"
     UNITY_EXT_LOGGING: 1
   commands:
     - unity-downloader-cli --fast --wait -u {{ editor }} -c Editor {% if platform.name == "mac" %} --arch arm64 {% endif %} # For macOS we use ARM64 models.

.yamato/project.metafile

@@ -184,6 +184,3 @@ projects:
         - name: minimalproject
           path: minimalproject
           has_tests: false
-        - name: testproject-tools-integration
-          path: testproject-tools-integration
-          has_tests: true

com.unity.netcode.gameobjects/Editor/AssemblyInfo.cs

@@ -2,7 +2,7 @@
 
 #if UNITY_INCLUDE_TESTS
 #if UNITY_EDITOR
-[assembly: InternalsVisibleTo("Unity.Netcode.EditorTests")]
-[assembly: InternalsVisibleTo("TestProject.RuntimeTests")]
+[assembly: InternalsVisibleTo("Unity.Netcode.Editor.Tests")]
+[assembly: InternalsVisibleTo("TestProject.Runtime.Tests")]
 #endif // UNITY_EDITOR
 #endif // UNITY_INCLUDE_TESTS

com.unity.netcode.gameobjects/Editor/CodeGen/com.unity.netcode.editor.codegen.asmdef renamed to com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef

@@ -1,14 +1,22 @@
 {
-    "name": "Unity.Netcode.Editor.PackageChecker",
+    "name": "Unity.Netcode.PackageChecker.Editor",
     "rootNamespace": "Unity.Netcode.Editor.PackageChecker",
+    "references": [],
     "includePlatforms": [
         "Editor"
     ],
+    "excludePlatforms": [],
+    "allowUnsafeCode": false,
+    "overrideReferences": false,
+    "precompiledReferences": [],
+    "autoReferenced": true,
+    "defineConstraints": [],
     "versionDefines": [
         {
             "name": "com.unity.netcode.adapter.utp",
             "expression": "",
             "define": "COM_UNITY_NETCODE_ADAPTER_UTP"
         }
-    ]
+    ],
+    "noEngineReferences": false
 }