Skip to content

Commit a54e226

Browse files
committed
Linter and comment corrections
1 parent 9d628d8 commit a54e226

File tree

3 files changed

+17
-25
lines changed

3 files changed

+17
-25
lines changed

.yamato/code-coverage.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
{% metadata_file .yamato/project.metafile %}
22
---
33

4-
5-
# This setup performs build-only validation since WebGL runs in browser and for tests to be executed we would need to
6-
# consider having a web server, browser automation and overall complex test setup.
7-
# Default project (testptoject) in this case is used as a context.
8-
# WebGL requires Il2cpp scripting backend so mono is not considered
9-
# ARM64 architectures are not considered since Windows_arm64 is recommended to use only after builds and when it comes to macOS_arm64 there is problem with OpenCL not being available
10-
# Builds are made on each desktop platform as in project.metafile declaration
11-
124
# Runs package tests in order to determine code coverage of the NGO package.
135
# In essence it's performing the same task as .yamato/package-test jobs with the overhead being the measured code coverage
146
# It's ok for code coverage to be performed only on one platform (default) since code coverage won't change much between those.
@@ -23,8 +15,8 @@ code_coverage_{{ platform.name }}_{{ editor }}:
2315
flavor: {{ platform.flavor }}
2416
commands:
2517
- npm install -g upm-ci-utils@stable --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
26-
- unity-downloader-cli {% if platform.extension == "arm64" %} --arch arm64 {% endif %} -u {{ editor }} -c Editor --fast --wait
27-
- {% if platform.name == "Ubuntu" %}DISPLAY=:0 {% endif %} upm-ci package test -u {{ editor }} --package-path com.unity.netcode.gameobjects --enable-code-coverage --code-coverage-options 'generateAdditionalMetrics;generateHtmlReport;assemblyFilters:+Unity.Netcode.Editor,+Unity.Netcode.Runtime' --extra-utr-arg="--extra-editor-arg=--burst-disable-compilation --extra-editor-arg=-testCategory --extra-editor-arg=!Performance --timeout=1800 --reruncount=1 --clean-library-on-rerun"
18+
- unity-downloader-cli -u {{ editor }} -c Editor --fast --wait
19+
- {% if platform.name == "ubuntu" %}DISPLAY=:0 {% endif %} upm-ci package test -u {{ editor }} --package-path com.unity.netcode.gameobjects --enable-code-coverage --code-coverage-options 'generateAdditionalMetrics;generateHtmlReport;assemblyFilters:+Unity.Netcode.Editor,+Unity.Netcode.Runtime' --extra-utr-arg="--extra-editor-arg=--burst-disable-compilation --extra-editor-arg=-testCategory --extra-editor-arg=!Performance --timeout=1800 --reruncount=1 --clean-library-on-rerun"
2820
artifacts:
2921
logs:
3022
paths:

.yamato/project-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ test_{{ project.name }}_{{ platform.name }}_{{ editor }}:
1818
commands:
1919
- npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
2020
- unity-downloader-cli -u {{ editor }} -c Editor --fast --wait
21-
- {% if platform.name == "Ubuntu" %}DISPLAY=:0 && {% endif %}upm-ci project test -u {{ editor }} --project-path {{ project.path }} --type project-tests --extra-utr-arg="--extra-editor-arg=-testCategory --extra-editor-arg=!Performance --reruncount=1 --clean-library-on-rerun"
21+
- {% if platform.name == "ubuntu" %}DISPLAY=:0 && {% endif %}upm-ci project test -u {{ editor }} --project-path {{ project.path }} --type project-tests --extra-utr-arg="--extra-editor-arg=-testCategory --extra-editor-arg=!Performance --reruncount=1 --clean-library-on-rerun"
2222
artifacts:
2323
logs:
2424
paths:

.yamato/webgl-build.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,20 @@ webgl_build_{{ project.name }}_{{ platform }}_{{ editor }}:
4343
./utr --suite=playmode --platform=WebGL --scripting-backend=il2cpp --testproject={{ project.path }} --editor-location=.Editor --artifacts_path=build/test-results --player-save-path=build/players --extra-editor-arg=-batchmode --extra-editor-arg="-cloudEnvironment staging" --extra-editor-arg=-nographics --reruncount=1 --clean-library-on-rerun --build-only
4444
{% endif %}
4545

46-
artifacts:
47-
logs:
48-
paths:
49-
- '*.log'
50-
- '*.xml'
51-
- {{ project.path }}/Logs/**
52-
- {{ project.path }}/Library/*.log
53-
- {{ project.path }}/*.log
54-
- {{ project.path }}/Builds/*.log
55-
- build/test-results/**/*
56-
- build/players/**
57-
variables:
58-
CI: true
59-
ENABLE_BURST_COMPILATION: False
46+
artifacts:
47+
logs:
48+
paths:
49+
- '*.log'
50+
- '*.xml'
51+
- {{ project.path }}/Logs/**
52+
- {{ project.path }}/Library/*.log
53+
- {{ project.path }}/*.log
54+
- {{ project.path }}/Builds/*.log
55+
- build/test-results/**/*
56+
- build/players/**
57+
variables:
58+
CI: true
59+
ENABLE_BURST_COMPILATION: False
6060
{% endfor -%}
6161
{% endfor -%}
6262
{% endfor -%}

0 commit comments

Comments
 (0)