Merge branch 'develop' into fix/nbu-heap-alloc

Author: EmandM

.yamato/_run-all.yml

@@ -17,6 +17,8 @@ run_quick_checks:
   dependencies:
     - .yamato/package-pack.yml#package_pack_-_ngo_ubuntu
     - .yamato/project-standards.yml#standards_ubuntu_testproject_trunk
+    # Run API validation to early-detect all new APIs that would force us to release new minor version of the package. Note that for this to work the package version in package.json must correspond to "actual package state" which means that it should be higher than last released version
+    - .yamato/vetting-test.yml#vetting_test
 
 # Runs all package tests
 run_all_package_tests:

.yamato/_triggers.yml

@@ -108,6 +108,8 @@ develop_nightly:
     # Build player for webgl platform on trunk and 2021 editors
     - .yamato/project-updated-dependencies-test.yml#updated-dependencies_testproject_NGO_ubuntu_trunk
     - .yamato/project-updated-dependencies-test.yml#updated-dependencies_testproject_NGO_win_2021.3
+    # Run API validation to early-detect all new APIs that would force us to release new minor version of the package. Note that for this to work the package version in package.json must correspond to "actual package state" which means that it should be higher than last released version
+    - .yamato/vetting-test.yml#vetting_test
 
 
 # Run all tests on weekly bases

.yamato/package-pack.yml

@@ -37,6 +37,7 @@ package_pack_-_ngo_{{ platform.name }}:
   variables:
     XRAY_PROFILE: "supported ./pvpExceptions.json"
   commands:
+    - python Tools/scripts/release.py # Needed to ensure that CHANGELOG is properly formatted for this test due to the fact that we have bumped package version (to properly perform vetting tests)
     - upm-pvp pack "com.unity.netcode.gameobjects" --output upm-ci~/packages
     - upm-pvp xray --packages "upm-ci~/packages/com.unity.netcode.gameobjects*.tgz" --results pvp-results
     - upm-pvp require {% if platform.name == "win" %}"%XRAY_PROFILE%"{% else %}"$XRAY_PROFILE"{% endif %} --results pvp-results --allow-missing

.yamato/project.metafile

@@ -161,8 +161,9 @@ validation_editors:
         - 6000.1 
         - 6000.2
         - trunk
-        
-        
+    minimal:
+        - 2021.3
+
 # Scripting backends used by Standalone RunTimeTests---------------------------------------------------
 
 scripting_backends: 

.yamato/vetting-test.yml

@@ -0,0 +1,25 @@
+{% metadata_file .yamato/project.metafile %} # All configuration that is used to create different configurations (used in for loops) is taken from this file.
+---
+# DESCRIPTION--------------------------------------------------------------------------
+# This configuration defines vetting tests for the Tools package which allows to validate if the package is in releasable state. This is important in particular because of API validation that allows to detect if we are introducing any new APIs that will force us to bump package version to new minor
+# If this test fails with new API error we should either make those API internal OR bump package version to new minor (note that the package version reflects the current package state)
+
+# Note that we are packing the package only (no project context) so if package have any soft dependencies then project should be used to test it (to enable those APIs)
+{% for editor in validation_editors.minimal -%}
+vetting_test:
+  name: MP Tools - Vetting Test (Win, {{editor}} LTS)
+  agent: { type: Unity::VM, flavor: b1.large, image: package-ci/win11:v4 }
+  commands:
+    - python Tools/scripts/release.py # Needed to ensure that CHANGELOG is properly formatted for this test
+    - npm install -g "upm-ci-utils@stable" --registry https://artifactory.prd.it.unity3d.com/artifactory/api/npm/upm-npm
+    - unity-downloader-cli --fast --wait --unity-version {{ editor }} --components editor --arch x64
+    - upm-ci package pack --package-path com.unity.netcode.gameobjects
+    - upm-ci package test -u .Editor --package-path com.unity.netcode.gameobjects --type vetting-tests
+  artifacts:
+    logs:
+      paths:
+        - pvp-results/*
+        - test-results/**
+        - upm-ci~/test-results/**
+        - upm-ci~/upm-ci.log
+{% endfor -%}

.yamato/wrench/recipe-regeneration.yml

@@ -9,14 +9,14 @@ test_-_wrench_jobs_up_to_date:
     type: Unity::VM
     flavor: b1.large
   commands:
-  - command: dotnet run --project Tools\CI\NGO.Cookbook.csproj
+  - command: dotnet run --project Tools/CI/NGO.Cookbook.csproj
   - command: |-
       if [ -n "$(git status --porcelain -- .yamato/wrench)" ]; then
         git status
         echo "Your repo is not clean - diff output:"
         git diff
         echo "You must run recipe generation after updating recipes to update the generated YAML!"
-        echo "Run 'dotnet run --project Tools\CI\NGO.Cookbook.csproj' from the root of your repository to regenerate all job definitions created by wrench."
+        echo "Run 'dotnet run --project Tools/CI/NGO.Cookbook.csproj' from the root of your repository to regenerate all job definitions created by wrench."
         exit 1
       fi
   variables: