Implemented checks for NetworkedVar Write permission

Author: TwoTenPvP

MLAPI/MonoBehaviours/Core/NetworkedBehaviour.cs

@@ -993,24 +993,50 @@ internal void NetworkedVarUpdate()
             }
         }
 
-        internal void HandleNetworkedVarDeltas(BitReader reader)
+        internal void HandleNetworkedVarDeltas(BitReader reader, uint clientId)
         {
             for (int i = 0; i < networkedVarFields.Count; i++)
             {
                 if (!reader.ReadBool())
                     continue;
 
+                if (isServer && !networkedVarFields[i].CanClientWrite(clientId))
+                {
+                    //This client wrote somewhere they are not allowed. This is critical
+                    //We can't just skip this field. Because we don't actually know how to dummy read
+                    //That is, we don't know how many bytes to skip. Because the interface doesn't have a 
+                    //Read that gives us the value. Only a Read that applies the value straight away
+                    //A dummy read COULD be added to the interface for this situation, but it's just being too nice.
+                    //This is after all a developer fault. A critical error should be fine.
+                    // - TwoTen
+                    if (LogHelper.CurrentLogLevel <= LogLevel.Error) LogHelper.LogError("Client wrote to NetworkedVar without permission. No more variables can be read. This is critical");
+                    return;
+                }
+
                 networkedVarFields[i].SetDeltaFromReader(reader);
             }
         }
 
-        internal void HandleNetworkedVarUpdate(BitReader reader)
+        internal void HandleNetworkedVarUpdate(BitReader reader, uint clientId)
         {
             for (int i = 0; i < networkedVarFields.Count; i++)
             {
                 if (!reader.ReadBool())
                     continue;
 
+                if (isServer && !networkedVarFields[i].CanClientWrite(clientId))
+                {
+                    //This client wrote somewhere they are not allowed. This is critical
+                    //We can't just skip this field. Because we don't actually know how to dummy read
+                    //That is, we don't know how many bytes to skip. Because the interface doesn't have a 
+                    //Read that gives us the value. Only a Read that applies the value straight away
+                    //A dummy read COULD be added to the interface for this situation, but it's just being too nice.
+                    //This is after all a developer fault. A critical error should be fine.
+                    // - TwoTen
+                    if (LogHelper.CurrentLogLevel <= LogLevel.Error) LogHelper.LogError("Client wrote to NetworkedVar without permission. No more variables can be read. This is critical");
+                    return;
+                }
+
                 networkedVarFields[i].SetFieldFromReader(reader);
             }
         }

MLAPI/NetworkingManagerComponents/Core/InternalMessageHandler.Receive.cs

@@ -378,7 +378,7 @@ internal static void HandleNetworkedVarDelta(uint clientId, BitReader reader, in
                 return;
             }
 
-            SpawnManager.spawnedObjects[netId].GetBehaviourAtOrderIndex(orderIndex).HandleNetworkedVarDeltas(reader);
+            SpawnManager.spawnedObjects[netId].GetBehaviourAtOrderIndex(orderIndex).HandleNetworkedVarDeltas(reader, clientId);
         }
 
         internal static void HandleNetworkedVarUpdate(uint clientId, BitReader reader, int channelId)
@@ -397,7 +397,7 @@ internal static void HandleNetworkedVarUpdate(uint clientId, BitReader reader, i
                 return;
             }
 
-            SpawnManager.spawnedObjects[netId].GetBehaviourAtOrderIndex(orderIndex).HandleNetworkedVarUpdate(reader);
+            SpawnManager.spawnedObjects[netId].GetBehaviourAtOrderIndex(orderIndex).HandleNetworkedVarUpdate(reader, clientId);
         }
     }
 }